|author||Daniel McArdle <firstname.lastname@example.org>||Wed Jan 06 17:26:55 2021 -0500|
|committer||CQ bot account: email@example.com <firstname.lastname@example.org>||Thu Jan 07 22:59:08 2021 +0000|
Optimize suffix building in FileTest::ReadNext(). Updating HPKE to draft-irtf-cfrg-hpke-07 added a number of tests to crypto/hpke/hpke_test_vectors.txt. The time to run HPKE crypto tests increased from 0.09 to 0.56 seconds (averaged over 6 runs). The runtime for the whole crypto_test suite increased from 86.44 to 88.19 (measured once). Profiling revealed an excessive amount of CPU time (~50% for HPKE tests) spent on std::map lookups in ReadNext(). I found a slow loop that computes the suffix for a repeated attribute by hammering a std::map with incremental guesses. This CL adds a std::map<std::string, size_t> for counting repeated attributes, eliminating the need for the loop. This reduces the runtime for HPKE tests from 0.56 to 0.12 seconds (averaged over 6 runs). For the whole crypto_test suite, runtime is reduced from 88.19 to 86.71 seconds (measured once). Change-Id: Ie87f4a7f3edc95d434226d2959dcf09974f0656f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/44905 Commit-Queue: David Benjamin <email@example.com> Reviewed-by: David Benjamin <firstname.lastname@example.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: