commit | 1500ad0533fa43ea27ffb1338b96e352d3706dc7 | [log] [tgz] |
---|---|---|
author | David Benjamin <davidben@google.com> | Mon Jun 13 12:33:07 2022 -0400 |
committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 15 18:16:52 2022 +0000 |
tree | 5288d99040cf5e1a4deddc52277e6a15345c2d8f | |
parent | 955ef7991e41ac6c0ea5114b4b9abb98cc5fd614 [diff] |
Define STACK_OF(OPENSSL_STRING) more straight-forwardly. This results in one change, which is the comparison function goes from: typedef char *OPENSSL_STRING; static int sk_strcmp(const OPENSSL_STRING *a, const OPENSSL_STRING *b); which is: static int sk_strcmp(char *const *a, char *const *b) into: static int sk_strcmp(const char **a, const char **b) Neither is correct (both consts should be there), but switching the defintion is necessary to attach the 'const' to 'char' itself. Otherwise it wouldn't see through the typedef. Fixing the rest of the calling convention will finish the job. Plan there is, when I00d13c949a535c0d60873fe4ba2e5604bb585cca lands, I'll switch Envoy to call that. Then we should be clear to const-correct the callback. (While STACK_OF(OPENSSL_STRING) is used externally, nothing external touches the comparison function.) Bug: 498 Change-Id: I77bdf2a72b2553bf9409a1d39326890ed5c3582c Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/53008 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: