tree f9a5d7b88bd9e8d849323757c1e2be6b7923faba
parent 3b6cebb1e052f5e4b41ca79f234d33fc709484e4
author David Benjamin <davidben@google.com> 1628565453 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> 1631137783 +0000

Check for invalid CHOICE selectors in i2d functions.

This handles normal CHOICE types. A follow-up CL will handle MSTRING and
ANY types.

Update-Note: An invalid CHOICE object (e.g. GENERAL_NAME) will now fail
when encoded, rather than be silently omitted. In particular, CHOICE
objects are default-initialized by tasn_new.c in an empty -1 state.
Structures containing a required CHOICE field can no longer be encoded
without filling in the CHOICE.

Bug: 429
Change-Id: I7011deadf518ddc344a56b07a0e268ceaae17fe0
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49347
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>