| commit | 3b8c5ec1f6dfac6b1aa5a060990216819ff298a7 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Apr 12 17:43:23 2021 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Apr 13 17:24:26 2021 +0000 |
| tree | 25e77d263aea60835b6db149b8a4dbe8c600a6fa | |
| parent | e2b7bb72216e88b8238083af63c3ecb244e79891 [diff] |
Rearrange key share and early data logic. We currently determine whether we need HelloRetryRequest at the same time as resolving key share machinery. That is a little too late for early data negotiation, so we end up accepting early data and then clearing it later on in the function. This works but is easy to mess up, given the preceding CL. There's also some ALPS logic that got this wrong, but I believe it didn't result in any incorrect behavior. Instead, this pulls secret computation out of the key_share helper function, which now just finds the matching key share. We then check early whether we need HRR, before deciding on early data. Change-Id: I108865da08addfefed4a7db73c60e11cf4335093 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46765 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: