tree daafa2d68508aa18454c4113225a086f7cb86eac
parent 2cf7a2cdea9af3a76b0b4cf6316e02cdfa8fe284
author David Benjamin <davidben@google.com> 1625160111 -0400
committer Adam Langley <agl@google.com> 1625675778 +0000

Remove -2 return value from X509*_get_*_by_NID.

X509*_get_*_by_NID return -1 if the extension was not found, but -2 if
the NID was invalid. Looking through callers, many check index != -1,
rather than index < 0. That means, in theory, they'll do the wrong thing
in some cases.

Realistically, this case is impossible: most callers pass in a constant.
Even in those that don't, NIDs are a local enum, not standard constants.
That means hitting this path is almost certainly a programmer error. No
need to complicate the calling convention for it.

Update-Note: The return value convention of some functions was
simplified. This is not expected to affect any callers.

Change-Id: If2f5a45c37caccdbfcc3296ff2db6db1183e3a95
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/48368
Reviewed-by: Adam Langley <agl@google.com>