| commit | 6ff942985389b9b64b944b98ab3e8a66e1eb436d | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon May 10 15:42:40 2021 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Thu May 13 16:17:12 2021 +0000 |
| tree | 0d59f3252dd1f51bee16398e7d59a69f40536b36 | |
| parent | 1f6c3dc7d736357d5454a73217d47ce93d2fb240 [diff] |
Don't use SHA256(ticket) as the signaling session ID for tickets. We've inherited some behavior from OpenSSL where, in ticket-based client sessions, we fill in a placeholder session ID of SHA256(ticket). This was done to avoid confusing other code in OpenSSL (and possibly callers?) that assumed session_id_length != 0 determined validity. Separately, TLS 1.2 session tickets are syntactically weird. The client generates a fake signaling session ID, which the server echoes on resumption. These combined meant we used the placeholder SHA256 value as this signaling ID. Since we already have code to generate random session IDs for TLS 1.3, use that instead to minimize unnecessary implementation quirks visible on the wire. This removes one of the places we still rely on the placeholders within the library. Change-Id: I0de2781da72e2bbc030505611589c853f105ce9d Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/47446 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: