tree eed767faf412aa041b90342ba5850cc09ca5458e
parent d9ee55a89f9eee0c8febccc1091b4770401407ef
author David Benjamin <davidben@google.com> 1616169228 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1616435876 +0000

Fix unnecessarily direction-specific tests in cipher_tests.txt

All our EVP_CIPHERs are deterministic, so there's usually no point in
testing only one direction. Some of the ECB tests were missing free
decryption tests. CTR is the same in both directions, but we ought to
test the API agrees. OFB vectors are doubled up, so we can merge them
together. Plus there are typos in the OFB-AES192.Decrypt tests, also
present upstream, so we weren't actually testing everything we should.

(I haven't removed the direction-specific logic altogether since the
tests imported from nist_cavp rely on it. Though there may be something
to be said for running them both ways since they don't actually double
them up...)

Change-Id: I36a77d342afa436e89ad244a87567e1a4c6ee9dc
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46284
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>