tree fa2f667325e76499e7900095e03fbe30c00d9177
parent 477b309bf1a329ab4a666db7e40792898059ad53
author David Benjamin <davidben@google.com> 1616343856 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1616445416 +0000

Do not access value.ptr with V_ASN1_BOOLEAN.

This fixes a bug in ASN1_TYPE_get. Partly imported from upstream's
261ec72d58af64327214a78ca1c54b169ad93c28, though I don't believe
ASN1_TYPE_set was broken per se. There's also a lot more than in that
commit.

I've added a test to ensure we maintain the unused bits invariant
anyway, in case external code relies on it. (The invariant comes from
the pointer being NULL-initialized and from ASN1_primitive_free zeroing
*pval on free.)

Change-Id: I4c0c57519a7628041d81c26cd850317e01409556
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46324
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>