| commit | 34e474f794fcc6338cc8ee5aab7123c11e8f998b | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Aug 31 12:57:55 2022 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 31 19:18:54 2022 +0000 |
| tree | f81111f4f1ff33bba796b8bae06546150c04b30d | |
| parent | 10fef972e47d1621b76af959733802167b8d4075 [diff] |
Check set_encrypt_key return value in AESTest.ABI. On aarch64 and x86_64 ABIs, the unused bits of 32-bit parameters have unspecified value. That means if, say, the aarch64 aes_hw_set_encrypt_key accessed the 'bits' parameter as X1 rather than W1, it could get a different value from what C passed in. To test this, our ABI testing framework fills the upper half of the register with garbage. However, set_encrypt_key just cleanly returns error on unrecognized bit length. So, to check that this all worked correctly, we need to assert that the return value was correct. Looking at the assembly, they all handle it correctly, but now we'll also test it. (Note these functions break the usual convention and use zero as the success value.) Change-Id: Icaf65ea54564ebfe3696b42287488fe3f72ef138 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/54205 Commit-Queue: David Benjamin <davidben@google.com> Commit-Queue: Bob Beck <bbe@google.com> Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: