| commit | 07100c6e69061738f48481e2d42ad403248b24a6 | [log] [tgz] |
|---|---|---|
| author | Adam Langley <agl@google.com> | Fri Jan 16 15:20:54 2015 -0800 |
| committer | Adam Langley <agl@google.com> | Wed Jan 21 00:27:26 2015 +0000 |
| tree | 2916dfa46fbd00933dd79d935f1426755c82326e | |
| parent | 4dcb05729fc4e0ea93326805bc5ddc2c2953530f [diff] |
Only use -Wshadow with GCC > 4.6.0. Prior to 4.6.0, -Wshadow would cause GCC to warn when variables shadowed global functions. Since libc defines a number of functions with common names, this is a problem. Also, without this change, we'll keep breaking on older versions of GCC because we won't be testing with them. OpenBSD, specifically is reported to have a problem: https://boringssl-review.googlesource.com/#/c/2900/ (Note the test should really be >= 4.6.0, but CMake doesn't have a VERSION_GREATEROREQUAL.) Change-Id: I1aedda01ab629e138c8781e4319bfaaed0b236b0 Reviewed-on: https://boringssl-review.googlesource.com/2952 Reviewed-by: Adam Langley <agl@google.com>