| commit | 908b1300ff4ed3cfc3c965d846560f2593a51491 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Jan 16 15:17:16 2023 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Feb 07 22:33:14 2023 +0000 |
| tree | e5d9d81d0a3f2cb0da9d995dd9317bb02fc6ef48 | |
| parent | 49d7b2d6a4d586e2debfa847e81b5ad9a9d3218a [diff] |
Don't use object reuse in X509_parse_from_buffer. Instead, move the CRYPTO_BUFFER into ASN1_ENCODING (due to padding, upgrading the two bitfields do a pointer doesn't increase memory usage), and instead thread a CRYPTO_BUFFER parameter through tasn_dec.c. Later, I want to reimplement the X509 and X509_CINF parsers with CBS/CBB directly (https://crbug.com/boringssl/547), but that will be easier once the whole crypto/asn1 machinery is rewritten with CBS/CBB (https://crbug.com/boringssl/548). That, in turn, will be easier with object reuse gone. But to get rid of object reuse, I need to remove the one place in the library where we ourselves use it. Bug: 550 Change-Id: Ia4df3da9280f808b124ac1f4ad58745dfe0f49e2 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/56646 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: