tree 617000509e9bbbf46e44087ae09f26bd8e5a7fb1
parent 5799ebfe5f895ecd29fcd699789854fc1790d6cd
author Adam Langley <alangley@gmail.com> 1627681882 -0700
committer Adam Langley <alangley@gmail.com> 1627924202 +0000

Don't overread in poly_Rq_mul

The polynomials have 701, 16-bit values. But poly_Rq_mul was reading 32
bytes at offset 1384 in order to get the last 18 of them. This silently
worked for a long time, but when 7153013019 switched to keeping
variables on the stack it was noticed by Valgrind.

This change fixes the overread. Setting watchpoints at the ends of the
two inputs (and one output) now shows no overreads nor overwrites.

BUG=424

Change-Id: Id86c1407ffce66593541c10feee47213f4b95c5d
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/48645
Reviewed-by: David Benjamin <davidben@google.com>