commit 0b9db441c8847b514030d65847ff3c008a6fbeac
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Tue Jan 07 10:14:54 2020 +0100
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Tue Jan 07 10:14:54 2020 +0100
tree 678a33dbc0ff54370236e0310a32476adfddaf03
parent 792b16d83beae41997f3c4dae0c5e1ae0c42c080

Make optional parameter validation more precise

library/sha512.c

diff --git a/library/sha512.c b/library/sha512.c
index fc21331..fbb034f 100644
--- a/library/sha512.c
+++ b/library/sha512.c
@@ -132,7 +132,11 @@
 int mbedtls_sha512_starts_ret( mbedtls_sha512_context *ctx, int is384 )
 {
     SHA512_VALIDATE_RET( ctx != NULL );
+#if !defined(MBEDTLS_SHA512_NO_SHA384)
     SHA512_VALIDATE_RET( is384 == 0 || is384 == 1 );
+#else
+    SHA512_VALIDATE_RET( is384 == 0 );
+#endif
 
     ctx->total[0] = 0;
     ctx->total[1] = 0;
@@ -475,7 +479,11 @@
     int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
     mbedtls_sha512_context ctx;
 
+#if !defined(MBEDTLS_SHA512_NO_SHA384)
     SHA512_VALIDATE_RET( is384 == 0 || is384 == 1 );
+#else
+    SHA512_VALIDATE_RET( is384 == 0 );
+#endif
     SHA512_VALIDATE_RET( ilen == 0 || input != NULL );
     SHA512_VALIDATE_RET( (unsigned char *)output != NULL );