commit 1215c54754bc3a40efafc74d65c5155923934c22
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Fri Jun 19 11:59:49 2020 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Fri Jun 19 11:59:49 2020 +0200
tree af775dd24d8f5af53beb0240dddc69451b6e9074
parent 4539a45cbff9dbf273121addb505ee2d0e75a557

Add length check in ecp_drbg_seed()

While this is a static function, so right now we know we don't need the check,
things may change in the future, so better be on the safe side.

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index be9e42d..7b20516 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -181,6 +181,12 @@
     const mbedtls_md_type_t md_type = mbedtls_md_list()[0];
     const mbedtls_md_info_t *md_info = mbedtls_md_info_from_type( md_type );
 
+    if( secret_len > MBEDTLS_ECP_MAX_BYTES )
+    {
+        ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
+        goto cleanup;
+    }
+
     MBEDTLS_MPI_CHK( mbedtls_mpi_write_binary( secret,
                                                secret_bytes, secret_len ) );
 
@@ -237,6 +243,12 @@
     int ret;
     unsigned char secret_bytes[MBEDTLS_ECP_MAX_BYTES];
 
+    if( secret_len > MBEDTLS_ECP_MAX_BYTES )
+    {
+        ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
+        goto cleanup;
+    }
+
     MBEDTLS_MPI_CHK( mbedtls_mpi_write_binary( secret,
                                                secret_bytes, secret_len ) );