commit 2d0aa8be97bad9e8d65276716833f1e6d117c5b2
author Andres Amaya Garcia <Andres.AmayaGarcia@arm.com> Fri Jul 21 14:57:26 2017 +0100
committer Andres Amaya Garcia <Andres.AmayaGarcia@arm.com> Fri Jul 21 14:57:26 2017 +0100
tree 5a6027a8d2ac34454c46a46a454dcce36f134f58
parent aa464ef23a49e386515e5245c444f202e45e2e4f

Fix MD selftest to use correct type and expose ret

library/md4.c

diff --git a/library/md4.c b/library/md4.c
index 1121fd1..f5972eb 100644
--- a/library/md4.c
+++ b/library/md4.c
@@ -352,7 +352,7 @@
 /*
  * RFC 1320 test vectors
  */
-static const char md4_test_str[7][81] =
+static const unsigned char md4_test_str[7][81] =
 {
     { "" },
     { "a" },
@@ -360,10 +360,15 @@
     { "message digest" },
     { "abcdefghijklmnopqrstuvwxyz" },
     { "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789" },
-    { "12345678901234567890123456789012345678901234567890123456789012" \
+    { "12345678901234567890123456789012345678901234567890123456789012"
       "345678901234567890" }
 };
 
+static const size_t md4_test_strlen[7] =
+{
+    0, 1, 3, 14, 26, 62, 80
+};
+
 static const unsigned char md4_test_sum[7][16] =
 {
     { 0x31, 0xD6, 0xCF, 0xE0, 0xD1, 0x6A, 0xE9, 0x31,
@@ -387,7 +392,7 @@
  */
 int mbedtls_md4_self_test( int verbose )
 {
-    int i;
+    int i, ret = 0;
     unsigned char md4sum[16];
 
     for( i = 0; i < 7; i++ )
@@ -395,12 +400,15 @@
         if( verbose != 0 )
             mbedtls_printf( "  MD4 test #%d: ", i + 1 );
 
-        if( mbedtls_md4_ext( (unsigned char *) md4_test_str[i],
-                             strlen( md4_test_str[i] ), md4sum ) != 0 )
+        ret = mbedtls_md4_ext( md4_test_str[i], md4_test_strlen[i], md4sum );
+        if( ret != 0 )
             goto fail;
 
         if( memcmp( md4sum, md4_test_sum[i], 16 ) != 0 )
+        {
+            ret = 1;
             goto fail;
+        }
 
         if( verbose != 0 )
             mbedtls_printf( "passed\n" );
@@ -415,7 +423,7 @@
     if( verbose != 0 )
         mbedtls_printf( "failed\n" );
 
-    return( 1 );
+    return( ret );
 }
 
 #endif /* MBEDTLS_SELF_TEST */