commit 3d53f416389103fc2c1d507906a4f6c04c19a247
author Alexey Skalozub <pieceofsummer@gmail.com> Wed Jan 13 16:53:40 2016 +0200
committer Simon Butcher <simon.butcher@arm.com> Mon Apr 25 16:00:50 2016 +0100
tree 9121ba838907103548af97d8a15667136b5236b9
parent 8a3170571e886718699776777ab7fbb44320d4f1

Faster mbedtls_zeroize for MPI

Writes in `sizeof(mbedtls_mpi_uint)` units perform faster than plain chars, also eliminates multiplication by `ciL`

library/bignum.c

diff --git a/library/bignum.c b/library/bignum.c
index 7841bea..07e099a 100644
--- a/library/bignum.c
+++ b/library/bignum.c
@@ -59,8 +59,8 @@
 #endif
 
 /* Implementation that should never be optimized out by the compiler */
-static void mbedtls_zeroize( void *v, size_t n ) {
-    volatile unsigned char *p = v; while( n-- ) *p++ = 0;
+static void mbedtls_zeroize( mbedtls_mpi_uint *v, size_t n ) {
+    volatile mbedtls_mpi_uint *p = v; while( n-- ) *p++ = 0;
 }
 
 #define ciL    (sizeof(mbedtls_mpi_uint))         /* chars in limb  */
@@ -99,7 +99,7 @@
 
     if( X->p != NULL )
     {
-        mbedtls_zeroize( X->p, X->n * ciL );
+        mbedtls_zeroize( X->p, X->n );
         mbedtls_free( X->p );
     }
 
@@ -126,7 +126,7 @@
         if( X->p != NULL )
         {
             memcpy( p, X->p, X->n * ciL );
-            mbedtls_zeroize( X->p, X->n * ciL );
+            mbedtls_zeroize( X->p, X->n );
             mbedtls_free( X->p );
         }
 
@@ -164,7 +164,7 @@
     if( X->p != NULL )
     {
         memcpy( p, X->p, i * ciL );
-        mbedtls_zeroize( X->p, X->n * ciL );
+        mbedtls_zeroize( X->p, X->n );
         mbedtls_free( X->p );
     }