commit 5a87c9375da05c8fefa1e503acdf4dafead1ccaa
author Andres AG <andres.amayagarcia@arm.com> Mon Sep 26 14:53:05 2016 +0100
committer Andres AG <andres.amayagarcia@arm.com> Wed Sep 28 14:26:57 2016 +0100
tree d8306eda679cec07d69b93a83ec6de661e0f03c1
parent 93012e8bce9788244238ab8f93b2544d1d030b89

Fix overread when verifying SERVER_HELLO in DTLS

ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 60383a9..ca6f928 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -29,6 +29,8 @@
      a contribution from Tobias Tangemann. #541
    * Fixed cert_app sample program for debug output and for use when no root
      certificates are provided.
+   * Fix potential byte overread when verifying malformed SERVER_HELLO in
+     ssl_parse_hello_verify_request() for DTLS. Found by Guido Vranken.
 
 Changes
    * Extended test coverage of special cases, and added new timing test suite.

library/ssl_cli.c

diff --git a/library/ssl_cli.c b/library/ssl_cli.c
index 29a3943..39fcd6c 100644
--- a/library/ssl_cli.c
+++ b/library/ssl_cli.c
@@ -1355,6 +1355,15 @@
     cookie_len = *p++;
     MBEDTLS_SSL_DEBUG_BUF( 3, "cookie", p, cookie_len );
 
+    if( ( ssl->in_msg + ssl->in_msglen ) - p < cookie_len )
+    {
+        MBEDTLS_SSL_DEBUG_MSG( 1,
+            ( "cookie length does not match incoming message size" ) );
+        mbedtls_ssl_send_alert_message( ssl, MBEDTLS_SSL_ALERT_LEVEL_FATAL,
+                                    MBEDTLS_SSL_ALERT_MSG_DECODE_ERROR );
+        return( MBEDTLS_ERR_SSL_BAD_HS_SERVER_HELLO );
+    }
+
     mbedtls_free( ssl->handshake->verify_cookie );
 
     ssl->handshake->verify_cookie = mbedtls_calloc( 1, cookie_len );