commit 5ad68e42e5ff080b312963276d7a06d13913636c
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Nov 28 17:11:54 2013 +0100
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Nov 28 18:07:39 2013 +0100
tree 4705a285c43dbfcff1bf0a927cc452c7b205026b
parent 964bf9b92f866167214d01cb3afdc533dcc4dfe7

Mutex x509_crt_parse_path() when pthreads is used

library/x509_crt.c

diff --git a/library/x509_crt.c b/library/x509_crt.c
index 5330bf1..63ab403 100644
--- a/library/x509_crt.c
+++ b/library/x509_crt.c
@@ -51,6 +51,10 @@
 #define polarssl_free       free
 #endif
 
+#if defined(POLARSSL_THREADING_C)
+#include "polarssl/threading.h"
+#endif
+
 #include <string.h>
 #include <stdlib.h>
 #if defined(_WIN32) && !defined(EFIX64) && !defined(EFI32)
@@ -936,6 +940,10 @@
     return( ret );
 }
 
+#if defined(POLARSSL_THREADING_PTHREAD)
+static threading_mutex_t readdir_mutex = PTHREAD_MUTEX_INITIALIZER;
+#endif
+
 int x509_crt_parse_path( x509_crt *chain, const char *path )
 {
     int ret = 0;
@@ -1000,6 +1008,11 @@
     if( dir == NULL)
         return( POLARSSL_ERR_X509_FILE_IO_ERROR );
 
+#if defined(POLARSSL_THREADING_PTHREAD)
+    if( ( ret = polarssl_mutex_lock( &readdir_mutex ) ) != 0 )
+        return( ret );
+#endif
+
     while( ( entry = readdir( dir ) ) != NULL )
     {
         snprintf( entry_name, sizeof entry_name, "%s/%s", path, entry->d_name );
@@ -1007,7 +1020,8 @@
         if( stat( entry_name, &sb ) == -1 )
         {
             closedir( dir );
-            return( POLARSSL_ERR_X509_FILE_IO_ERROR );
+            ret = POLARSSL_ERR_X509_FILE_IO_ERROR;
+            goto cleanup;
         }
 
         if( !S_ISREG( sb.st_mode ) )
@@ -1022,6 +1036,13 @@
             ret += t_ret;
     }
     closedir( dir );
+
+cleanup:
+#if defined(POLARSSL_THREADING_PTHREAD)
+    if( polarssl_mutex_unlock( &readdir_mutex ) != 0 )
+        ret = POLARSSL_ERR_THREADING_MUTEX_ERROR;
+#endif
+
 #endif /* _WIN32 */
 
     return( ret );