commit 9028c5af9a61b9113edff8c6d0bcad767ebdb459
author Manuel Pégourié-Gonnard <mpg2@elzevir.fr> Wed Aug 12 14:51:36 2015 +0200
committer Manuel Pégourié-Gonnard <mpg2@elzevir.fr> Mon Sep 07 12:43:09 2015 +0200
tree 7e3aecf495fb2a33da058ff295166a747eb24af6
parent 082767ff0c2b1f3d7bcc83393c6899320853d385

Improve const correctness of read() functions

library/ecjpake.c

diff --git a/library/ecjpake.c b/library/ecjpake.c
index 9e074c9..f56142c 100644
--- a/library/ecjpake.c
+++ b/library/ecjpake.c
@@ -185,7 +185,7 @@
                              const mbedtls_ecp_point *G,
                              const mbedtls_ecp_point *X,
                              const char *id,
-                             unsigned char **p,
+                             const unsigned char **p,
                              const unsigned char *end )
 {
     int ret;
@@ -207,8 +207,7 @@
     if( end < *p )
         return( MBEDTLS_ERR_ECP_BAD_INPUT_DATA );
 
-    MBEDTLS_MPI_CHK( mbedtls_ecp_tls_read_point( grp, &V,
-                     (const unsigned char **) p, end - *p ) );
+    MBEDTLS_MPI_CHK( mbedtls_ecp_tls_read_point( grp, &V, p, end - *p ) );
 
     if( end < *p || (size_t)( end - *p ) < 1 )
     {
@@ -217,6 +216,7 @@
     }
 
     r_len = *(*p)++;
+
     if( end < *p || (size_t)( end - *p ) < r_len )
     {
         ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
@@ -257,7 +257,7 @@
                              const mbedtls_ecp_point *G,
                              mbedtls_ecp_point *X,
                              const char *id,
-                             unsigned char **p,
+                             const unsigned char **p,
                              const unsigned char *end )
 {
     int ret;
@@ -271,8 +271,7 @@
      *     ECSchnorrZKP zkp;
      * } ECJPAKEKeyKP;
      */
-    MBEDTLS_MPI_CHK( mbedtls_ecp_tls_read_point( grp, X,
-                    (const unsigned char **) p, end - *p ) );
+    MBEDTLS_MPI_CHK( mbedtls_ecp_tls_read_point( grp, X, p, end - *p ) );
     MBEDTLS_MPI_CHK( ecjpake_zkp_read( md_info, grp, G, X, id, p, end ) );
 
 cleanup:
@@ -329,7 +328,7 @@
                               size_t len )
 {
     int ret;
-    unsigned char *p = (unsigned char *) buf;
+    const unsigned char *p = buf;
     const unsigned char *end = buf + len;
 
     /*