commit 947bb0b06fe631155c6f78ef175dbac96f6f7b70
author Steven Cooreman <steven.cooreman@silabs.com> Thu Feb 25 10:33:30 2021 +0100
committer Steven Cooreman <steven.cooreman@silabs.com> Mon Mar 01 16:09:24 2021 +0100
tree 7d15ce077829eb49986fb7cd5bbb73c9b0e965c1
parent a1d8322f74d0df03c5acd8b42ca506dde2bd5c0d

Code readability improvements

Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

programs/psa/psa_constant_names_generated.c

diff --git a/programs/psa/psa_constant_names_generated.c b/programs/psa/psa_constant_names_generated.c
index b1a801f..f797c02 100644
--- a/programs/psa/psa_constant_names_generated.c
+++ b/programs/psa/psa_constant_names_generated.c
@@ -154,33 +154,24 @@
             append(&buffer, buffer_size, &required_size,
                    "PSA_ALG_AT_LEAST_THIS_LENGTH_MAC(", 33);
             length_modifier = PSA_MAC_TRUNCATED_LENGTH(alg);
-        } else {
-            if (core_alg != alg) {
-                append(&buffer, buffer_size, &required_size,
-                       "PSA_ALG_TRUNCATED_MAC(", 22);
-                length_modifier = PSA_MAC_TRUNCATED_LENGTH(alg);
-            }
+        } else if (core_alg != alg) {
+            append(&buffer, buffer_size, &required_size,
+                   "PSA_ALG_TRUNCATED_MAC(", 22);
+            length_modifier = PSA_MAC_TRUNCATED_LENGTH(alg);
         }
     } else if (PSA_ALG_IS_AEAD(alg)) {
         core_alg = PSA_ALG_AEAD_WITH_DEFAULT_LENGTH_TAG(alg);
-        if (alg & PSA_ALG_AEAD_AT_LEAST_THIS_LENGTH_FLAG) {
-            if (core_alg == 0) {
-                /* For unknown AEAD algorithms, there is no "default tag length". */
-                core_alg = alg;
-            } else {
-                append(&buffer, buffer_size, &required_size,
-                       "PSA_ALG_AEAD_WITH_AT_LEAST_THIS_LENGTH_TAG(", 43);
-                length_modifier = PSA_AEAD_TAG_LENGTH(alg);
-            }
-        } else {
-            if (core_alg == 0) {
-                /* For unknown AEAD algorithms, there is no "default tag length". */
-                core_alg = alg;
-            } else if (core_alg != alg) {
-                append(&buffer, buffer_size, &required_size,
-                       "PSA_ALG_AEAD_WITH_SHORTENED_TAG(", 32);
-                length_modifier = PSA_AEAD_TAG_LENGTH(alg);
-            }
+        if (core_alg == 0) {
+            /* For unknown AEAD algorithms, there is no "default tag length". */
+            core_alg = alg;
+        } else if (alg & PSA_ALG_AEAD_AT_LEAST_THIS_LENGTH_FLAG) {
+            append(&buffer, buffer_size, &required_size,
+                   "PSA_ALG_AEAD_WITH_AT_LEAST_THIS_LENGTH_TAG(", 43);
+            length_modifier = PSA_AEAD_TAG_LENGTH(alg);
+        } else if (core_alg != alg) {
+            append(&buffer, buffer_size, &required_size,
+                   "PSA_ALG_AEAD_WITH_SHORTENED_TAG(", 32);
+            length_modifier = PSA_AEAD_TAG_LENGTH(alg);
         }
     } else if (PSA_ALG_IS_KEY_AGREEMENT(alg) &&
                !PSA_ALG_IS_RAW_KEY_AGREEMENT(alg)) {

scripts/generate_psa_constants.py

diff --git a/scripts/generate_psa_constants.py b/scripts/generate_psa_constants.py
index 644fbad..d0d1f3f 100755
--- a/scripts/generate_psa_constants.py
+++ b/scripts/generate_psa_constants.py
@@ -104,33 +104,24 @@
             append(&buffer, buffer_size, &required_size,
                    "PSA_ALG_AT_LEAST_THIS_LENGTH_MAC(", 33);
             length_modifier = PSA_MAC_TRUNCATED_LENGTH(alg);
-        } else {
-            if (core_alg != alg) {
-                append(&buffer, buffer_size, &required_size,
-                       "PSA_ALG_TRUNCATED_MAC(", 22);
-                length_modifier = PSA_MAC_TRUNCATED_LENGTH(alg);
-            }
+        } else if (core_alg != alg) {
+            append(&buffer, buffer_size, &required_size,
+                   "PSA_ALG_TRUNCATED_MAC(", 22);
+            length_modifier = PSA_MAC_TRUNCATED_LENGTH(alg);
         }
     } else if (PSA_ALG_IS_AEAD(alg)) {
         core_alg = PSA_ALG_AEAD_WITH_DEFAULT_LENGTH_TAG(alg);
-        if (alg & PSA_ALG_AEAD_AT_LEAST_THIS_LENGTH_FLAG) {
-            if (core_alg == 0) {
-                /* For unknown AEAD algorithms, there is no "default tag length". */
-                core_alg = alg;
-            } else {
-                append(&buffer, buffer_size, &required_size,
-                       "PSA_ALG_AEAD_WITH_AT_LEAST_THIS_LENGTH_TAG(", 43);
-                length_modifier = PSA_AEAD_TAG_LENGTH(alg);
-            }
-        } else {
-            if (core_alg == 0) {
-                /* For unknown AEAD algorithms, there is no "default tag length". */
-                core_alg = alg;
-            } else if (core_alg != alg) {
-                append(&buffer, buffer_size, &required_size,
-                       "PSA_ALG_AEAD_WITH_SHORTENED_TAG(", 32);
-                length_modifier = PSA_AEAD_TAG_LENGTH(alg);
-            }
+        if (core_alg == 0) {
+            /* For unknown AEAD algorithms, there is no "default tag length". */
+            core_alg = alg;
+        } else if (alg & PSA_ALG_AEAD_AT_LEAST_THIS_LENGTH_FLAG) {
+            append(&buffer, buffer_size, &required_size,
+                   "PSA_ALG_AEAD_WITH_AT_LEAST_THIS_LENGTH_TAG(", 43);
+            length_modifier = PSA_AEAD_TAG_LENGTH(alg);
+        } else if (core_alg != alg) {
+            append(&buffer, buffer_size, &required_size,
+                   "PSA_ALG_AEAD_WITH_SHORTENED_TAG(", 32);
+            length_modifier = PSA_AEAD_TAG_LENGTH(alg);
         }
     } else if (PSA_ALG_IS_KEY_AGREEMENT(alg) &&
                !PSA_ALG_IS_RAW_KEY_AGREEMENT(alg)) {