commit 9e4f77c6068a633b18f439d8e06670826c54a1d5
author Gilles Peskine <Gilles.Peskine@arm.com> Mon Jan 22 11:48:08 2018 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Mon Jan 22 11:54:42 2018 +0100
tree 542a2fd783fcbc0bd1e9e8e0e190043215e37a03
parent 15932e0cbfd25ba044f0d38b24801829de7c1884

New MD API: rename functions from _ext to _ret

The _ext suffix suggests "new arguments", but the new functions have
the same arguments. Use _ret instead, to convey that the difference is
that the new functions return a value.

library/md4.c

diff --git a/library/md4.c b/library/md4.c
index f5972eb..34a4b0e 100644
--- a/library/md4.c
+++ b/library/md4.c
@@ -98,7 +98,7 @@
 /*
  * MD4 context setup
  */
-int mbedtls_md4_starts_ext( mbedtls_md4_context *ctx )
+int mbedtls_md4_starts_ret( mbedtls_md4_context *ctx )
 {
     ctx->total[0] = 0;
     ctx->total[1] = 0;
@@ -222,7 +222,7 @@
 /*
  * MD4 process buffer
  */
-int mbedtls_md4_update_ext( mbedtls_md4_context *ctx,
+int mbedtls_md4_update_ret( mbedtls_md4_context *ctx,
                             const unsigned char *input,
                             size_t ilen )
 {
@@ -284,7 +284,7 @@
 /*
  * MD4 final digest
  */
-int mbedtls_md4_finish_ext( mbedtls_md4_context *ctx,
+int mbedtls_md4_finish_ret( mbedtls_md4_context *ctx,
                             unsigned char output[16] )
 {
     int ret;
@@ -302,11 +302,11 @@
     last = ctx->total[0] & 0x3F;
     padn = ( last < 56 ) ? ( 56 - last ) : ( 120 - last );
 
-    ret = mbedtls_md4_update_ext( ctx, (unsigned char *)md4_padding, padn );
+    ret = mbedtls_md4_update_ret( ctx, (unsigned char *)md4_padding, padn );
     if( ret != 0 )
         return( ret );
 
-    if( ( ret = mbedtls_md4_update_ext( ctx, msglen, 8 ) ) != 0 )
+    if( ( ret = mbedtls_md4_update_ret( ctx, msglen, 8 ) ) != 0 )
         return( ret );
 
 
@@ -323,7 +323,7 @@
 /*
  * output = MD4( input buffer )
  */
-int mbedtls_md4_ext( const unsigned char *input,
+int mbedtls_md4_ret( const unsigned char *input,
                      size_t ilen,
                      unsigned char output[16] )
 {
@@ -332,13 +332,13 @@
 
     mbedtls_md4_init( &ctx );
 
-    if( ( ret = mbedtls_md4_starts_ext( &ctx ) ) != 0 )
+    if( ( ret = mbedtls_md4_starts_ret( &ctx ) ) != 0 )
         goto exit;
 
-    if( ( ret = mbedtls_md4_update_ext( &ctx, input, ilen ) ) != 0 )
+    if( ( ret = mbedtls_md4_update_ret( &ctx, input, ilen ) ) != 0 )
         goto exit;
 
-    if( ( ret = mbedtls_md4_finish_ext( &ctx, output ) ) != 0 )
+    if( ( ret = mbedtls_md4_finish_ret( &ctx, output ) ) != 0 )
         goto exit;
 
 exit:
@@ -400,7 +400,7 @@
         if( verbose != 0 )
             mbedtls_printf( "  MD4 test #%d: ", i + 1 );
 
-        ret = mbedtls_md4_ext( md4_test_str[i], md4_test_strlen[i], md4sum );
+        ret = mbedtls_md4_ret( md4_test_str[i], md4_test_strlen[i], md4sum );
         if( ret != 0 )
             goto fail;