commit a8fa8b8f964fec5468a9a4a224fda3b04f726ddd
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu May 10 10:12:36 2018 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu May 24 13:37:31 2018 +0200
tree 0b4f518a030dd7b83f856d86d5d0711726a8bfd1
parent 2aca2368817ce558d20624ad06b33d2e2d44ae2d

poly1305: add test for parameter validation

Also fix two validation bugs found while adding the tests.

Also handle test dependencies the right way while at it.

library/poly1305.c

diff --git a/library/poly1305.c b/library/poly1305.c
index 542a850..0aa4533 100644
--- a/library/poly1305.c
+++ b/library/poly1305.c
@@ -259,7 +259,7 @@
 int mbedtls_poly1305_starts( mbedtls_poly1305_context *ctx,
                              const unsigned char key[32] )
 {
-    if ( ctx == NULL )
+    if ( ctx == NULL || key == NULL )
     {
         return( MBEDTLS_ERR_POLY1305_BAD_INPUT_DATA );
     }
@@ -417,7 +417,7 @@
 
 cleanup:
     mbedtls_poly1305_free( &ctx );
-    return( 0 );
+    return( result );
 }
 
 #endif /* MBEDTLS_POLY1305_ALT */