commit aa5e132df7df6e10c1ec13121de31de9e155a8a7
author Paul Elliott <paul.elliott@arm.com> Fri Mar 05 15:52:25 2021 +0000
committer Paul Elliott <paul.elliott@arm.com> Wed Mar 10 17:00:32 2021 +0000
tree 9f973f9573ffe0bc0d816e6fa2dcaebad4eb795f
parent 61d2209e42625acceed1f3a6598f585ac65d3f77

Improve include guards for format attribute

Signed-off-by: Paul Elliott <paul.elliott@arm.com>

include/mbedtls/debug.h

diff --git a/include/mbedtls/debug.h b/include/mbedtls/debug.h
index acc85de..dd20ba0 100644
--- a/include/mbedtls/debug.h
+++ b/include/mbedtls/debug.h
@@ -84,18 +84,22 @@
  * \def MBEDTLS_PRINTF_ATTRIBUTE
  *
  * Mark a function as having printf attributes, and thus enable checking
- * via -wFormat and other flags. This does nothing in windows builds as the
- * windows compiler does not support it.
+ * via -wFormat and other flags. This does nothing on builds with compilers
+ * that do not support the format attribute
  *
  * Module:  library/debug.c
  * Caller:
  *
  * This module provides debugging functions.
  */
-#if defined(__GNUC__)
+#if defined(__has_attribute)
+#if __has_attribute(format)
 #define MBEDTLS_PRINTF_ATTRIBUTE(string_index, first_to_check)    \
     __attribute__((format (printf, string_index, first_to_check)))
-#else
+#else /* __has_attribute(format) */
+#define MBEDTLS_PRINTF_ATTRIBUTE(string_index, first_to_check)
+#endif /* __has_attribute(format) */
+#else /* defined(__has_attribute) */
 #define MBEDTLS_PRINTF_ATTRIBUTE(string_index, first_to_check)
 #endif
 
@@ -115,10 +119,10 @@
    #include <inttypes.h>
    #define MBEDTLS_PRINTF_SIZET     PRIuPTR
    #define MBEDTLS_PRINTF_LONGLONG  "I64d"
-#else
+#else /* defined(__MINGW32__) || (defined(_MSC_VER) && _MSC_VER < 1800) */
    #define MBEDTLS_PRINTF_SIZET     "zu"
    #define MBEDTLS_PRINTF_LONGLONG  "lld"
-#endif
+#endif /* defined(__MINGW32__) || (defined(_MSC_VER) && _MSC_VER < 1800) */
 
 #ifdef __cplusplus
 extern "C" {