commit bb4bbbbbb481991b72575e2180ea86489e52d834
author Ron Eldor <Ron.Eldor@arm.com> Sun Oct 01 17:04:54 2017 +0300
committer Simon Butcher <simon.butcher@arm.com> Mon Jul 23 18:18:35 2018 +0100
tree d6f5e6e3e299c54316ebb2d66297aae1afa6614d
parent 6f90ed82b9213b7857e18dcb3a28f3db2351f1ee

Resolve PR review comments

Address review comments:
1. add `mbedtls_cipher_init()` after freeing context, in test code
2. style comments
3. set `ctx->iv_size = 0` in case `IV == NULL && iv_len == 0`

library/cipher.c

diff --git a/library/cipher.c b/library/cipher.c
index da55206..d7acf34 100644
--- a/library/cipher.c
+++ b/library/cipher.c
@@ -242,6 +242,9 @@
     else if( NULL == iv && iv_len != 0  )
         return( MBEDTLS_ERR_CIPHER_BAD_INPUT_DATA );
 
+    if( NULL == iv && iv_len == 0 )
+        ctx->iv_size = 0;
+
     /* avoid buffer overflow in ctx->iv */
     if( iv_len > MBEDTLS_MAX_IV_LENGTH )
         return( MBEDTLS_ERR_CIPHER_FEATURE_UNAVAILABLE );
@@ -269,7 +272,7 @@
     }
 #endif
 
-    if ( actual_iv_size )
+    if ( actual_iv_size != 0 )
     {
         memcpy( ctx->iv, iv, actual_iv_size );
         ctx->iv_size = actual_iv_size;