commit eba6c9bb505fe98121772510087f6a3159d19d6c
author thomas-dee <thomas.dee@gmx.net> Wed Sep 19 09:10:37 2018 +0200
committer thomas-dee <thomas.dee@gmx.net> Wed Sep 19 09:10:37 2018 +0200
tree 076fdc43f017780396a8358e23c035d9d505be03
parent 020c823f62204588584ee00dd63c0b61cf9051ab

changes requested by @hanno-arm
 - renamed `mbedtls_asn1_write_any_string` to `mbedtls_asn1_write_tagged_string`
 - renamed `x509_at_oid_from_name` to `x509_attr_descr_from_name`

library/x509_create.c

diff --git a/library/x509_create.c b/library/x509_create.c
index ab5f85b..2f36f24 100644
--- a/library/x509_create.c
+++ b/library/x509_create.c
@@ -42,7 +42,7 @@
 
 #define ADD_STRLEN( s )     s, sizeof( s ) - 1
 
-// note: preset tag types as proposed in rfc3280 and widely used
+// note: preset tag types as proposed in RFC3280 and widely used
 static const x509_attr_descriptor_t x509_attrs[] =
 {
     { ADD_STRLEN( "CN" ),                       MBEDTLS_OID_AT_CN,              MBEDTLS_ASN1_UTF8_STRING },
@@ -76,7 +76,7 @@
     { NULL, 0, NULL, MBEDTLS_ASN1_NULL }
 };
 
-static const x509_attr_descriptor_t *x509_at_oid_from_name( const char *name, size_t name_len )
+static const x509_attr_descriptor_t *x509_attr_descr_from_name( const char *name, size_t name_len )
 {
     const x509_attr_descriptor_t *cur;
 
@@ -97,7 +97,7 @@
     const char *s = name, *c = s;
     const char *end = s + strlen( s );
     const char *oid = NULL;
-    const x509_attr_descriptor_t* oid_attr = NULL;
+    const x509_attr_descriptor_t* attr_descr = NULL;
     int in_tag = 1;
     char data[MBEDTLS_X509_MAX_DN_NAME_SIZE];
     char *d = data;
@@ -109,13 +109,13 @@
     {
         if( in_tag && *c == '=' )
         {
-            if( ( oid_attr = x509_at_oid_from_name( s, c - s ) ) == NULL )
+            if( ( attr_descr = x509_attr_descr_from_name( s, c - s ) ) == NULL )
             {
                 ret = MBEDTLS_ERR_X509_UNKNOWN_OID;
                 goto exit;
             }
 
-            oid = oid_attr->oid;
+            oid = attr_descr->oid;
             s = c + 1;
             in_tag = 0;
             d = data;
@@ -144,7 +144,7 @@
             }
 
             // set tagType
-            cur->val.tag = oid_attr->tag;
+            cur->val.tag = attr_descr->tag;
 
             while( c < end && *(c + 1) == ' ' )
                 c++;
@@ -214,7 +214,7 @@
     size_t name_len             = cur_name->val.len;
 
     // Write correct string tag and value
-    MBEDTLS_ASN1_CHK_ADD( len, mbedtls_asn1_write_any_string( p, start, cur_name->val.tag,
+    MBEDTLS_ASN1_CHK_ADD( len, mbedtls_asn1_write_tagged_string( p, start, cur_name->val.tag,
                                                                 (const char *) name,
                                                                 name_len ) );
     // Write OID