commit f86eb75c58f7a2fae462d6ddf0bf0354e45a69ca
author Jerry Yu <jerry.h.yu@arm.com> Fri May 06 11:16:55 2022 +0800
committer Jerry Yu <jerry.h.yu@arm.com> Fri May 06 11:16:55 2022 +0800
tree b360b3200b4b9a1e76cd9f03e7686ab85b819a95
parent e110d258d9f6fc175e05a79078ecbb779112052c

fix various issues

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>

library/ssl_tls13_client.c

diff --git a/library/ssl_tls13_client.c b/library/ssl_tls13_client.c
index 93b0632..59e42c8 100644
--- a/library/ssl_tls13_client.c
+++ b/library/ssl_tls13_client.c
@@ -1237,10 +1237,11 @@
         goto cleanup;
     }
 
-    ret = mbedtls_ssl_tls13_set_handshake_transform( ssl );
+    ret = mbedtls_ssl_tls13_compute_handshake_transform( ssl );
     if( ret != 0 )
     {
-        MBEDTLS_SSL_DEBUG_RET( 1, "mbedtls_ssl_tls13_set_handshake_transform",
+        MBEDTLS_SSL_DEBUG_RET( 1,
+                               "mbedtls_ssl_tls13_compute_handshake_transform",
                                ret );
         goto cleanup;
     }

library/ssl_tls13_keys.c

diff --git a/library/ssl_tls13_keys.c b/library/ssl_tls13_keys.c
index dd6677d..74b269e 100644
--- a/library/ssl_tls13_keys.c
+++ b/library/ssl_tls13_keys.c
@@ -1511,7 +1511,7 @@
     return( ret );
 }
 
-int mbedtls_ssl_tls13_set_handshake_transform( mbedtls_ssl_context *ssl )
+int mbedtls_ssl_tls13_compute_handshake_transform( mbedtls_ssl_context *ssl )
 {
     int ret;
     mbedtls_ssl_key_set traffic_keys;
@@ -1558,9 +1558,7 @@
 cleanup:
     mbedtls_platform_zeroize( &traffic_keys, sizeof( traffic_keys ) );
     if( ret != 0 )
-    {
         mbedtls_free( transform_handshake );
-    }
 
     return( ret );
 }

library/ssl_tls13_keys.h

diff --git a/library/ssl_tls13_keys.h b/library/ssl_tls13_keys.h
index 62bd6c0..676ebae 100644
--- a/library/ssl_tls13_keys.h
+++ b/library/ssl_tls13_keys.h
@@ -641,13 +641,13 @@
 /**
  * \brief Compute TLS 1.3 handshake transform
  *
- * \param ssl  The SSL context to operate on. The early secrtet must have been
+ * \param ssl  The SSL context to operate on. The early secret must have been
  *             computed.
  *
  * \returns    \c 0 on success.
  * \returns    A negative error code on failure.
  */
-int mbedtls_ssl_tls13_set_handshake_transform( mbedtls_ssl_context *ssl );
+int mbedtls_ssl_tls13_compute_handshake_transform( mbedtls_ssl_context *ssl );
 
 #endif /* MBEDTLS_SSL_PROTO_TLS1_3 */
 

library/ssl_tls13_server.c

diff --git a/library/ssl_tls13_server.c b/library/ssl_tls13_server.c
index d6c1f5e..b2a5cfc 100644
--- a/library/ssl_tls13_server.c
+++ b/library/ssl_tls13_server.c
@@ -1029,10 +1029,11 @@
 static int ssl_tls13_finalize_write_server_hello( mbedtls_ssl_context *ssl )
 {
     int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
-    ret = mbedtls_ssl_tls13_set_handshake_transform( ssl );
+    ret = mbedtls_ssl_tls13_compute_handshake_transform( ssl );
     if( ret != 0 )
     {
-        MBEDTLS_SSL_DEBUG_RET( 1, "mbedtls_ssl_tls13_set_handshake_transform",
+        MBEDTLS_SSL_DEBUG_RET( 1,
+                               "mbedtls_ssl_tls13_compute_handshake_transform",
                                ret );
         return( ret );
     }
@@ -1040,7 +1041,7 @@
     mbedtls_ssl_set_outbound_transform( ssl,
                                         ssl->handshake->transform_handshake );
     MBEDTLS_SSL_DEBUG_MSG(
-        3, ( "switching to new transform spec for outbound data" ) );
+        3, ( "switching to handshake transform for outbound data" ) );
 
     return( ret );
 }