commit fa950c94804fb5c93989b5ca62a60b3b6eb6e414
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Apr 30 12:50:22 2015 +0200
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Thu Apr 30 12:50:22 2015 +0200
tree 0923e639acd73d517c5c2edee8c8446d713eca62
parent f52248a959ca26c7e894012f420af3a2856cf205

fix bug in ssl_mail_client

ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 7e7374b..e904eb8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -33,6 +33,8 @@
      errors on use of deprecated functions.
 
 Bugfix
+   * Fix bug in ssl_mail_client when password is longer that username (found
+     by Bruno Pape).
    * Fix undefined behaviour (memcmp( NULL, NULL, 0 );) in X.509 modules
      (detected by Clang's 3.6 UBSan).
    * mpi_size() and mpi_msb() would segfault when called on an mpi that is

programs/ssl/ssl_mail_client.c

diff --git a/programs/ssl/ssl_mail_client.c b/programs/ssl/ssl_mail_client.c
index fcda1dd..27c57a1 100644
--- a/programs/ssl/ssl_mail_client.c
+++ b/programs/ssl/ssl_mail_client.c
@@ -722,7 +722,7 @@
         polarssl_printf( "  > Write username to server: %s", opt.user_name );
         fflush( stdout );
 
-        n = sizeof( buf );
+        n = sizeof( base );
         ret = base64_encode( base, &n, (const unsigned char *) opt.user_name,
                              strlen( opt.user_name ) );
 
@@ -743,6 +743,7 @@
         polarssl_printf( "  > Write password to server: %s", opt.user_pwd );
         fflush( stdout );
 
+        n = sizeof( base );
         ret = base64_encode( base, &n, (const unsigned char *) opt.user_pwd,
                              strlen( opt.user_pwd ) );