tree 0d6f704fb0bf34d7e55206dc4e9ebb347ab0864e
parent 91c20f5f425b18b641765217586a82a62e1aa45a
author bbain <16752579+bbain@users.noreply.github.com> 1676264300 +1100
committer GitHub <noreply@github.com> 1676264300 +0530
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJj6cNsCRBK7hj4Ov3rIwAAJ+sIAItQxXu+1z5k4jUcAEhAfB5T
 c58sYGJJW9JI7fj3SH6+rGe1MRDYJo0NA0xhdDylqbZtvd6YitfOqLY30HPHqy0M
 GMDl9B9SdyGe7lth5spM0w3qwlUkVzM/0vxbYw/fMEZADGHNcjFQkfEsfpyPPcjX
 sbYJiMxQswGCVw6JVF+3KyKRry2j3JY5N1CJQMirNa8m1HDPThzWrdHwRrNzxGE+
 m5dC757Di9l0RCJguMuYETUVS3JmlTE5TLCIyLJ4M5gmCTeWeoK9PfnLzrz+/iwN
 6xF9dxlA8F7M2HcRzt3932pmWSX3dFir3EqviCV3l/E8oKVuXdL88FR1zsDAPqI=
 =6tyi
 -----END PGP SIGNATURE-----
 

Introduce portMEMORY_BARRIER for Microblaze port. (#621)

The introduction of `portMEMORY_BARRIER` will ensure
the places in the kernel use a barrier will work.
For example, `xTaskResumeAll` has a memory barrier
to ensure its correctness when compiled with optimization
enabled. Without the barrier `xTaskResumeAll` can fail
(e.g. start reading and writing to address 0 and/or
infinite looping) when `xPendingReadyList` contains more
than one task to restore.

In `xTaskResumeAll` the compiler chooses to cache the
`pxTCB` the first time through the loop for use
in every subsequent loop. This is incorrect as the
removal of `pxTCB->xEventListItem` will actually
change the value of `pxTCB` if it was read again
at the top of the loop. The barrier forces the compiler
to read `pxTCB` again at the top of the loop.

The compiler is operating correctly. The removal
`pxTCB->xEventListItem` executes on a `List_t *`
and `ListItem_t *`.  This means that the compiler
can assume that any `MiniListItem_t` values are
unchanged by the loop (i.e. "strict-aliasing").
This allows the compiler to cache `pxTCB` as it
is obtained via a `MiniListItem_t`. This is incorrect
in this case because it is possible for a `ListItem_t *`
to actually alias a `MiniListItem_t`. This is technically
a "violation of aliasing rules" so we use the the barrier
to disable the strict-aliasing optimization in this loop.