)]}'
{
  "commit": "05ded5bd8d01ebf1fd8ab9e7db40d582e2bfb628",
  "tree": "dc10c2c1de2c9266408b84672d31c0f886d64bc8",
  "parents": [
    "a22b438e602d810098a320fc167fc1c79db7e9d2"
  ],
  "author": {
    "name": "Jeff Tenney",
    "email": "jeff.tenney@gmail.com",
    "time": "Tue Apr 13 11:05:46 2021 -0700"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Tue Apr 13 11:05:46 2021 -0700"
  },
  "message": "Remove support for tmrCOMMAND_START_DONT_TRACE (#305)\n\n* Remove support for tmrCOMMAND_START_DONT_TRACE\r\n\r\nPrior to this commit, the timer task used tmrCOMMAND_START_DONT_TRACE\r\nto reload a \"backlogged\" auto-reload timer -- one for which a reload\r\noperation would have started a period that had already elapsed.  If the\r\ncommand queue contained a stop or delete command when\r\ntmrCOMMAND_START_DONT_TRACE was put into the queue for a reload, the\r\ntimer unexpectedly restarted when the timer task processed\r\ntmrCOMMAND_START_DONT_TRACE.  This commit implements a new method of\r\nreloading auto-reload timers and eliminates support for\r\ntmrCOMMAND_START_DONT_TRACE.  No other code sends this private command.\r\n\r\nHowever, the symbol tmrCOMMAND_START_DONT_TRACE remains defined, with\r\nits original command value, so as not to impact trace applications.\r\n\r\nAlso fix one-shot timers that were not reliably being marked as not\r\nactive:\r\n- when they expired before the start command could be processed\r\n- when the expiration was processed during the timer list switch\r\n\r\nAlso improve consistency:\r\n- Always reload auto-reload timers *before* calling the callback.\r\n- Always call traceTIMER_EXPIRED() just prior to the callback.\r\n\r\n* fix indent\r\n\r\n* Revert unnecessary change to prvTimerTask()\r\n\r\nChange was intended to faithfully work through a backlog that spanned a\r\nlist switch, and before processing a stop or delete command.  But, (1)\r\nit isn\u0027t important to do that, and (2) the code didn\u0027t accomplish the\r\nintention when *two* auto-reload timers were backlogged across a list\r\nswitch.  Best to simply leave this part of the code as it was before.\r\n\r\n* fix style\r\n\r\nCo-authored-by: Joseph Julicher \u003cjjulicher@mac.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "203a07778fabaef2c24acc1e07a56222b09381a4",
      "old_mode": 33188,
      "old_path": "timers.c",
      "new_id": "8032a1fe8deea81ef2dcd03e77c82f020e771589",
      "new_mode": 33188,
      "new_path": "timers.c"
    }
  ]
}