tree dc10c2c1de2c9266408b84672d31c0f886d64bc8
parent a22b438e602d810098a320fc167fc1c79db7e9d2
author Jeff Tenney <jeff.tenney@gmail.com> 1618337146 -0700
committer GitHub <noreply@github.com> 1618337146 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJgdd16CRBK7hj4Ov3rIwAAdHIIAGQQMAK0nca5Z7UiWDpj6YmW
 TFgJtrcg//nQB0iSZ1+EtRnAITGLFfSKzAMH//h2Wf7WP+q9/FsF+3ULi+pryc2O
 8vxxbWy21nhfYHUyedZJ8HQT3DRWo420RR/l8ROuSGp9PWKYfEDRIVaCkjvQhm+Y
 ypIrDCaVLencoC9QCaBVJzM3+FWRr2BoLljHK4P51RyT1gYmXY1XqA4/aQyAClF4
 B9aBRbQ5KIOXO+mlPXmjlK72VyPv+DzLa5dIJLA7NSE0PK+mQ+gc1HrFoU4I4BkZ
 koiqgeUzlpvIUWojVzEV/nkeCxIz0ccnlLc5tahkUC8L5JP00eLx8/IRVpzRliU=
 =lIVJ
 -----END PGP SIGNATURE-----
 

Remove support for tmrCOMMAND_START_DONT_TRACE (#305)

* Remove support for tmrCOMMAND_START_DONT_TRACE

Prior to this commit, the timer task used tmrCOMMAND_START_DONT_TRACE
to reload a "backlogged" auto-reload timer -- one for which a reload
operation would have started a period that had already elapsed.  If the
command queue contained a stop or delete command when
tmrCOMMAND_START_DONT_TRACE was put into the queue for a reload, the
timer unexpectedly restarted when the timer task processed
tmrCOMMAND_START_DONT_TRACE.  This commit implements a new method of
reloading auto-reload timers and eliminates support for
tmrCOMMAND_START_DONT_TRACE.  No other code sends this private command.

However, the symbol tmrCOMMAND_START_DONT_TRACE remains defined, with
its original command value, so as not to impact trace applications.

Also fix one-shot timers that were not reliably being marked as not
active:
- when they expired before the start command could be processed
- when the expiration was processed during the timer list switch

Also improve consistency:
- Always reload auto-reload timers *before* calling the callback.
- Always call traceTIMER_EXPIRED() just prior to the callback.

* fix indent

* Revert unnecessary change to prvTimerTask()

Change was intended to faithfully work through a backlog that spanned a
list switch, and before processing a stop or delete command.  But, (1)
it isn't important to do that, and (2) the code didn't accomplish the
intention when *two* auto-reload timers were backlogged across a list
switch.  Best to simply leave this part of the code as it was before.

* fix style

Co-authored-by: Joseph Julicher <jjulicher@mac.com>