tree 60612a28e61eb07b24f3763cd7d9923e75b09f7b
parent 7b95420ad9e72253ddbf0cea45a0e17c9256b3ef
author Amit Tomar <amittomer25@gmail.com> 1640811190 +0530
committer GitHub <noreply@github.com> 1640811190 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJhzMq2CRBK7hj4Ov3rIwAAT3kIABTvpY8fCaY0UQE89p3Kq4DS
 WMCghxgRVjzXG1BCrsQc7P4UZw4PDIznWg4Y27HtiRXhO3G9ybmU0xcCsTnUB85N
 qBG5d43gXHlIs6kjwr4mYfQEbeW5eqF8xFqOe4iMFWvDGO/etFhnP/Vd6MLgxq9q
 q7YIriyBr8TTRNdDnMfmbn+A9i5CR/tRHNj134Z+5knL/UaEolPoU2bImicZuEtE
 FJwKMDUbkY2mlYkxuZk43Tja4HxvH7wPLnsudt+XhBPDyCbMfdxWwR5xljPm1YCC
 l17BsN8YCTNDO8zZeKVz6Bv60Gv8gFSI6kcMGibSRv5nSzBmsah1yDni337tAJ0=
 =gfol
 -----END PGP SIGNATURE-----
 

fix alignment exception for ullPortInterruptNesting. (#317)

* fix alignment exception for ullPortInterruptNesting.

While loading (LDR X5, ullPortInterruptNestingConst) the ullPortInterruptNesting
variable, the program control seems to be stuck and there is no abort or stack
trace observed (as there is no exception handler is installed to catch unaligned
access exception).

Program control moves forward, if one just declares this varible to be 2 bytes
aligned but then varible is not updated properly.

One of my colleague, pointed out that issue is due to the fact that
ullPortInterruptNesting must be at 8 bytes aligned address but since
"vApplicationIRQHandler" (that has 4 bytes of address) is sitting between
two 8 bytes aligned addresses that forces ullPortInterruptNesting to be at
4 byte aligned address, causing all sort of mess.

It works on QEMU (on ARM64) as it is, since there is no such check for
unaligned access but on real hardware it is prohibited.

Workaround to this problem is, either we skip 4 byets (using .align 4) after
vApplicationIRQHandler declaration or declare it the end of all declarations.
This commit does the latter one.

Signed-off-by: Amit Singh Tomar <atomar25opensource@gmail.com>

* Update portASM.S

Remove 1 tab = 4 spaces

Co-authored-by: Amit Singh Tomar <atomar25opensource@gmail.com>
Co-authored-by: alfred gedeon <28123637+alfred2g@users.noreply.github.com>
Co-authored-by: Joseph Julicher <jjulicher@mac.com>