Google Git
Sign in
pigweed / third_party / github / JetBrains / kotlin / refs/heads/upstream/rr/lunakoly/kt55411-scopes-optimizations
commit96433d9f53bcf0a9046d52b3fa25ffb143b0c59b[log] [tgz]
authorNikolay Lunyak <nikolay.lunyak@jetbrains.com>Tue Dec 13 11:18:00 2022 +0100
committerNikolay Lunyak <nikolay.lunyak@jetbrains.com>Tue Dec 13 16:36:20 2022 +0100
tree06446da320138e1481eea88f5c929bb120a4f0bc
parentbf178e6a2b40491efcdadfe5bbe744ce72d8a32c [diff]
[FIR] KT-55411: Remove the VariableAccess check

This check was needed for java fields like in this
test: staticsFromJavaNew.kt.

The actual situation is the following:
There is a `givenExtensionReceiverOptions.isEmpty()` check in
`MemberScopeTowerLevel.processMembers` that prevents
searching for synthetics if `extensionReceiver != null`. This means,
when we can't remember if a receiver resulted in empty scopes
(implicitReceiverValuesWithEmptyScopes)
because we may first check it with
`extensionReceiver = implicitReceiver`, thus not getting anything.
So, `processLevel()` for member
scope from receivers with `extensionReceiver = null` yields all
the same results as `extensionReceiver = receiver`
plus some more.

The new change allows to not check the same scopes in case of
VariableAccess, because when we check the first time,
we already check with the synthetics in mind.

The solution below relies on the fact that synthetic properties
are not checked for `hasConsistentExtensionReceiver`
(this check happens inside `scope.collectCandidates`) call, but
not for synthetics.

One could argue that the hypothetical proper solution could be:

- also check `hasConsistentExtensionReceiver` for synthetics
- if it's false, `return ProcessResult.FOUND`
  - this would prevent caching, and wait until we check
    the member scope without a receiver

But since java fields can't have extension receivers we may never get
a receiver mismatch when accessing it via any dispatch receiver.
Type mismatch doesn't happen with expression receivers either, because
in these cases they may only be found when we look in the
member scope of the explicit receiver
(see: `runResolverForExpressionReceiver`). When enumerating the tower
levels after it, we don't search for synthetics, because
we get `typeForSyntheticScope = null` in such cases (because the flag
`givenExtensionReceiverCameFromImplicitReceiver`
is not being set)
2 files changed
tree: 06446da320138e1481eea88f5c929bb120a4f0bc
  1. .idea/
  2. .space/
  3. analysis/
  4. annotations/
  5. ant/
  6. benchmarks/
  7. build-common/
  8. buildSrc/
  9. compiler/
  10. core/
  11. dependencies/
  12. docs/
  13. generators/
  14. gradle/
  15. idea/
  16. jps/
  17. js/
  18. kotlin-js-store/
  19. kotlin-native/
  20. libraries/
  21. license/
  22. native/
  23. plugins/
  24. prepare/
  25. repo/
  26. resources/
  27. scripts/
  28. spec-docs/
  29. test-instrumenter/
  30. tests/
  31. third-party/
  32. wasm/
  33. .bunch
  34. .gitattributes
  35. .gitignore
  36. .space.kts
  37. build.gradle.kts
  38. ChangeLog.md
  39. CODE_OF_CONDUCT.md
  40. dev-env-warmup.sh
  41. gradle.properties
  42. gradlew
  43. gradlew.bat
  44. ReadMe.md
  45. SECURITY.md
  46. settings.gradle
ReadMe.md

official project TeamCity (simple build status) Maven Central GitHub license Revved up by Gradle Enterprise

Kotlin Programming Language

Welcome to Kotlin!
It is an open-source, statically typed programming language supported and developed by JetBrains and open-source contributors.

Some handy links:

Kotlin Multiplatform capabilities

Support for multiplatform programming is one of Kotlin’s key benefits. It reduces time spent writing and maintaining the same code for different platforms while retaining the flexibility and benefits of native programming.

Editing Kotlin

Build environment requirements

This repository is using Gradle toolchains feature to select and auto-provision required JDKs from AdoptOpenJdk project.

Unfortunately AdoptOpenJdk project does not provide required JDK 1.6 and 1.7 images, so you could either download them manually and provide path to installation via JDK_1_6 and JDK_1_7 environment variables or use following SDK managers:

Alternatively, it is still possible to only provide required JDKs via environment variables (see gradle.properties for supported variable names). To ensure Gradle uses only JDKs from environmental variables - disable Gradle toolchain auto-detection by passing -Porg.gradle.java.installations.auto-detect=false option (or put it into $GRADLE_USER_HOME/gradle.properties).

For local development, if you‘re not working on the standard library, it’s OK to avoid installing JDK 1.6 and JDK 1.7. Add kotlin.build.isObsoleteJdkOverrideEnabled=true to the local.properties file, so build will only use JDK 1.8+. Note, that in this case, build will have Gradle remote build cache misses for some tasks.

Note: The JDK 6 for MacOS is not available on Oracle's site. You can install it by

$ brew tap homebrew/cask-versions
$ brew install --cask java6

On Windows you might need to add long paths setting to the repo:

git config core.longpaths true

Building

The project is built with Gradle. Run Gradle to build the project and to run the tests using the following command on Unix/macOS:

./gradlew <tasks-and-options>

or the following command on Windows:

gradlew <tasks-and-options>

On the first project configuration gradle will download and setup the dependencies on

  • intellij-core is a part of command line compiler and contains only necessary APIs.
  • idea-full is a full blown IntelliJ IDEA Community Edition to be used in the plugin module.

These dependencies are quite large, so depending on the quality of your internet connection you might face timeouts getting them. In this case, you can increase timeout by specifying the following command line parameters on the first run:

./gradlew -Dhttp.socketTimeout=60000 -Dhttp.connectionTimeout=60000

Important gradle tasks

  • clean - clean build results
  • dist - assembles the compiler distribution into dist/kotlinc/ folder
  • install - build and install all public artifacts into local maven repository
  • coreLibsTest - build and run stdlib, reflect and kotlin-test tests
  • gradlePluginTest - build and run gradle plugin tests
  • compilerTest - build and run all compiler tests

To reproduce TeamCity build use -Pteamcity=true flag. Local builds don't run proguard and have jar compression disabled by default.

OPTIONAL: Some artifacts, mainly Maven plugin ones, are built separately with Maven. Refer to libraries/ReadMe.md for details.

To build Kotlin/Native, see kotlin-native/README.md.

Working with the project in IntelliJ IDEA

Working with the Kotlin project requires at least IntelliJ IDEA 2019.1. You can download IntelliJ IDEA 2019.1 here.

After cloning the project, to import the project in IntelliJ choose the project directory in the Open project dialog. Then, after project opened, select File -> New -> Module from Existing Sources... in the menu, and select build.gradle.kts file in the project's root folder.

In the import dialog, select use default gradle wrapper.

To be able to run tests from IntelliJ easily, check Delegate IDE build/run actions to Gradle and choose Gradle Test Runner in the Gradle runner settings after importing the project.

At this time, you can use the latest released 1.6.x version of the Kotlin plugin for working with the code. To make sure you have the latest version installed, use Tools -> Kotlin -> Configure Kotlin Plugin Updates.

For handy work with compiler tests it's recommended to use Kotlin Compiler Test Helper

Dependency verification

We have a dependencies verification feature enabled in the repository for all Gradle builds. Gradle will check hashes (md5 and sha256) of used dependencies and will fail builds with Dependency verification failed errors when local artifacts are absent or have different hashes listed in the verification-metadata.xml file.

It's expected that verification-metadata.xml should only be updated with the commits that modify the build. There are some tips how to perform such updates:

  • Use auto-generation for getting an initial list of new hashes (verify updates relate to you changes).

./gradlew -i --write-verification-metadata sha256,md5 -Pkotlin.native.enabled=true help

(any other task may be used instead of help)

  • Consider removing old versions from the file if you are updating dependencies.
  • Leave meaningful origin attribute (instead of Generated by Gradle) if you did some manual verification of the artifact.
  • Always do manual verification if several hashes are needed, and a new also-trust tag has to be added.
  • If you’re adding a dependency with OS mentioning in an artifact name (darwin, mac, osx, linux, windows), remember to add counterparts for other platforms.

Using -dev and -SNAPSHOT versions

We publish -dev and -SNAPSHOT versions frequently.

For -dev versions you can use the list of available versions and include this maven repository:

maven { url = uri("https://maven.pkg.jetbrains.space/kotlin/p/kotlin/bootstrap") }

For -SNAPSHOT versions that are updated daily, you can use the list of available versions and include this maven repository:

maven { url = uri("https://oss.sonatype.org/content/repositories/snapshots/") }

License

Kotlin is distributed under the terms of the Apache License (Version 2.0). See license folder for details.

Contributing

Please be sure to review Kotlin's contributing guidelines to learn how to help the project.