commit 53e6dae02bf0d9a5a1d304a3d637c083376b86a1
author Evan Brown <ezb@google.com> Wed Mar 06 13:40:51 2024 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Mar 06 13:41:59 2024 -0800
tree 00dd63ad547a0640a78c7b27e7032f79c9f0ba80
parent 6f0bb2747d0a910de4a958eeeab2b9d615156382

Fix flaky MSVC test failures by using longer slop time.

PiperOrigin-RevId: 613326708
Change-Id: I6e5ca195f208b8da0d21d70b5a035bfdc64f866d

absl/synchronization/internal/per_thread_sem_test.cc

diff --git a/absl/synchronization/internal/per_thread_sem_test.cc b/absl/synchronization/internal/per_thread_sem_test.cc
index 24a6b54..c66bca8 100644
--- a/absl/synchronization/internal/per_thread_sem_test.cc
+++ b/absl/synchronization/internal/per_thread_sem_test.cc
@@ -159,7 +159,11 @@
   const absl::Duration elapsed = absl::Now() - start;
   // Allow for a slight early return, to account for quality of implementation
   // issues on various platforms.
-  const absl::Duration slop = absl::Milliseconds(1);
+  absl::Duration slop = absl::Milliseconds(1);
+#ifdef _MSC_VER
+  // Use higher slop on MSVC due to flaky test failures.
+  slop = absl::Milliseconds(4);
+#endif
   EXPECT_LE(delay - slop, elapsed)
       << "Wait returned " << delay - elapsed
       << " early (with " << slop << " slop), start time was " << start;