commit b9a26fe1bc80769532120cdbcc95f6b17ae656b5
author Abseil Team <absl-team@google.com> Thu Dec 11 10:18:21 2025 -0800
committer Copybara-Service <copybara-worker@google.com> Thu Dec 11 10:19:38 2025 -0800
tree fa8d095065aef81515dcc00234300bfb6f1f99fe
parent ba9fa8c3ab46316f5db80aaf8e6e9cf5df711df6

Add ABSL_ATTRIBUTE_LIFETIME_BOUND to Flag help generator

Since this method is only called by `NonConst` which immediately converts it to a `std::string`, this is currently safe. Add annotation nevertheless to show the contract.

This currently makes the majority of lifetime annotation suggestion provided by the lifetime analysis https://godbolt.org/z/hKvrE1hG1

PiperOrigin-RevId: 843275432
Change-Id: Ib1a0513eca944a9c7c4c612c3111bf05881c746d

absl/flags/flag.h

diff --git a/absl/flags/flag.h b/absl/flags/flag.h
index e052d5f..4c328e3 100644
--- a/absl/flags/flag.h
+++ b/absl/flags/flag.h
@@ -241,7 +241,8 @@
     /* default value argument. That keeps temporaries alive */               \
     /* long enough for NonConst to work correctly.          */               \
     static constexpr absl::string_view Value(                                \
-        absl::string_view absl_flag_help = ABSL_FLAG_IMPL_FLAGHELP(txt)) {   \
+        absl::string_view absl_flag_help ABSL_ATTRIBUTE_LIFETIME_BOUND  =     \
+            ABSL_FLAG_IMPL_FLAGHELP(txt)) {                                  \
       return absl_flag_help;                                                 \
     }                                                                        \
     static std::string NonConst() { return std::string(Value()); }           \