)]}' { "commit": "e20fe888fabc1fc995dc61180e8a31b5f809a95f", "tree": "5877907889fe35eb3162aa71111e16bd1d59fde4", "parents": [ "46dfbfe31ca1dd414e4c33cbcbcd7199bb4efde3" ], "author": { "name": "Abseil Team", "email": "absl-team@google.com", "time": "Thu Apr 15 19:42:51 2021 -0700" }, "committer": { "name": "Dino Radaković", "email": "dinor@google.com", "time": "Thu Apr 15 19:45:30 2021 -0700" }, "message": "Export of internal Abseil changes\n\n--\n341670bce317dd6af8d3c066970230591a47e80c by Martijn Vels \u003cmvels@google.com\u003e:\n\nChange GetStack() and GetParentStack() to return absl::Span\n\nPiperOrigin-RevId: 368765721\n\n--\n6aaab9536d6957303c7aba100c3afaa6fb0ea2c8 by Martijn Vels \u003cmvels@google.com\u003e:\n\nRemove locking from parent stack.\n\nThis change removes the need to lock all access to `parent_stack\u0027 by making the \u0027copy constructor\u0027 logic specify the \u0027copied from\u0027 CordzInfo (where available) to the TrackCord function, after which parent_stack is immutable.\n\nPiperOrigin-RevId: 368760630\n\n--\nb19e2059cada35a8ede994833018edac94de6ddc by Martijn Vels \u003cmvels@google.com\u003e:\n\nAdd cordz instrumentation to Cord\n\nPiperOrigin-RevId: 368746225\n\n--\n67b8bbf980f0f4e1db79aa32968e9a715a09b51a by Martijn Vels \u003cmvels@google.com\u003e:\n\nCreate ABSL_INTERNAL_CORDZ_ENABLED define controlling when Cordz code is enabled\n\nThere are specific builds and condtions under which we don\u0027t support cordz sampling, which is per this change represented by ABSL_INTERNAL_CORDZ_ENABLED being defined.\n\nPiperOrigin-RevId: 368731603\n\n--\n8cbfe0e3169637a620f4b66ad2bc2ce340879cb0 by Martijn Vels \u003cmvels@google.com\u003e:\n\nAdd a `rep` property to CordzInfo to be managed by Cord logic.\n\nThis change adds a `rep` property to CordzInfo, which is intended to be used by collection logic.\n\nMini design:\nCord invokes TrackCord() providing the active \u0027root\u0027 cordrep of the newly sampled Cord, returning a CordzInfo with a weak (uncounted) reference to this root. Cord invokes `SetCordRep()` each time the root cordrep of the sampled Cord is updated while holding `mutex()`. Cord must also obtain `mutex()` _before_ removing a reference on the old root. i.e.: Cord must guarantee that the (weak) reference held in CordzInfo is at all times valid.\n\nCordzInfo collection code can then safely obtain a (reference counted) rep pointer by adding a reference to `rep_` while holding `mutex()`. This requires only a very brief critical section inside CordzInfo logic, minimizing contention with concurrent Cord updates.\n\nCord code should typically obtain and hold `mutex()` for the entirety of each mutating Cord operation on a sampled cord. As Cord is thread compatible, it never competes on the lock with any other thread. The only possible concurrent access is from Cordz collection code, which should be a relatively rare event.\n\nPiperOrigin-RevId: 368673758\n\n--\n1255120dce2bdd6b4205a34a0e555e0b74b6152f by Martijn Vels \u003cmvels@google.com\u003e:\n\nRemove \u0027depth\u0027 from active recorded metrics.\n\nGoing forward we do not \u0027live\u0027 record depth (and size), but will observe these at collection time only.\n\nPiperOrigin-RevId: 368636572\n\n--\n83e5146e35f221736b49e9f0a8805f8c159a51db by Martijn Vels \u003cmvels@google.com\u003e:\n\nMake cordz targets visible in OSS\n\nPiperOrigin-RevId: 368615010\n\n--\ndcb16a4f1239151f0a8c70a8cfeb29dabbd113b8 by Martijn Vels \u003cmvels@google.com\u003e:\n\nInternal cleanup\n\nPiperOrigin-RevId: 368514666\nGitOrigin-RevId: 341670bce317dd6af8d3c066970230591a47e80c\nChange-Id: I94cecfbbd441eb386f99fc5186c468a7a5538862\n", "tree_diff": [ { "type": "modify", "old_id": "4527ca14ca5d7cf2b689fa800c745db4c014753c", "old_mode": 33188, "old_path": "CMake/AbseilDll.cmake", "new_id": "2f2fa13d78495c3343ec0c123ca2f8254e2325c2", "new_mode": 33188, "new_path": "CMake/AbseilDll.cmake" }, { "type": "modify", "old_id": "113851637d594407d40f6a9ce8563db1d6ad5b17", "old_mode": 33188, "old_path": "absl/strings/BUILD.bazel", "new_id": "1306ea65a9ef7eb36472507e11e7f8a390296182", "new_mode": 33188, "new_path": "absl/strings/BUILD.bazel" }, { "type": "modify", "old_id": "0d93d5ffe3fdb1f62b5339e1c6f7be103e15300d", "old_mode": 33188, "old_path": "absl/strings/CMakeLists.txt", "new_id": "044e38b36b277f496b5fb2495c78f753e4106ef6", "new_mode": 33188, "new_path": "absl/strings/CMakeLists.txt" }, { "type": "modify", "old_id": "8f0999f86e061bcab774b28b600acc5466ef4622", "old_mode": 33188, "old_path": "absl/strings/cord.cc", "new_id": "d33d6a0d45b0c98689c6ec71d7620f0210a86b38", "new_mode": 33188, "new_path": "absl/strings/cord.cc" }, { "type": "modify", "old_id": "7ce938ca5bb70d80e2d9ad9984f4a7aa9941b457", "old_mode": 33188, "old_path": "absl/strings/cord.h", "new_id": "de1470b2c20fa404dde074d29aaa094e569c6ad7", "new_mode": 33188, "new_path": "absl/strings/cord.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "6ad864f107c5366ce025349986ccfea13f98aac8", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_functions.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c9ba14508a0a5a2e560ac47181bc75fcbf50d9ce", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_functions.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "f2cefae34a7fce5c66cdd7ef6121e6bb84d33211", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_functions_test.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "7e82f85bd1f7a65882720bad561d25d68d0e3995", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_handle.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "0235d4bdee9af7f347010e24f67a837ff6820d7f", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_handle.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c04240e86164dd6bfecb630ad7c653ab13c50518", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_handle_test.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "4dec63d5decfae8b7d54699c7f1aef747d08cbcc", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_info.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c1090a1cf19e2bf4e31320805c98113929f6977f", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_info.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "be20e4a4cc8c4a6890221e20ebc887ef0a1afe25", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_info_test.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "ba1270d8f01f80b4d24bdf5200e8f0b2a0be3cbe", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_sample_token.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "28a1d70ccc2954c037b4c50e88f3783c988bc9c2", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_sample_token.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "8c0526424677c7d382ed668e52ce8eb0819c89e9", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_sample_token_test.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "ce7c39aa13d5b02a57eff201e6a34c6d14bcc479", "new_mode": 33188, "new_path": "absl/strings/internal/cordz_statistics.h" } ] }