)]}' { "log": [ { "commit": "45e341cd7ffcc31db0cb337eb70cc08c13e957f2", "tree": "1ac097531cbf1ab127b40fcc6ef38ca48385d7bf", "parents": [ "e3b3263e07463c337c394117ccf8aa4090a66048" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Thu May 07 11:44:05 2026 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu May 07 11:44:05 2026 -0400" }, "message": "Add C++ runtime libs to cgo action inputs (#4594)\n\nWith @llvm toolchain, libc++ is provided via cc_toolchain\u0027s\n`static_runtime_library`/`dynamic_runtime_library`. These groups should\nbe added to link actions otherwise cgo code that attempts to link libc++\nwill not work properly. It seems there were previous attempts to drop\nlibc++ - I\u0027m not sure the best way to harmonize these, some tweaking of\nthis PR may be necessary. @jayconrod @fmeum wdyt?" }, { "commit": "e3b3263e07463c337c394117ccf8aa4090a66048", "tree": "c52fa61dc1d98cdadf176ab72f91b809bbcb7d4f", "parents": [ "65c1b4d0c77d67e66fca162719ac375dc96514e1" ], "author": { "name": "Sahin Yort", "email": "thesayyn@gmail.com", "time": "Wed May 06 01:01:16 2026 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed May 06 10:01:16 2026 +0200" }, "message": "fix: avoid generating -Wl for dynamic libraries with an interface (#4574)\n\n**What type of PR is this?**\n\n\u003e Bug fix\n\n**What does this PR do? Why is it needed?**\n\n_cc_libs_and_flags only collected files from LibraryToLink.libraries and\nignored\nlinker_input.additional_inputs, so any files provided via that field\nwere never added to the GoCompilePkg or\nGoLink sandboxes. Additionally, when a LibraryToLink has both\ninterface_library and dynamic_library set, adding\nthe dynamic_library to libs caused it to flow into cgo_deps, which the\nGoLink rpath generation loop iterated\nover — with many such libraries this generates enough -Wl,-rpath flags\nto exceed the OS argument limit. The fix\ncollects additional_inputs from each linker input and makes them\navailable to the compile sandbox, while\ndynamic_library from interface+dynamic pairs is tracked separately as\nlink_inputs and threaded through GoArchive\nto GoLink as plain sandbox inputs — bypassing rpath generation entirely.\n\n**Which issues(s) does this PR fix?**\n\nFollow up to https://github.com/bazel-contrib/rules_go/pull/4569 which\nit incorrectly fixed.\n\n**Other notes for review**\n\n---------\n\nCo-authored-by: Fabian Meumertzheim \u003cfabian@meumertzhe.im\u003e" }, { "commit": "65c1b4d0c77d67e66fca162719ac375dc96514e1", "tree": "7d317ad347c98bde516fc02f57143cf55ca01984", "parents": [ "aadb72e60d6b24b086d082cb25af8b5ec00a51d2" ], "author": { "name": "Dean Lindqvist Todevski", "email": "dean.todevski@gmail.com", "time": "Fri May 01 21:10:29 2026 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri May 01 19:10:29 2026 +0000" }, "message": "Consistent auto-registered toolchain path naming (#4597)\n\n**What type of PR is this?**\n\n Bug fix\n\n**What does this PR do? Why is it needed?**\n\nAs discussed in\nhttps://bazelbuild.slack.com/archives/CA31HN1T3/p1776898907041159?thread_ts\u003d1776576264.819169\u0026cid\u003dCA31HN1T3.\nName autoregistered go toolchain paths consistently independent of host\nplatform.\n\n**Which issues(s) does this PR fix?**\n\nWe have a remote execution cluster running linux/amd64. The toolchain\npaths look different if we target it from a linux/amd64 or a\ndarwin/arm64 host, changing the ActionKey:s and thereby preventing us\nfrom sharing cache hits. Here is an example diff between aquery:s from\nthe two host platforms:\n```diff\nEnvironment: [CGO_ENABLED\u003d0, GOARCH\u003damd64, GODEBUG\u003dwinsymlink\u003d0, GOEXPERIMENT\u003d, GOOS\u003dlinux, GOPATH\u003d, GOROOT\u003dbazel-out/linux-amd64-opt-ST-c808acfdf156/bin/external/rules_go+/stdlib_, GOROOT_FINAL\u003dGOROOT, GOTOOLCHAIN\u003dlocal]\n- Command Line: (exec bazel-out/linux-amd64-opt-exec-ST-4601870f3351/bin/external/rules_go++go_sdk+main___download_0/builder_reset/builder \\\n+ Command Line: (exec bazel-out/linux-amd64-opt-exec-ST-4601870f3351/bin/external/rules_go++go_sdk+main___download_0_linux_amd64/builder_reset/builder \\\n link \\\n -sdk \\\n- external/rules_go++go_sdk+main___download_0 \\\n+ external/rules_go++go_sdk+main___download_0_linux_amd64 \\\n -goroot \\\n bazel-out/linux-amd64-opt-ST-c808acfdf156/bin/external/rules_go+/stdlib_ \\\n -installsuffix \\\n@@ -2593,7 +2593,7 @@\n -arc \\\n \u0027@@rules_go+//go/tools/bzltestutil:bzltestutil\u003dgithub.com/bazelbuild/rules_go/go/tools/bzltestutil\u003dbazel-out/linux-amd64-opt-ST-4601870f3351/bin/external/rules_go+/go/tools/bzltestutil/bzltestutil.a\u0027 \\\n -package_list \\\n- bazel-out/linux-amd64-opt-exec-ST-4601870f3351/bin/external/rules_go++go_sdk+main___download_0/packages.txt \\\n+ bazel-out/linux-amd64-opt-exec-ST-4601870f3351/bin/external/rules_go++go_sdk+main___download_0_linux_amd64/packages.txt \\\n -X \\\n \u0027github.com/formulatehq/ingest/defaults.GitBranch\u003d{STABLE_GIT_BRANCH}\u0027 \\\n -X \\\n```\n\nWith this change the toolchain path is\n`bazel-out/linux-amd64-opt-exec-ST-4601870f3351/bin/external/rules_go++go_sdk+main___download_0_linux_amd64/packages.txt`\nregardless of host platform.\n\n**Other notes for review**" }, { "commit": "aadb72e60d6b24b086d082cb25af8b5ec00a51d2", "tree": "45237da05ac7c37686d5b0d9960962434fb714d6", "parents": [ "0725e3249ce4eaeaee39a9a3530f656231855b22" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Wed Apr 29 13:29:18 2026 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Apr 29 17:29:18 2026 +0000" }, "message": "Use rules_cc to load cc symbols (#4579)\n\n**What type of PR is this?**\nRefactor/cleanup\n\n**What does this PR do? Why is it needed?**\nThese should disappear from @bazel_tools eventually\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "0725e3249ce4eaeaee39a9a3530f656231855b22", "tree": "78397ce4c4e1c827def84e630a9ea68d1d44318a", "parents": [ "2484069f1d7f41561d62f42e7e8700fa5026e5c3" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Mon Apr 27 20:54:36 2026 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Apr 28 00:54:36 2026 +0000" }, "message": "Stop including deprecated properties in context by default (#4389)\n\n**What type of PR is this?**\nCleanup\n\n**What does this PR do? Why is it needed?**\nWe would like to drop support for these properties completely, but for\nnow let\u0027s make them opt-in rather than opt-out. The core Go rules have\nnot been using them for 9 months or so.\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "2484069f1d7f41561d62f42e7e8700fa5026e5c3", "tree": "2f4c81432db54bbf55b7ebf3f4a7b8c5435fb5fe", "parents": [ "d83032da0b6cee93c43f6ce2c7d9c865700de961" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Mon Apr 27 18:35:54 2026 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Apr 27 22:35:54 2026 +0000" }, "message": "Remove cgo_context_data (#4599)\n\nIt\u0027s tempting to use a single target to centralize cc toolchain lookup,\nbut ultimately it is incorrect. Toolchain resolution must be performed\nby the rules using that toolchain, in order to properly match on the\nexec platforms. The other reason for cgo_context_data was that\npreviously optional toolchains were not possible, but now they are.\nCleanup this incorrect rule to thwart the temptations.\n\n---------\n\nCo-authored-by: Fabian Meumertzheim \u003cfabian@meumertzhe.im\u003e" }, { "commit": "d83032da0b6cee93c43f6ce2c7d9c865700de961", "tree": "4d96a162896d7e5d0846de97e197bbf71f297028", "parents": [ "feb90eb90cc0902e20848cdf3a7a0e1c288a712f" ], "author": { "name": "Keith Smiley", "email": "keithbsmiley@gmail.com", "time": "Mon Apr 27 12:11:05 2026 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Apr 27 19:11:05 2026 +0000" }, "message": "Fix invalid comparison (#4598)\n\n`go.mode` is a struct, so it was never equal to `LINKMODE_NORMAL`. I\u0027m\nnot sure what visible effect this had but I noticed it when debugging\nanother issue.\n\nCo-authored-by: Jay Conrod \u003cjay@engflow.com\u003e" }, { "commit": "feb90eb90cc0902e20848cdf3a7a0e1c288a712f", "tree": "7d84123b5dbf4055fb3386e19184ebe236ec7bdd", "parents": [ "eedda259fbbb5320faa0903ec3bac9ff3d4eedbe" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Mon Apr 27 13:46:43 2026 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Apr 27 13:46:43 2026 -0400" }, "message": "perf: Only resolve cc toolchain for rules that will need it (#4593)\n\nThis PR is a re-write of\nhttps://github.com/bazel-contrib/rules_go/pull/4591 which was incorrect\n- the cc toolchain must be resolved by the rule owning the action that\nuses it, it cannot be resolved by a dependent rule (CgoContextData) as\nthat will not work correctly when there are multiple execution\nplatforms. See\nhttps://bazelbuild.slack.com/archives/CDBP88Z0D/p1776380536174449 for\ndiscussion" }, { "commit": "eedda259fbbb5320faa0903ec3bac9ff3d4eedbe", "tree": "94a67b893cafbac934059f1a7f1116a9b11b654f", "parents": [ "dfabfe9ab146aef567cb37284817de571a78e6ff" ], "author": { "name": "Jay Conrod", "email": "jay@engflow.com", "time": "Mon Apr 27 08:00:44 2026 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Apr 27 15:00:44 2026 +0000" }, "message": "gopackagesdriver: ignore bazel analysis errors (#4567)\n\n**What type of PR is this?**\n\n\u003e Bug fix\n\n**What does this PR do? Why is it needed?**\n\nBazel exits with code 7 (ANALYSIS_FAILURE) when querying a file that\u0027s\nnot mentioned in BUILD. gopackagesdriver can returns partial results for\ncode 1 (BUILD_FAILURE), but not 7.\n\ngopackagesdriver often hits this for a new file not added to BUILD. A\nfile\u003d query may still fail in this case because the query will match no\nlabels, but at least that\u0027s no longer a bazel error.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4565\n\n**Other notes for review**" }, { "commit": "dfabfe9ab146aef567cb37284817de571a78e6ff", "tree": "bc2d2ee2d92257efabfbef612b7e992128df084c", "parents": [ "fcc41bbe67d83d3cd388890ff7c872832944347c" ], "author": { "name": "Teo Koon Peng", "email": "teokoonpeng@gmail.com", "time": "Sat Apr 18 15:04:50 2026 +0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sat Apr 18 07:04:50 2026 +0000" }, "message": "gopackagesdriver: fix missing cgo files when RBE is used (#4589)\n\nBug fix #4588\n\nWe notice in our codebase that gopls fails to index some files. The\ngopackagesdriver logs show this error:\n\n```\nerror: unable to load JSON files: unable to resolve imports: open \u003comitted\u003e/_cgo_gotypes.go: no such file or directory\n```\n\nI feed the error to gemini and it proposed this:\n\n\u003cdetails\u003e\n\n\u003csummary\u003eGemini report\u003c/summary\u003e\n\n## Root Cause\n\nThe root cause lies within the `rules_go` Bazel ruleset, specifically in\nthe `go_pkg_info_aspect` aspect located at\n`go/tools/gopackagesdriver/aspect.bzl`.\n\nTo understand the issue, it is helpful to understand a few key concepts\nin this workflow:\n* **`pkg.json`**: A metadata file generated by the `go_pkg_info_aspect`\naspect for each Go target. It contains structured information (like\ndependencies, source files, and import paths) that `gopackagesdriver`\nuses to inform `gopls` about how the package is constructed.\n* **`compiled_go_files`**: A list within the aspect\u0027s provider that\ntracks all the Go source files destined for compilation. In Bazel,\nexposing these files in an output group (like `go_pkg_driver_srcs`)\ntells the build system that it must actually execute the actions to\ngenerate these files before the build command finishes.\n* **`cgo_out_dir`**: The output directory containing intermediate Go\nfiles generated by the `cgo` tool (such as `_cgo_gotypes.go` and\n`_cgo_export.go`). These files are generated from C/C++ sources or Go\nfiles containing `import \"C\"`.\n\nWhen the aspect processes a `go_test` target, it traverses the\ndependencies to find the archive containing the test sources. While it\ncorrectly generates the `pkg.json` metadata file pointing to the\ngenerated `cgo` output files within the `cgo_out_dir`, it forgot to add\nthe `cgo_out_dir` to the list of `compiled_go_files`.\n\nBecause `cgo_out_dir` was omitted from `compiled_go_files` (which maps\nto the `go_pkg_driver_srcs` output group), Bazel did not guarantee that\nthe `cgo` outputs were actually built and present on disk before\ncompleting the aspect execution. When `gopls` then parsed the `pkg.json`\nand attempted to read the generated source files, they were missing,\nresulting in the error.\n\n## Resolution\n\nThe issue was resolved by patching `rules_go` to ensure that\n`cgo_out_dir` is correctly added to `compiled_go_files` when processing\n`go_test` dependencies.\n\n```diff\ndiff --git a/go/tools/gopackagesdriver/aspect.bzl b/go/tools/gopackagesdriver/aspect.bzl\nindex dbe5663..8dc7d3e 100644\n--- a/go/tools/gopackagesdriver/aspect.bzl\n+++ b/go/tools/gopackagesdriver/aspect.bzl\n@@ -108,6 +108,8 @@ def _go_pkg_info_aspect_impl(target, ctx):\n if archive.data.label \u003d\u003d dep_archive.data.label:\n pkg_json_files.append(make_pkg_json_with_archive(ctx, dep_archive.data.name, dep_archive))\n compiled_go_files.extend(dep_archive.source.srcs)\n+ if dep_archive.data.cgo_out_dir:\n+ compiled_go_files.append(dep_archive.data.cgo_out_dir)\n export_files.append(dep_archive.data.export_file)\n break\n \n```\n\n\u003c/details\u003e\n\nI don\u0027t fully understand the root cause but the proposed fix is working\nfor us. Does the fix make sense?\n\nSigned-off-by: Teo Koon Peng \u003ckoonpeng@google.com\u003e\nCo-authored-by: Fabian Meumertzheim \u003cfabian@meumertzhe.im\u003e" }, { "commit": "fcc41bbe67d83d3cd388890ff7c872832944347c", "tree": "7635601d267697ae0388b6a0f7e048ec852fa003", "parents": [ "fc06c2473f6530bbb5901ab75667faadfcedef4f" ], "author": { "name": "James Sharpe", "email": "mail@jsharpe.net", "time": "Sat Apr 18 00:32:37 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Apr 17 19:32:37 2026 -0400" }, "message": "Revert \"context: prefer pre-computed CgoContextInfo from go_context_data\" (#4592)\n\nReverts bazel-contrib/rules_go#4591" }, { "commit": "fc06c2473f6530bbb5901ab75667faadfcedef4f", "tree": "6f6fd4cf095519632854baeb4df25ae264c6019d", "parents": [ "8808bb8c6604f1e7a2badbfcd9a9db4c32ba0a8c" ], "author": { "name": "James Sharpe", "email": "mail@jsharpe.net", "time": "Fri Apr 17 21:25:50 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Apr 17 20:25:50 2026 +0000" }, "message": "go/private: optimize _filter_options to avoid O(n²) scan (#4590)\n\nSplit the denylist into exact-match entries (dict lookup, O(1)) and\nprefix-match patterns (those ending in \"\u003d\", e.g. \"-fmax-errors\u003d\").\n\nOnly the rare prefix patterns require a linear scan, eliminating the\nprevious O(options × denylist) _match_option loop for the common case.\n\nThis provides a significant reduction in CPU time on large repos:\n| | Before | After |\n|--|--|--|\n| `_filter_options` CPU | 123s | 0.004s |\n| `_match_option` CPU | 56s | **0s** |\n\nCo-authored-by: Fabian Meumertzheim \u003cfabian@meumertzhe.im\u003e" }, { "commit": "8808bb8c6604f1e7a2badbfcd9a9db4c32ba0a8c", "tree": "77f22e689a99e68fea00dccd4089c597e04f1edc", "parents": [ "3b6b59aedb5c4500e422ae5634b9d47ef0aafa60" ], "author": { "name": "Hugo Beauzée-Luyssen", "email": "hugo@beauzee.fr", "time": "Fri Apr 17 15:34:41 2026 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Apr 17 15:34:41 2026 +0200" }, "message": "bzltestutil: fix re-exec failure on Windows when runfiles path exceeds MAX_PATH (#4586)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nFix `go_test` failures when the path containing the test executable is\nlonger than `MAX_PATH`.\nThe issue stems from `CreateProcess` which will systematically reject\nany working directory (whether passed explicitly or to be inherited)\nlonger than `MAX_PATH`, regardless of longpath prefix (`\\\\?\\`), long\npath setting being enabled in the registry, or `longPathAware` being\npresent in the binary\u0027s manifest.\n\n**Which issues(s) does this PR fix?**\n\nAFAIK, there is no open issue.\n\nI initially reported this to go\u0027s tracker as\nhttps://github.com/golang/go/issues/78601, but in the context of\n`rules_go` I don\u0027t think there is one.\n\n**Other notes for review**\n\nI wasn\u0027t sure what to do about testing. AFAICS testing `Wrap` might\nquickly become over complicated, and testing the new condition in\nisolation doesn\u0027t bring much. Please let me know if you have something\nin mind here!\n\n---------\n\nCo-authored-by: Joseph Gette \u003cjgettepost@gmail.com\u003e\nCo-authored-by: Fabian Meumertzheim \u003cfabian@meumertzhe.im\u003e" }, { "commit": "3b6b59aedb5c4500e422ae5634b9d47ef0aafa60", "tree": "1dc3d45138c19e7096cc1148eee0cf7e527ec696", "parents": [ "4f7900fab6689775d6f2060a338fc73f0d2d9d33" ], "author": { "name": "James Sharpe", "email": "mail@jsharpe.net", "time": "Fri Apr 17 00:25:27 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Apr 16 23:25:27 2026 +0000" }, "message": "context: prefer pre-computed CgoContextInfo from go_context_data (#4591)\n\nReorder the CgoContextInfo resolution in go_context() so that the\npre-computed value from go_context_data is checked before falling back\nto cgo_context_data_impl().\n\nThis avoids re-running the expensive cgo_context_data_impl for every\ngo_library target when a shared CgoContextInfo is already available from\nthe cgo_context_data rule.\n\nPerf improvements:\n| | Before | After |\n|--|--|--|\n| `cgo_context_data_impl` CPU | 132s | **0.02s** |" }, { "commit": "4f7900fab6689775d6f2060a338fc73f0d2d9d33", "tree": "997c69a9e036c080ae688e9a8788787c297b4cce", "parents": [ "552451c5d1f8fa47d3df2630eee6b39ab6c9bbf6" ], "author": { "name": "juanzolotoochin", "email": "88746611+juanzolotoochin@users.noreply.github.com", "time": "Tue Apr 07 13:43:49 2026 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Apr 07 20:43:49 2026 +0000" }, "message": "gopackagesdriver: disable path mapping for GoStdlibList action (#4585)\n\nSince https://github.com/bazel-contrib/rules_go/pull/4441, the\n`GoStdlibList` action uses `SUPPORTS_PATH_MAPPING_REQUIREMENT` and\npasses the cache directory via `add_all` (which enables path mapping).\nThis causes the stdlib builder to write path-mapped directory names\n(e.g. `bazel-out/cfg/`) into `stdlib.pkg.json`. The gopackagesdriver\nthen reads these paths at runtime to open source files, but the mapped\ndirectory doesn\u0027t exist on disk — the actual files are under the real\nconfig directory (e.g. `bazel-out/k8-fastbuild/`).\n\nThis breaks the gopackagesdriver for any Go target:\n\n```\nerror: unable to resolve imports: open .../bazel-out/cfg/bin/external/io_bazel_rules_go/stdlib_/gocache/...: no such file or directory\n```\n\nAffected stdlib packages are those with CGO-compiled files (`net`,\n`os/user`, `internal/runtime/cgobench`, etc.) whose `CompiledGoFiles`\nreference gocache entries under the mapped path.\n\n**Fix:** Unlike the stdlib build action (`_build_stdlib`), the\n`GoStdlibList` action produces `stdlib.pkg.json` which is consumed at\nruntime by the gopackagesdriver — not by Bazel. Path mapping is not\nappropriate here because the mapped paths are never resolved back to\nreal paths before being read. Revert to using `cache_dir.path` (real\nfilesystem path) and remove `SUPPORTS_PATH_MAPPING_REQUIREMENT` from\nthis action only.\n\nThis PR is an alternative to\nhttps://github.com/bazel-contrib/rules_go/pull/4584 which tried to\nresolve this at the gopackagesdriver but that solution was deemed\nbrittle." }, { "commit": "552451c5d1f8fa47d3df2630eee6b39ab6c9bbf6", "tree": "b81903e965d3db00d1cbf47e6e775c7b060d102b", "parents": [ "2ce3598fc987420d180649847f3bf1cc044494e6" ], "author": { "name": "hunshcn", "email": "hunsh.cn@gmail.com", "time": "Wed Apr 01 02:00:52 2026 +0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Mar 31 20:00:52 2026 +0200" }, "message": "link: remove -z,now (BIND_NOW) from CC toolchain extldflags (#4578)\n\n## Summary\n\nFixes #4377.\n\nThe CC toolchain (`rules_cc`) typically passes `-Wl,-z,relro,-z,now` to\nthe linker for security hardening. However, `-z,now` forces all dynamic\nsymbols to be resolved at load time (BIND_NOW), which breaks Go\nlibraries that use `dlopen`/`dlsym` to load symbols at runtime.\n\nFor example, [NVIDIA\u0027s go-nvml](https://github.com/NVIDIA/go-nvml)\ndeclares NVML C functions in its header file, which CGO compiles into\nundefined dynamic symbols. At runtime, go-nvml loads these symbols via\n`dlopen(\"libnvidia-ml.so.1\", RTLD_LAZY | RTLD_GLOBAL)` inside\n`nvml.Init()`. With `BIND_NOW`, the dynamic linker fails immediately at\nprogram start:\n\n```\nsymbol lookup error: undefined symbol: nvmlComputeInstanceDestroy\n```\n\nThe same code works with `go build` because **the standard Go toolchain\ndoes not pass `-z,relro` or `-z,now` to the linker**.\n\n## Root Cause\n\n```\nrules_cc: unix_cc_configure.bzl → adds -Wl,-z,relro,-z,now to CC toolchain\nrules_go: context.bzl → picks up as ld_executable_options\nrules_go: mode.bzl → extldflags_from_cc_toolchain() returns them\nrules_go: link.bzl → passes as -extldflags to Go linker\n```\n\nThe resulting binary has `FLAGS: BIND_NOW` in its ELF dynamic section,\nwhile `go build` produces a binary without it.\n\n## Fix\n\nAdd `-Wl,-z,relro,-z,now` and `-Wl,-z,now` to `_LINKER_OPTIONS_DENYLIST`\nin `context.bzl`, consistent with how `-Wl,--gc-sections` and `-pie` are\nalready filtered for the same reason (CC toolchain defaults incompatible\nwith Go binaries).\n\nSince `go build` does not pass `-z,relro` either, filtering the compound\nflag entirely aligns with `go build` behavior.\n\n## Test plan\n\n- Added `bind_now_test.go` that inspects the ELF dynamic section of a\nnon-PIE cgo binary to verify `DF_BIND_NOW` / `DF_1_NOW` flags are not\nset (PIE excluded because the Go linker itself sets BIND_NOW for\n`-buildmode\u003dpie`)\n- Verified with a [minimal reproduction\nrepository](https://github.com/hunshcn/nvml-go-bazel) that the fix\nresolves the runtime symbol lookup error (the repo also includes a\n[user-level\nworkaround](https://github.com/hunshcn/nvml-go-bazel/commit/4110d4a)\nusing `gc_linkopts \u003d [\"-extldflags\", \"-Wl,-z,lazy\"]`)\n\n---------\n\nCo-authored-by: Claude Opus 4.6 \u003cnoreply@anthropic.com\u003e" }, { "commit": "2ce3598fc987420d180649847f3bf1cc044494e6", "tree": "d0195d90061be03fde69f9121689e78664b40758", "parents": [ "e7fb6ab0b4380ba16607152b0bef3e09ff66d8ab" ], "author": { "name": "luzhanning", "email": "35372007+luzhanning@users.noreply.github.com", "time": "Wed Mar 25 00:48:22 2026 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Mar 25 08:48:22 2026 +0100" }, "message": "fix: Allow passing pgoprofile via the command line (#4580)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\nCurrently pgoprofile can be only set via BUILD files.\n\u0027--@io_bazel_rules_go//go/config:pgoprofile\u0027 will fail.\n\n**Which issues(s) does this PR fix?**\nAllow passing --@io_bazel_rules_go//go/config:pgoprofile thourgh command\nline\n\nFixes #4226\n\n**Other notes for review**\n\nCo-authored-by: zhanning.lu \u003czhanning.lu@bytedance.com\u003e" }, { "commit": "e7fb6ab0b4380ba16607152b0bef3e09ff66d8ab", "tree": "91467584935e0fa189198c649ea4218c9d3fa938", "parents": [ "6b4949e01d38d9eafecb071201a4f0a1ff81b651" ], "author": { "name": "Andrea Nardelli", "email": "nrd.nardelli@gmail.com", "time": "Thu Mar 19 16:44:38 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Mar 19 16:44:38 2026 +0100" }, "message": "`go_bin_runner`: connect stdin (#4576)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nFixes #4573 - more context written there" }, { "commit": "6b4949e01d38d9eafecb071201a4f0a1ff81b651", "tree": "078b3a20c9739888e3c71f13f6274aa0e139a7e3", "parents": [ "8e315a484519bb1b77238a232a82f91035143528" ], "author": { "name": "Son Luong Ngoc", "email": "sluongng@gmail.com", "time": "Tue Mar 17 23:08:03 2026 +0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Mar 17 17:08:03 2026 +0100" }, "message": "nogo: plumb SDK Go version into go/types (#4564)\n\nForward the selected SDK Go version from compilepkg into nogo and\ninitialize the corresponding go/types version plumbing during type\nchecking. This keeps nogo aligned with the active toolchain version\nwithout keying the action on unrelated gcflags.\n\nKeep gc_goopts -lang overrides unsupported for now. RunNogo still\nforwards only the SDK version, and compilepkg now documents that -lang\nparsing may be added later once nogo has proper gc flag parsing.\n\nAdd focused nogo coverage that checks both the RunNogo action" }, { "commit": "8e315a484519bb1b77238a232a82f91035143528", "tree": "344d04b4538287fe8626ea14d34621b5946fb4be", "parents": [ "d2997544dfec13ff17f8ab6f6d138dfda5ef44c0" ], "author": { "name": "Roman Mingazeev", "email": "Direnol@yandex.ru", "time": "Mon Mar 16 11:47:46 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Mar 16 10:47:46 2026 +0000" }, "message": "fix: unstable import sorting for GoTestGenTest (#4570)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nIt fixes non-deterministic output for `GoTestGenTest` that is caused by\nunstable import list sorting that might lead to cache misses during the\nbuild\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**\n\nCo-authored-by: Roman Mingazeev \u003cdirenol@nebius.com\u003e" }, { "commit": "d2997544dfec13ff17f8ab6f6d138dfda5ef44c0", "tree": "3b92313a91a5fb57257f02591cd7b64f4b184687", "parents": [ "ca94a5b1d0fe87678ce01fcb75cb7839343b5f8e" ], "author": { "name": "Sahin Yort", "email": "thesayyn@gmail.com", "time": "Sat Mar 14 10:51:07 2026 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sat Mar 14 18:51:07 2026 +0100" }, "message": "fix: cgo: include dynamic library when interface library is set (#4569)\n\nOn Linux, some packages provide a linker script as the interface library\n(e.g. a bare `libfoo.so` containing `GROUP(...)`). The script references\nthe actual versioned dynamic library, which must also be present in the\nsandbox for the linker to resolve it." }, { "commit": "ca94a5b1d0fe87678ce01fcb75cb7839343b5f8e", "tree": "1dadd0c27bf6651891f890616a0fa47bd940baf3", "parents": [ "811ab2d5bc20c7c8c66d5ea61393a29000aa0769" ], "author": { "name": "Jay Conrod", "email": "jay@engflow.com", "time": "Fri Mar 13 07:32:28 2026 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Mar 13 07:32:28 2026 -0700" }, "message": "gopackagesdriver: log events using slog (#4566)\n\n**What type of PR is this?**\n\n\u003e Feature\n\n**What does this PR do? Why is it needed?**\n\nWhen GOPACKAGESDRIVER_LOG is set, gopackagesdriver now logs events by\nappending JSON objects to the file. This is useful for finding arguments\ngopackagesdriver was invoked with, bazel commands it ran, bazel exit\ncodes returned, and bazel stderr.\n\n**Which issues(s) does this PR fix?**\n\nFor #4565\n\n**Other notes for review**" }, { "commit": "811ab2d5bc20c7c8c66d5ea61393a29000aa0769", "tree": "9988b02a2540315dd081f489c0b6e0b6b66476bc", "parents": [ "d6253d4e5a401982f26d2c31d6b099045b27c59a" ], "author": { "name": "Keith Smiley", "email": "keithbsmiley@gmail.com", "time": "Mon Mar 09 15:40:55 2026 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Mar 09 22:40:55 2026 +0000" }, "message": "Handle absolutizing -internal-isystem (#4563)\n\nThis is similar to the other flags except it is wrapped in -Xclang\nforwarding flags. This can be set by a CC toolchain similar to the\nothers." }, { "commit": "d6253d4e5a401982f26d2c31d6b099045b27c59a", "tree": "9a00e4d230fff14a94cb8579523d6fb67dd67f3e", "parents": [ "4762cd6a65abe496519dc0327b72c211ea8a25a8" ], "author": { "name": "LINKIWI", "email": "LINKIWI@users.noreply.github.com", "time": "Fri Mar 06 02:47:57 2026 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Mar 06 08:47:57 2026 +0100" }, "message": "go/tools/builders: Pass `CFLAGS` to assembly sources compilation (#4559)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nThis PR passes C flags to the invocation of the assembly compiler when\nCGO is enabled.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4558\n\n**Other notes for review**\n\n* Please refer to the issue for a reproduction case.\n* This PR includes a test case that directly exercises the fix, but does\nnot attempt to reconstruct the convoluted setup that originally exposed\nthe bug." }, { "commit": "4762cd6a65abe496519dc0327b72c211ea8a25a8", "tree": "549113732144f661b4095c5905121b856b6bfd9b", "parents": [ "9ca4797bbca6f785febcff7bc1508c83110a5de8" ], "author": { "name": "Andy Hochhaus", "email": "hochhaus@users.noreply.github.com", "time": "Mon Mar 02 05:10:22 2026 -0600" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Mar 02 11:10:22 2026 +0000" }, "message": "Allow go_binary to override go_library x_defs (#4562)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nFixes #4561\n\n**Other notes for review**\n\nx_defs from dependencies were incorrectly applied after the source\u0027s\nx_defs, causing library values to overwrite binary values. Reverse the\norder so that source x_defs are applied last. This behavior matches the\ndocumentation which states:\n\n\nhttps://github.com/bazel-contrib/rules_go/blob/master/docs/go/core/defines_and_stamping.md\n\n \u003e You can also override stamp values from libraries using x_defs on\n \u003e the go_binary rule if needed." }, { "commit": "9ca4797bbca6f785febcff7bc1508c83110a5de8", "tree": "ab1103fc64cb0b4138995d01ae4b161184283509", "parents": [ "c80ebd13ddc794884bfd2fe68fcfda646e905bf1" ], "author": { "name": "Régis Desgroppes", "email": "rdesgroppes@gmail.com", "time": "Wed Feb 11 20:37:53 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Feb 11 20:37:53 2026 +0100" }, "message": "Also allow to read the SDK version from `go.work` (#4555)\n\n**What type of PR is this?**\n\nFeature\n\n**What does this PR do? Why is it needed?**\n\nExtends `go_sdk.from_file` (#4305) to accept a `go_work` attribute\nalongside the existing `go_mod` attribute. This allows modules to read\ntheir SDK version from a `go.work` file, providing better integration\nfor workspace-based Go projects and maintaining consistency with the\nexisting `go.mod` support.\n\nVersion extraction follows the same rules as `go.mod`: the `toolchain`\ndirective takes precedence over the `go` directive.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4554.\n\n**Other notes for review**\n\nWhen the go line is omitted, `go.mod` has an implicit `go 1.16` line\nwhile `go.work` has an implicit `go 1.18` line, as per the Go toolchain\ndocumentation at https://go.dev/doc/toolchain#config.\n\nThe implementation reuses the existing parser by extracting common logic\ninto a shared `_version_from_go_file` function that both\n`version_from_go_mod` and the new `version_from_go_work` call with\ndifferent default versions.\n\nTests follow the same pattern as `from_go_mod_file_test`, covering\ntoolchain precedence, minor version support, go-only directive, and\nmissing directives." }, { "commit": "c80ebd13ddc794884bfd2fe68fcfda646e905bf1", "tree": "5af727fa2e78db8123265e9588cfdc9300bf10fb", "parents": [ "fbbafef6e737fe18d3cdedfff4f8f060ac71d5f3" ], "author": { "name": "Tyler French", "email": "tfrench@uber.com", "time": "Tue Feb 10 02:33:32 2026 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Feb 10 08:33:32 2026 +0100" }, "message": "chore: update maintainers (#4552)\n\nAdd Jay and David to BCR maintainers, update Tyler\u0027s email and add Tyler\nto authors" }, { "commit": "fbbafef6e737fe18d3cdedfff4f8f060ac71d5f3", "tree": "1930afbfde4db6e0835ed0def4cbdca6983af934", "parents": [ "ebd809f18f9d25b332463638ff50160bbbea83c7" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Mon Feb 09 15:46:54 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Feb 09 14:46:54 2026 +0000" }, "message": "Revert \"Issue 1486: cgo: fix C++ dynamic initialization of static variables when using alwayslink \u003d True (#4438)\" (#4551)\n\nThis reverts commit 20f7e2bb45dfbd6630f7ce36ad62cb9001a7e2f5 as it\ncauses a regression (see #4548)" }, { "commit": "ebd809f18f9d25b332463638ff50160bbbea83c7", "tree": "2b4b27e00f51214173c159dfeff48710e640cedb", "parents": [ "cdad78d05f1f94a837394b11f1d352989ba1c164" ], "author": { "name": "Morten Mjelva", "email": "morten.mjelva@gmail.com", "time": "Sun Feb 01 23:14:36 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sun Feb 01 22:14:36 2026 +0000" }, "message": "chore: Mark go_download_sdk as reproducible (#4543)\n\nIf we pass the check `if not ctx.attr.sdks and not ctx.attr.version`,\nindicate that the repo rule is reproducible. This causes us to opt-in to\nusing the local and remote repository content cache when enabled." }, { "commit": "cdad78d05f1f94a837394b11f1d352989ba1c164", "tree": "6936f72918f534158545406afa41e2889e2fb843", "parents": [ "1cc11f11a85f74f289b8494b1863461bbacb44d8" ], "author": { "name": "John Cater", "email": "jcater@engflow.com", "time": "Fri Jan 30 13:09:18 2026 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Jan 30 19:09:18 2026 +0100" }, "message": "Replace HTML with Markdown in docs (#4542)\n\nChanges:\n- Convert html lists to Markdown lists.\n - Except in attributes, which breaks rendering\n- Remove html `code` tag in favor of Markdown\n- Remove html `strong` tag in favor of markdown\n\n**What type of PR is this?**\n\nDocumentation" }, { "commit": "1cc11f11a85f74f289b8494b1863461bbacb44d8", "tree": "551143d747b2b9c6ff3db6f16bb08b64dab8b1cc", "parents": [ "e6b690e717063da657afeeb22d6524fce01e9a85" ], "author": { "name": "John Cater", "email": "jcater@engflow.com", "time": "Fri Jan 30 11:49:36 2026 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Jan 30 16:49:36 2026 +0000" }, "message": "Replace html linebreaks with newlines. (#4541)\n\nThe html linebreaks, coupled with the markdown style triple-backtick,\nwas breaking rendering in some docs, specifically for `go_test`.\n\n**What type of PR is this?**\n\nDocumentation" }, { "commit": "e6b690e717063da657afeeb22d6524fce01e9a85", "tree": "cbd5a7d9cab85879e8c768d756ad58c060e5e13d", "parents": [ "23b3f09e3e88694d14cff94b18cf1f16d43d16f1" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Wed Jan 14 17:11:14 2026 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Jan 14 17:11:14 2026 +0100" }, "message": "Update BCR test module deps and Bazel version (#4537)\n\n**What type of PR is this?**\n\nDeps update\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "23b3f09e3e88694d14cff94b18cf1f16d43d16f1", "tree": "2324d2f0884d87be0768f2fc16dc04526ed3ff5b", "parents": [ "3b18746bb9ab9fcc5eb7c3bc3e2b25fcdb718c28" ], "author": { "name": "Aaron Hakala", "email": "aaron.hakala@gmail.com", "time": "Thu Jan 08 06:38:44 2026 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Jan 07 23:38:44 2026 -0500" }, "message": "fix(gopackagesdriver): Improve wildcard package query matching (#4288)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nImprove wildcard package loading (`./something/...`) when using a custom\nbazelQueryScope e.g. `//...`. Currently, the queryFromRequests\ntransformation results in a query like:\n\n```\nbazel query \"kind(\\\"^(go_library) rule$\\\", attr(importpath, \\\"^./something(/.+)?$\\\", deps(//...)))\"\n```\n\nwhich fails to return any results due to the `^` start of string\nmatching. This PR also aligns the behaviour more closely to the \"non\nwild card\" behaviour\n([see](https://github.com/bazel-contrib/rules_go/blob/077f15fe11b9da6aa0e3271db1260929f04fef87/go/tools/gopackagesdriver/bazel_json_builder.go#L123))\nby omitting the `^`.\n\nWhen using go outside bazel, the following query is valid syntax and\ncorrectly loads all the packages under `./something/`:\n\n```\npackage.Load(cfg, \"./something/...\")\n```\n\n**Which issues(s) does this PR fix?**\n\nNo issue\n\n**Other notes for review**" }, { "commit": "3b18746bb9ab9fcc5eb7c3bc3e2b25fcdb718c28", "tree": "fab3b91ce3afb161ecefc9de137527729aee99e7", "parents": [ "f76b49701e98fb18c7f0686be37b0ab7d66f1a7b" ], "author": { "name": "Tyler French", "email": "tfrench@uber.com", "time": "Wed Dec 17 10:15:34 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Dec 17 15:15:34 2025 +0000" }, "message": "fix(releaser): add MODULE.bazel boilerplate (#4225)\n\nThis will make the release easier.\n\nWe should also have the releaser add the MODULE.bazel boilerplate code.\n\nThis also adds tests to the modified function.\n\nWe also don\u0027t need require release notes, since we can just edit in the\nUI." }, { "commit": "f76b49701e98fb18c7f0686be37b0ab7d66f1a7b", "tree": "2a44c5cd4ef65c07ff5955d986e02c6d5158a5e8", "parents": [ "d1ff6e2ff4a8292bdc42e3c983bd8028dceab33c" ], "author": { "name": "dependabot[bot]", "email": "49699333+dependabot[bot]@users.noreply.github.com", "time": "Fri Dec 12 04:12:57 2025 +0000" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Dec 12 04:12:57 2025 +0000" }, "message": "Bump golang.org/x/net from 0.34.0 to 0.38.0 in /examples/basic_gazelle (#4530)\n\nBumps [golang.org/x/net](https://github.com/golang/net) from 0.34.0 to\n0.38.0.\n\u003cdetails\u003e\n\u003csummary\u003eCommits\u003c/summary\u003e\n\u003cul\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9\"\u003e\u003ccode\u003ee1fcd82\u003c/code\u003e\u003c/a\u003e\nhtml: properly handle trailing solidus in unquoted attribute value in\nforeign...\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/ebed060e8f30f20235f74808c22125fd86b15edd\"\u003e\u003ccode\u003eebed060\u003c/code\u003e\u003c/a\u003e\ninternal/http3: fix build of tests with GOEXPERIMENT\u003dnosynctest\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/1f1fa29e0a46fffe18c43a9da8daa5a0b180dfa9\"\u003e\u003ccode\u003e1f1fa29\u003c/code\u003e\u003c/a\u003e\npublicsuffix: regenerate table\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/12150816f701c912a32a376754ab28dd3878833a\"\u003e\u003ccode\u003e1215081\u003c/code\u003e\u003c/a\u003e\nhttp2: improve error when server sends HTTP/1\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/312450e473eae9f9e6173ad895c80bc5ea2f79ad\"\u003e\u003ccode\u003e312450e\u003c/code\u003e\u003c/a\u003e\nhtml: ensure \u0026lt;search\u0026gt; tag closes \u0026lt;p\u0026gt; and update tests\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/09731f9bf919b00b344c763894cd1920b3d96d90\"\u003e\u003ccode\u003e09731f9\u003c/code\u003e\u003c/a\u003e\nhttp2: improve handling of lost PING in Server\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/55989e24b972a90ab99308fdc7ea1fb58a96fef1\"\u003e\u003ccode\u003e55989e2\u003c/code\u003e\u003c/a\u003e\nhttp2/h2c: use ResponseController for hijacking connections\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/2914f46773171f4fa13e276df1135bafef677801\"\u003e\u003ccode\u003e2914f46\u003c/code\u003e\u003c/a\u003e\nwebsocket: re-recommend gorilla/websocket\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/99b3ae0643f9a2f9d820fcbba5f9e4c83b23bd48\"\u003e\u003ccode\u003e99b3ae0\u003c/code\u003e\u003c/a\u003e\ngo.mod: update golang.org/x dependencies\u003c/li\u003e\n\u003cli\u003e\u003ca\nhref\u003d\"https://github.com/golang/net/commit/85d1d54551b68719346cb9fec24b911da4e452a1\"\u003e\u003ccode\u003e85d1d54\u003c/code\u003e\u003c/a\u003e\ngo.mod: update golang.org/x dependencies\u003c/li\u003e\n\u003cli\u003eAdditional commits viewable in \u003ca\nhref\u003d\"https://github.com/golang/net/compare/v0.34.0...v0.38.0\"\u003ecompare\nview\u003c/a\u003e\u003c/li\u003e\n\u003c/ul\u003e\n\u003c/details\u003e\n\u003cbr /\u003e\n\n\n[![Dependabot compatibility\nscore](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name\u003dgolang.org/x/net\u0026package-manager\u003dgo_modules\u0026previous-version\u003d0.34.0\u0026new-version\u003d0.38.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)\n\nDependabot will resolve any conflicts with this PR as long as you don\u0027t\nalter it yourself. You can also trigger a rebase manually by commenting\n`@dependabot rebase`.\n\n[//]: # (dependabot-automerge-start)\n[//]: # (dependabot-automerge-end)\n\n---\n\n\u003cdetails\u003e\n\u003csummary\u003eDependabot commands and options\u003c/summary\u003e\n\u003cbr /\u003e\n\nYou can trigger Dependabot actions by commenting on this PR:\n- `@dependabot rebase` will rebase this PR\n- `@dependabot recreate` will recreate this PR, overwriting any edits\nthat have been made to it\n- `@dependabot merge` will merge this PR after your CI passes on it\n- `@dependabot squash and merge` will squash and merge this PR after\nyour CI passes on it\n- `@dependabot cancel merge` will cancel a previously requested merge\nand block automerging\n- `@dependabot reopen` will reopen this PR if it is closed\n- `@dependabot close` will close this PR and stop Dependabot recreating\nit. You can achieve the same result by closing it manually\n- `@dependabot show \u003cdependency name\u003e ignore conditions` will show all\nof the ignore conditions of the specified dependency\n- `@dependabot ignore this major version` will close this PR and stop\nDependabot creating any more for this major version (unless you reopen\nthe PR or upgrade to it yourself)\n- `@dependabot ignore this minor version` will close this PR and stop\nDependabot creating any more for this minor version (unless you reopen\nthe PR or upgrade to it yourself)\n- `@dependabot ignore this dependency` will close this PR and stop\nDependabot creating any more for this dependency (unless you reopen the\nPR or upgrade to it yourself)\nYou can disable automated security fix PRs for this repo from the\n[Security Alerts\npage](https://github.com/bazel-contrib/rules_go/network/alerts).\n\n\u003c/details\u003e\n\nSigned-off-by: dependabot[bot] \u003csupport@github.com\u003e\nCo-authored-by: dependabot[bot] \u003c49699333+dependabot[bot]@users.noreply.github.com\u003e\nCo-authored-by: David Zbarsky \u003cdzbarsky@gmail.com\u003e" }, { "commit": "d1ff6e2ff4a8292bdc42e3c983bd8028dceab33c", "tree": "ce52107c4bf3116430a8dd2599fb8a817b8cffbf", "parents": [ "7ad9f01e6bc5b24ec39b59c47f019d723d82200a" ], "author": { "name": "peter woodman", "email": "peter.woodman@mongodb.com", "time": "Wed Dec 10 15:06:47 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Dec 10 21:06:47 2025 +0100" }, "message": "expand make variables in x_defs (#4533)\n\n**What type of PR is this?**\nFeature\n\n**What does this PR do? Why is it needed?**\nThis performs make variable substitution on the values of x_defs.\n\nContext: trying to allow users of a ruleset to customize the tagged\nversion of a binary generated inside the ruleset with a value from a\nruleset-defined string flag- this is, to my understanding, the only way\nto get this string into the analysis context.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4308" }, { "commit": "7ad9f01e6bc5b24ec39b59c47f019d723d82200a", "tree": "ee951f9be140f483a1a8878363a3b92a34db72b2", "parents": [ "9f687046a90f9c7f382d0d928b8d7a2e4aabc9ca" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Sat Dec 06 00:30:34 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sat Dec 06 00:30:34 2025 -0500" }, "message": "refactor: Remove next batch of WORKSPACE content (#4531)\n\n**What type of PR is this?**\nModernize the repo\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "9f687046a90f9c7f382d0d928b8d7a2e4aabc9ca", "tree": "c24994870b2dfd5624d13963d3009fa435cd3bec", "parents": [ "42f3f48d291b155abd9152aff04091c873ee52d7" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Thu Dec 04 14:57:14 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Dec 04 19:57:14 2025 +0000" }, "message": "refactor: Remove more workspace content (#4529)\n\n**What type of PR is this?**\nworkspace cleanup\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "42f3f48d291b155abd9152aff04091c873ee52d7", "tree": "b76bdcec59ad522b5699734a4cb3424877b3f9a9", "parents": [ "db94744a42f82beba305e46459f03ac29fed8bae" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Thu Dec 04 14:23:32 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Dec 04 14:23:32 2025 -0500" }, "message": "Start migrating rules_go workspace to bzlmod (#4526)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\n\u003e Uncomment one line below and remove others.\n\u003e\n\u003e Bug fix\n\u003e Feature\n\u003e Documentation\n\u003e Other\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "db94744a42f82beba305e46459f03ac29fed8bae", "tree": "e65c3e9771b38f5503b1ae6834f8ca0f51a129ec", "parents": [ "25f9eca5ae855c1c4dd2e80b2c9ce2748547cd6a" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Mon Dec 01 23:57:41 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Dec 02 04:57:41 2025 +0000" }, "message": "Rename host_go{arch,os} to exec_ (#4525)\n\nThis is technically more correct as these may be selected on non-host\nexec platforms" }, { "commit": "25f9eca5ae855c1c4dd2e80b2c9ce2748547cd6a", "tree": "afef5c63199ec7a79c1b59a3f0215230bcb816c7", "parents": [ "e65b564852be848ac2c36d6d0be3af10ea04e77c" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Mon Dec 01 23:24:54 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Dec 01 23:24:54 2025 -0500" }, "message": "Exclude cgotest from stdlib build (#4524)\n\nIt didn\u0027t build for me with a zig toolchain, but anyway we shouldn\u0027t\nneed to build this for user code\n\n```\n# net/internal/cgotest\nbazel-out/darwin_arm64-opt-exec-ST-6c94b0e707c0/bin/external/rules_go+/stdlib_/src/net/internal/cgotest/resstate.go:10:10: fatal error: \u0027resolv.h\u0027 file not found\n 10 | #include \u003cresolv.h\u003e\n```\n\n**What type of PR is this?**\nPerf tweak?" }, { "commit": "e65b564852be848ac2c36d6d0be3af10ea04e77c", "tree": "cf03ba87784ac694409657aeb1e26f7e952061ba", "parents": [ "1be32b09df93f20a7aac57e78ca5193ce0a892c6" ], "author": { "name": "BlueC0re", "email": "638422+bluec0re@users.noreply.github.com", "time": "Fri Nov 28 22:42:13 2025 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Nov 28 22:42:13 2025 +0100" }, "message": "Update Coverage link in README.rst (#4523)\n\n**What type of PR is this?**\n\nDocumentation\n\n**What does this PR do? Why is it needed?**\n\nLink was pointing to the Chinese version, while the readme itself is in\nenglish." }, { "commit": "1be32b09df93f20a7aac57e78ca5193ce0a892c6", "tree": "7b5d615c8048e207a646d63a62eaa2d20f71bc5a", "parents": [ "2c439988276d777de8ebffd92b38a0e92e7aa1f0" ], "author": { "name": "Fionera", "email": "fionera@fionera.de", "time": "Mon Nov 24 17:12:31 2025 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Nov 24 08:12:31 2025 -0800" }, "message": "go/tools/gopackagesdriver: don\u0027t filter GoFiles for tags (#4519)\n\nGoFiles should contain all files, ignoring any build tags" }, { "commit": "2c439988276d777de8ebffd92b38a0e92e7aa1f0", "tree": "1ceccf744a6619a052d3f63ab4d9c5faa4f7007d", "parents": [ "38f9c871ebce1e1b27f4d1fea7120e9cf430d2e6" ], "author": { "name": "Alex Tercete", "email": "alextercete@gmail.com", "time": "Tue Nov 18 19:46:25 2025 +0000" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Nov 18 20:46:25 2025 +0100" }, "message": "Default link mode to PIE on supported platforms (#4481)\n\n**What type of PR is this?**\nFeature\n\n**What does this PR do? Why is it needed?**\n\nWe now choose `pie` over `normal` when `linkmode` is omitted (or\nexplicitly set to `auto`) and target supports it. This mirrors the\nbehaviour of `go build`.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4478" }, { "commit": "38f9c871ebce1e1b27f4d1fea7120e9cf430d2e6", "tree": "30c87c0734a51486a6d27675543b4899712cdefd", "parents": [ "f836fe6eb49c820e2599547b02aecd43206403d5" ], "author": { "name": "DolceTriade", "email": "hmodi@aviatrix.com", "time": "Fri Nov 14 22:51:29 2025 -0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sat Nov 15 07:51:29 2025 +0100" }, "message": "proto: Pass in the plugin as tools to preserve runfiles (#4514)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nThe proto plugin should preserve runfiles so that bazel targets that\nrely on external data can find them. It does this by by running the\nplugin as a tool, which is correct because plugins are expected to be\nbuilt and run using the exec configuration.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4513" }, { "commit": "f836fe6eb49c820e2599547b02aecd43206403d5", "tree": "8c27c0839bb4a4a6539078d4609f9dcc12a5056e", "parents": [ "f352bcdd05a0e498af6bcb3e715a6fec830adfc5" ], "author": { "name": "Corentin Kerisit", "email": "corentin.kerisit@gmail.com", "time": "Fri Nov 14 22:24:24 2025 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Nov 14 22:24:24 2025 +0100" }, "message": "Transition request_nogo to False for cgo_context_data (#4512)\n\nThis is to avoid cc toolchain dependencies in different configurations.\n\nI feel this is fine since `cgo_context_data` only calls cc toolchain\nAPIs.\n\nThe specific case which triggered this PR is\nhttps://github.com/cerisier/toolchains_llvm_bootstrapped/issues/45#issuecomment-3533067960\nwhere paths provided by CC toolchain would end up being included\nmultiple times in the linker invocation but with different\nconfiguration-specific output directory, one of which was non existent\nin the linker action sandbox.\n\nLooking at the difference between the 2 configurations shows:\n```\nFragmentOptions user-defined {\n @@rules_go+//go/private:request_nogo: null, true\n}\n```\n\nwhich felt non necessary for CGO CC toolchain dependencies." }, { "commit": "f352bcdd05a0e498af6bcb3e715a6fec830adfc5", "tree": "836ee5ff43a4b8d3042acf90df354127a1f53bcd", "parents": [ "b3e12d797150cdc36f27e72f52f6a5c752762641" ], "author": { "name": "Steven Dee", "email": "mrdomino@gmail.com", "time": "Sat Nov 08 14:45:41 2025 -0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sat Nov 08 22:45:41 2025 +0000" }, "message": "Document Gazelle `go_tools.bzl` functionality (#4496)\n\n**What type of PR is this?**\n\n\u003e Documentation\n\n**What does this PR do? Why is it needed?**\n\nDocuments the Gazelle `go_tools.bzl` feature added in\nbazel-contrib/bazel-gazelle#2215.\n\n**Which issues(s) does this PR fix?**\n\nbuildbuddy-io/bazel_env.bzl#68" }, { "commit": "b3e12d797150cdc36f27e72f52f6a5c752762641", "tree": "b93749a1dc31a5abbaf8d9356ab06e6b9fd3c967", "parents": [ "3fe89b8093e47f2edc81d69f8655c2717db6bc5c" ], "author": { "name": "Keith Smiley", "email": "keithbsmiley@gmail.com", "time": "Fri Nov 07 11:51:19 2025 -0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Nov 07 19:51:19 2025 +0000" }, "message": "Add missing load statements (#4508)\n\nThis is required for compatibility with bazel @ HEAD. Done with:\n`buildifier --lint\u003dfix -r .`" }, { "commit": "3fe89b8093e47f2edc81d69f8655c2717db6bc5c", "tree": "203570220d662f6ee116d2abdaf86ca955cef6aa", "parents": [ "0b46a620434f253eeff973a9ab22fc58a8c8efe2" ], "author": { "name": "ffgan", "email": "sudoemt@gmail.com", "time": "Fri Nov 07 16:54:10 2025 +0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Nov 07 08:54:10 2025 +0000" }, "message": "Add `riscv64` into `BAZEL_GOARCH_CONSTRAINTS` (#4507)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nFix some Bazel matching issues on riscv64\n\n**Which issues(s) does this PR fix?**\n\nFixes #4053\n\n**Other notes for review**\n\nThe riscv64 architecture has been widely developed and adopted recently,\nand optimizing support for riscv64 is very meaningful as it can provide\nbetter riscv64 support for downstream users.\n\nFor example, when I was using `bazeldnf`, due to some limitations in the\ncurrent repository, I couldn\u0027t use `bazeldnf` directly. The specific\nreason is this:\nhttps://github.com/rmohr/bazeldnf/blob/main/bazeldnf/platforms.bzl. This\ndepends on the current repository\u0027s `BAZEL_GOARCH_CONSTRAINTS`, which\ncurrently lacks riscv64 support, so the riscv64 version of bazeldnf\ncannot be used directly. If this PR is merged and released, downstream\nusers will be able to get good riscv64 support.\n\nA PR quite similar to this one is\nhttps://github.com/bazel-contrib/rules_go/pull/3336. I think the\nsituation with riscv64 is quite similar to that case. The Go upstream\nalso provides good support for riscv64.\n\n\n**Other Info**\nCo-authored by: nijincheng@iscas.ac.cn;" }, { "commit": "0b46a620434f253eeff973a9ab22fc58a8c8efe2", "tree": "da0721456194315254c30cf337f442fecede2d2e", "parents": [ "dfed61bf442bf1e331a76536bc773e67c27519eb" ], "author": { "name": "Jay Conrod", "email": "jay@engflow.com", "time": "Tue Nov 04 11:52:25 2025 -0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Nov 04 19:52:25 2025 +0000" }, "message": "docs: copy editor setup instructions from wiki to docs/editors.md (#4504)\n\n**What type of PR is this?**\n\n\u003e Documentation\n\n**What does this PR do? Why is it needed?**\n\nAnd link from README.rst.\n\nGitHub wikis seem to be downranked pretty hard by Google, so these\ninstructions haven\u0027t been very visible. Linking from the README should\nhelp.\n\n**Which issues(s) does this PR fix?**\n\nn/a\n\n**Other notes for review**\n\nFor some reason, the vim instructions were in docs/go/editors/vim.md\ninstead of in the wiki. I\u0027ve squashed them into a new section here." }, { "commit": "dfed61bf442bf1e331a76536bc773e67c27519eb", "tree": "f46716d74d55fda8b46d3844d843535689d0ccd6", "parents": [ "cdf4651b4d8c34a4cb2c91939d8ef6b7130cd3c9" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Tue Nov 04 18:51:50 2025 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Nov 04 17:51:50 2025 +0000" }, "message": "Fix BCR test module for Bazel 9 (#4503)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nAlso run all tests against the latest release candidate for each major\nrelease to catch issues early.\n\n\n**Which issues(s) does this PR fix?**\n\nWork towards\nhttps://github.com/bazelbuild/bazel-central-registry/issues/6402\n\n**Other notes for review**" }, { "commit": "cdf4651b4d8c34a4cb2c91939d8ef6b7130cd3c9", "tree": "67880b12cd1c1e2cd89d7d6e3262d133ccb9be14", "parents": [ "b764503a883be0fc0738f64fb6c6d4d07b59fb9c" ], "author": { "name": "Jeff Hodges", "email": "jeff@somethingsimilar.com", "time": "Tue Nov 04 07:50:53 2025 -0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Nov 04 15:50:53 2025 +0000" }, "message": "remove .vscode and gitignore it (#4498)\n\n**What type of PR is this?**\n\nOther\n\n**What does this PR do? Why is it needed?**\n\nThe .vscode directory isn\u0027t meant to be checked in like this, and causes\nchurn that vscode users have to remove before sending PRs. We remove it,\nadd it to .gitignore so future folks don\u0027t accidentally check it in.\nFolks can check out the more general Editor setup wiki page for\ninstructions.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4497.\n" }, { "commit": "b764503a883be0fc0738f64fb6c6d4d07b59fb9c", "tree": "fae6698480785d9447db450fae527ca605afca5e", "parents": [ "30a6f8da464b461446b376c9b7f7e78111772024" ], "author": { "name": "Jeff Hodges", "email": "jeff@somethingsimilar.com", "time": "Mon Nov 03 22:42:32 2025 -0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Nov 04 07:42:32 2025 +0100" }, "message": "correct macOS Tahoe 26 build via apple_support (#4500)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nAll of rules_go tests were failing on macOS Tahoe 26 due to `missing\nLC_UUID load command` in the clang binary built and in other tools. Many\ntools from Go to bazel itself have had to drop various workarounds for\nthese kinds of linker problems in the run-up to macOS Tahoe (see\nhttps://github.com/bazelbuild/apple_support/commit/44c43c715a and\nhttps://github.com/bazelbuild/bazel/pull/27014)\n\nTo fix this, we bump the version of build_bazel_apple_support (a.k.a.\napple_support in Bazel Central Registry) to 1.24.3 in WORKSPACE. We also\nhave to move the build_bazel_apple_support dependency above the\nllvm_toolchain call in order to make sure that version is actually used.\n\nIt\u0027s possible we should also upgrade the llvm_toolchain to something\nmore modern to handle some of our deps problems. The current llvm used\nby rules_go is 8.0.0 and is from 2019. The latest llvm version that\ntoolchains_llvm supports in its latest release 1.5.0 is llvm 21.1.0.\n\n\n**Which issues(s) does this PR fix?**\n\nFixes #4499" }, { "commit": "30a6f8da464b461446b376c9b7f7e78111772024", "tree": "7e7fb1a8da69267c1b3a772ad3cb10e21b91af3e", "parents": [ "3c293b09f65f8f6b60eec620f471f75d992fd9f0" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Mon Nov 03 20:50:51 2025 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Nov 03 20:50:51 2025 +0100" }, "message": "Reland \"go_sdk: store SDK filenames and hashes in lockfile facts\" (#4493)\n\n**What type of PR is this?**\n\nFeature\n\n**What does this PR do? Why is it needed?**\n\nThis moves the download of the \"all versions\" JSON, which can\u0027t hit the\nrepository cache, from each individual `go_download_sdk` into the module\nextension. If the current version of Bazel supports facts, this\ninformation will also be persisted in the lockfile, allowing for truly\nairgapped builds assuming an up-to-date download (formerly repository)\ncache.\n\nThis is a reland of #4393 with the following improvements:\n* Adapted to the more limited facts API that actually got merged.\n* Prefetching of SDK hashes is now performed on a best-effort basis so\nthat otherwise airgapped builds that provide SDK hashes do not result in\nfailures.\n\nSee https://github.com/bazelbuild/bazel/pull/26198 for the PR that added\nfacts support to Bazel.\n\n**Which issues(s) does this PR fix?**\n\nFixes #3945 \n\n**Other notes for review**\n\nYou can verify that this works by running `bazel mod show_repo\n@go_default_sdk` in the BCR test repo." }, { "commit": "3c293b09f65f8f6b60eec620f471f75d992fd9f0", "tree": "0e15a3ed849be088a921d2c578b0a9164b186a49", "parents": [ "f7a7c5d7acdf56c82afb0c9a38b019b8106da8ee" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Thu Oct 30 17:57:34 2025 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Oct 30 16:57:34 2025 +0000" }, "message": "Update Bazel to 7.7.0 (#4492)\n\n**What type of PR is this?**\n\nDep update\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "f7a7c5d7acdf56c82afb0c9a38b019b8106da8ee", "tree": "39c54651d0b04163d0c4c422d9491b61468eaa56", "parents": [ "3ea65d884caedfae1036cdc8d0a758da900dc18b" ], "author": { "name": "Keith Smiley", "email": "keithbsmiley@gmail.com", "time": "Wed Oct 29 22:14:04 2025 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Oct 30 06:14:04 2025 +0100" }, "message": "Fix _xcode_config attribute for bazel 9.x (#4491)\n\nThis label was removed @ HEAD\nhttps://github.com/bazelbuild/bazel/commit/873b036afbf77ede4588aeaa95b119fb486accef#diff-063fdd9649746cd022e13edf6ac43956dfd4e55c5420847d00162557e7697d93L68\n\nThis is how it is accessed in rules_apple / apple_support" }, { "commit": "3ea65d884caedfae1036cdc8d0a758da900dc18b", "tree": "eb768ff5fe4708e4d9447e03f90504d85a909341", "parents": [ "c84ee399cee70112a625dfa19cdb206a968c0194" ], "author": { "name": "Jay Conrod", "email": "jay@engflow.com", "time": "Fri Oct 24 11:11:18 2025 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Oct 24 11:11:18 2025 -0700" }, "message": ".bazelci/presubmit.yml: run BCR tests with multiple Bazel versions (#4490)\n\n**What type of PR is this?**\n\n\u003e Test\n\n**What does this PR do? Why is it needed?**\n\nOn presubmit, run the BCR test with multiple Bazel versions. This helps\nus\ncatch issues before a release.\n\n**Which issues(s) does this PR fix?**\n\nn/a\n\n**Other notes for review**" }, { "commit": "c84ee399cee70112a625dfa19cdb206a968c0194", "tree": "b0d9beeaaa9efa6905f7e552fd7779d2d56c2fde", "parents": [ "4ded8262d3aecfc286dcb4277f66b680b6fe148b" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Fri Oct 24 11:41:45 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Oct 24 15:41:45 2025 +0000" }, "message": "Only build cmd/internal/cov package on go1.20 where it exists (#4489)\n\n**What type of PR is this?**\nbug fix\n\n**What does this PR do? Why is it needed?**\nbuild_stdlib wouldn\u0027t work on \u003cgo1.20 \n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "4ded8262d3aecfc286dcb4277f66b680b6fe148b", "tree": "a6e5e91b2da2e3be0028009b3cd6f85304de4e9f", "parents": [ "e3ec0294d47f8d5d71f2e9cac57582d8be59e8dc" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Fri Oct 24 10:32:18 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Oct 24 14:32:18 2025 +0000" }, "message": "Make it easier to debug integration tests (#4488)\n\nBy teeing the output here, something like `bazel test\ntests/core/from_go_mod_file:all --test_output\u003dstreamed` will now stream\nthe underlying build progress as one would hope" }, { "commit": "e3ec0294d47f8d5d71f2e9cac57582d8be59e8dc", "tree": "bd1a33e29bcf7269946828d2ac828f6131aa17dd", "parents": [ "a06038ce582fb409774c3a5e6b8db79324568363" ], "author": { "name": "Jay Conrod", "email": "jay@engflow.com", "time": "Thu Oct 23 13:42:45 2025 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Oct 23 20:42:45 2025 +0000" }, "message": "tests/bcr: don\u0027t require MODULE.bazel.lock (#4485)\n\n**What type of PR is this?**\n\n\u003e Bug fix\n\n**What does this PR do? Why is it needed?**\n\nThis is tested with different versions of Bazel, so the lock file is not\nstable.\n\n**Which issues(s) does this PR fix?**\n\nFor #4483\n\n**Other notes for review**" }, { "commit": "a06038ce582fb409774c3a5e6b8db79324568363", "tree": "9a1462331b605c4973b83d00c31d66c1b7f97eb1", "parents": [ "e9352e93297a3676c6a8fd6669a936c92139b26c" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Thu Oct 23 21:54:54 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Oct 23 19:54:54 2025 +0000" }, "message": "Add missing `bazel_dep` to BCR test module (#4486)\n\nThis is required with Bazel 8, which doesn\u0027t expose the `platforms`\nWORKSPACE suffix repo by default.\n98940c33e64548d13314a372bdc0103732407dc3 forgot to add it." }, { "commit": "e9352e93297a3676c6a8fd6669a936c92139b26c", "tree": "1eef15abdb518867037603ab4d7334f12231e726", "parents": [ "4f25f4411288614b3425b98720b92fb5d2e272f4" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Thu Oct 23 20:33:08 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Oct 23 18:33:08 2025 +0000" }, "message": "Fix pure mode detection (#4470)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\n* `go_proto_library`, `nogo`, and `stdlib` may use cgo and thus need the\nrelevant attributes to detect the availability of a C++ toolchain.\n* All rules should continue to use a pure build if the `pure` flag is\nturned off or the toolchain turns off cgo via a constraint.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4447\n\n**Other notes for review**" }, { "commit": "4f25f4411288614b3425b98720b92fb5d2e272f4", "tree": "adeab4ef73f6b9f3421d3043a86500aa1d8c255a", "parents": [ "74199c92e20399b6ef46684b2c6fdd94b50a7892" ], "author": { "name": "Jay Conrod", "email": "jay@engflow.com", "time": "Thu Oct 23 07:53:16 2025 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Oct 23 07:53:16 2025 -0700" }, "message": "Commit MODULE.bazel.lock files (#4484)\n\n**What type of PR is this?**\n\n\u003e Other\n\n**What does this PR do? Why is it needed?**\n\nThis ensures rules_go developers always see the same bits when\ndownloading\nfiles. We should see a security error if a module version changes\nupstream.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4483\n\n**Other notes for review**" }, { "commit": "74199c92e20399b6ef46684b2c6fdd94b50a7892", "tree": "5f522b2d4e23344ddbe26652ca96d6e35d322cc2", "parents": [ "56929daa40a419a4e538d2c73bb82c05148793a8" ], "author": { "name": "Troy Benson", "email": "troybensonsa@gmail.com", "time": "Thu Oct 09 15:15:54 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Oct 09 22:15:54 2025 +0200" }, "message": "use sh_toolchain to get a truer path to bash (#4465)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\n\u003e Uncomment one line below and remove others.\n\u003e\n\u003e Bug fix\n\n**What does this PR do? Why is it needed?**\n\nUse the `sh_toolchain` to find the path to `bash` instead of bazel.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4352 \n\n**Other notes for review**" }, { "commit": "56929daa40a419a4e538d2c73bb82c05148793a8", "tree": "8efc899cdf520b9b78982f2278254f57b146a0a1", "parents": [ "28ce0415f944ea5098fd30452fa320aae5142a49" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Wed Oct 08 17:04:42 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Oct 08 23:04:42 2025 +0200" }, "message": "Allow collecting coverage for go_binary executed as child process (#4461)\n\n**What type of PR is this?**\nfeature\n\n**What does this PR do? Why is it needed?**\nAdds a shim to go_binary when built in coverage mode to collect coverage\ninfo. Useful for integration testing.\n\n**Other notes for review**\nAdded integration test\n\nManual testing:\n```\nbazel coverage foo:all --cache_test_results\u003dno --instrument_test_targets --instrumentation_filter\u003d//... --combined_report\u003dlcov\ngenhtml -o coverage_html /private/var/tmp/_bazel_dzbarsky/2c76d2042b2c36d4458efe14b865e618/execroot/io_bazel_rules_go/bazel-out/darwin_arm64-fastbuild/testlogs/foo/foo_test/coverage.dat \u0026\u0026 open coverage_html/index.html\n```\n\u003cimg width\u003d\"968\" height\u003d\"320\" alt\u003d\"image\"\nsrc\u003d\"https://github.com/user-attachments/assets/b2b7ef3e-bd8f-46ff-9fa8-66581b735f24\"\n/\u003e\n\u003cimg width\u003d\"669\" height\u003d\"286\" alt\u003d\"image\"\nsrc\u003d\"https://github.com/user-attachments/assets/55b24983-67b4-490a-b9ec-85dfef76470c\"\n/\u003e\n\nFixes https://github.com/bazel-contrib/rules_go/issues/3513" }, { "commit": "28ce0415f944ea5098fd30452fa320aae5142a49", "tree": "7a8478ba51ba9d068efc65d1828f31cf8f8df18c", "parents": [ "807c5dec477d842618f9d9a36d0fcde4debdcf80" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Tue Oct 07 17:21:23 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Oct 07 15:21:23 2025 +0000" }, "message": "Cover all cases for rpath generation (#4471)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nThis is based on the corresponding logic in rules_cc.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4451\n\n**Other notes for review**" }, { "commit": "807c5dec477d842618f9d9a36d0fcde4debdcf80", "tree": "eef8693287faf814a0162e01f633da8c45f8c8ef", "parents": [ "42969ba3cf411cb0aba1044eb83f95298964e1b3" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Tue Oct 07 11:02:46 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Oct 07 09:02:46 2025 +0000" }, "message": "Fix build failures on latest macOS (#4472)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "42969ba3cf411cb0aba1044eb83f95298964e1b3", "tree": "a8349d7e85c8f02ccaf5b31fae9312e25ae5d1be", "parents": [ "7ef8fb1bc91d2ea70a53fe123ea0556acb3bf87b" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Sat Oct 04 16:07:49 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sat Oct 04 20:07:49 2025 +0000" }, "message": "A bit of starlark micro-optimization (#4468)\n\n**What type of PR is this?**\nCleanup/perf improvement\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "7ef8fb1bc91d2ea70a53fe123ea0556acb3bf87b", "tree": "fb8e2e4c7b60fa88cbdd604cf7232102fa61ed7c", "parents": [ "74e87e63a26639d92b760f5c64fb0a8e5d917079" ], "author": { "name": "Rafik Salama", "email": "r@rafiksalama.com", "time": "Thu Oct 02 14:23:55 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Oct 02 12:23:55 2025 +0000" }, "message": "Allow environment variables to override `go_env` in `@rules_go//go` (#4464)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nThis PR fixes an inconsistency in how environment variables interact\nwith `go_env`. Prior to this PR, environment variables could override\nsettings in `go_env` within `go_repository`, but could not override\n`go_env` when invoking `@rules_go//go`.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4462\n\n**Other notes for review**" }, { "commit": "74e87e63a26639d92b760f5c64fb0a8e5d917079", "tree": "dc9a4214df57e00f3440751e46ebfe02a0f7b007", "parents": [ "3c2b00b5b2b596934aee5482073d758c7cab1d44" ], "author": { "name": "Fionera", "email": "fionera@fionera.de", "time": "Fri Sep 26 23:07:10 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Sep 26 21:07:10 2025 +0000" }, "message": "Add provides GoInfo to source and library rules (#4458)\n\n**What type of PR is this?**\nBug fix\n\n**What does this PR do? Why is it needed?**\nAdds the missing `provides` tag to go_library and go_source\n\n**Which issues(s) does this PR fix?**\n\n**Other notes for review**" }, { "commit": "3c2b00b5b2b596934aee5482073d758c7cab1d44", "tree": "eff8dc5a111db9c93046443fc49df3cc3c8d88a0", "parents": [ "b978e655d2b935ae4973520cea5b2ad0f732ac1a" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Thu Sep 25 13:26:40 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Sep 25 17:26:40 2025 +0000" }, "message": "Exclude jsontest package from stdlib builder (#4457)\n\n**What type of PR is this?**\nBug fix\n\n**What does this PR do? Why is it needed?**\n`src/encoding/json/internal/jsontest` package in stdlib doesn\u0027t compile\nbecause we excluded testdata. It\u0027s only used in tests, so we can tweak\nour exclude patterns to skip this package as well.\n\nUnfortunately I see another issue that prevents me from verifying this\nworks\n```\nERROR: /private/var/tmp/_bazel_dzbarsky/f02363070bdd15ed6c1c5741e4a6e4c0/external/rules_go+/BUILD.bazel:42:7: GoStdlib external/rules_go+/stdlib_/pkg failed: (Exit 1): builder failed: error executing GoStdlib command (from target @@rules_go+//:stdlib) bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/rules_go++go_sdk+go_sdk/builder_reset/builder stdlib -sdk external/rules_go++go_sdk+go_sdk -goroot external/rules_go++go_sdk+go_sdk ... (remaining 10 arguments skipped)\n\nUse --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging\ngo: unknown GOEXPERIMENT coverageredesign\nstdlib: error running subcommand external/rules_go++go_sdk+go_sdk/bin/go: exit status 2\n```\n\n**Which issues(s) does this PR fix?**\n\nFixes #4428\n\n**Other notes for review**" }, { "commit": "b978e655d2b935ae4973520cea5b2ad0f732ac1a", "tree": "fea0851aa53f3ba95af1c0622529120524fcf9bf", "parents": [ "24b493ed86a5fe329334cf7dda50d5a00f24d512" ], "author": { "name": "Philipp Stephani", "email": "p.stephani2@gmail.com", "time": "Tue Sep 23 15:53:39 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Sep 23 13:53:39 2025 +0000" }, "message": "Remove spurious second-level heading (#4456)\n\nGo docstrings only recognize one level of headings, cf.\nhttps://go.dev/doc/comment#headings.\n\n**What type of PR is this?**\n\nDocumentation" }, { "commit": "24b493ed86a5fe329334cf7dda50d5a00f24d512", "tree": "7f678547d59f5aa1543c37a724ebbe2807b9e383", "parents": [ "dd7b9c79d4c1f6e78c883432f5d149744ee5dadb" ], "author": { "name": "Philipp Stephani", "email": "p.stephani2@gmail.com", "time": "Tue Sep 23 15:06:19 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Sep 23 13:06:19 2025 +0000" }, "message": "Formatting improvements for docstrings in the bazel package (#4455)\n\nAdd some links, and remove Markdown syntax.\n\n**What type of PR is this?**\n\nDocumentation" }, { "commit": "dd7b9c79d4c1f6e78c883432f5d149744ee5dadb", "tree": "c357f97443a5b8930ead718ee7fff38992a53aae", "parents": [ "31528e0b460057d85e4794b3f057cfbd2811a5b9" ], "author": { "name": "Philipp Stephani", "email": "p.stephani2@gmail.com", "time": "Tue Sep 23 08:41:58 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Sep 23 06:41:58 2025 +0000" }, "message": "Minor formatting improvements for docstrings (#4453)\n\n- Use doclinks where the docstrings refer to other symbols.\n- Don’t use Markdown, Godoc doesn’t render it.\n\n**What type of PR is this?**\n\nDocumentation\n\n**What does this PR do? Why is it needed?**\n\nMinor formatting improvements" }, { "commit": "31528e0b460057d85e4794b3f057cfbd2811a5b9", "tree": "c0726ed86295ee670911acd9412c9d0841ab13a7", "parents": [ "42a97e95154170f6be04cbbdbe87808016e4470f" ], "author": { "name": "Philipp Stephani", "email": "p.stephani2@gmail.com", "time": "Tue Sep 23 07:53:23 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Sep 23 05:53:23 2025 +0000" }, "message": "Run gofmt on runfiles code (#4452)\n\n**What type of PR is this?**\n\nOther\n\n**What does this PR do? Why is it needed?**\n\nJust reformat the code using gofmt." }, { "commit": "42a97e95154170f6be04cbbdbe87808016e4470f", "tree": "52514c88b27a3d89effdafaec617bd4e71301594", "parents": [ "0177eb1e4451b40e6a486c100202fceb770905c5" ], "author": { "name": "Simon Cousineau", "email": "simon.cousineau99@gmail.com", "time": "Thu Sep 18 10:14:31 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Sep 18 14:14:31 2025 +0000" }, "message": "fix(contributing): Fix readme reference (#4450)\n\n**What type of PR is this?**\n\nDocumentation\n\n**What does this PR do? Why is it needed?**\n\nFixes Contributing.md reference to README. The file is no longer a `.md`\nfile, it is now a `.rst` file.\n\n**Which issues(s) does this PR fix?**\n\nFixes # \n\n**Other notes for review**\n\nNone." }, { "commit": "0177eb1e4451b40e6a486c100202fceb770905c5", "tree": "d5bd48df5e356e5b2aa6f8bc3fa3ce4a0dd786df", "parents": [ "0683029b61d4e52dae7e7016e29143d764b02a79" ], "author": { "name": "armandomontanez", "email": "montanez.armando.l@gmail.com", "time": "Mon Sep 15 13:33:39 2025 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Sep 15 20:33:39 2025 +0000" }, "message": "Add --warning-suppression-mappings to cgoAbsEnvFlags (#4448)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nSince `--warning-suppression-mappings` points to a file path, it doesn\u0027t\nwork with the additional sandboxing go introduces. This change adds the\nflag to `cgoAbsEnvFlags` to allow it to work during cgo compilation." }, { "commit": "0683029b61d4e52dae7e7016e29143d764b02a79", "tree": "7b067b9ac0a877f2f36330a66c1ea779a2ced401", "parents": [ "a65c1acd04ce48b869e970113d6409c6146c04ec" ], "author": { "name": "Alexandre Rostovtsev", "email": "tetromino@gmail.com", "time": "Thu Sep 11 15:27:11 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Sep 11 19:27:11 2025 +0000" }, "message": "Fix Stardoc in repos which use rules_go with Bazel 8+ (#4446)\n\nFixes https://github.com/bazel-contrib/rules_go/issues/4394\n\nRequires bumping rules_cc dep (and making it a dep for legacy WORKSPACE\nusers).\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nFixes Stardoc API doc generation when using Bazel 8 for .bzl files in\nrepos which transitively depend upon rules_go\n\n**Which issues(s) does this PR fix?**\n\nFixes #4394 and https://github.com/bazelbuild/stardoc/issues/300\n\n**Other notes for review**\n\nYou can test the code via\n\n```bash\ncd ..\nmkdir test\ncd test\ncat \u003eMODULE.bazel \u003c\u003cEOF\nbazel_dep(name \u003d \"rules_go\", version \u003d \"0.57.0\")\nlocal_path_override(module_name \u003d \"rules_go\", path \u003d \"../rules_go\")\nbazel_dep(name \u003d \"stardoc\", version \u003d \"0.8.0\")\nbazel_dep(name \u003d \"bazel_skylib\", version \u003d \"1.8.1\")\nEOF\n\ncat \u003eBUILD \u003c\u003cEOF\nload(\"@bazel_skylib//:bzl_library.bzl\", \"bzl_library\")\nload(\"@stardoc//stardoc:stardoc.bzl\", \"stardoc\")\n\nbzl_library(\n name \u003d \"my_rule\",\n srcs \u003d [\"my_rule.bzl\"],\n visibility \u003d [\"//visibility:public\"],\n deps \u003d [\"@rules_go//go:def\"],\n)\n\nstardoc(\n name \u003d \"my_rule_docs\",\n out \u003d \"my_rule.md\",\n input \u003d \"my_rule.bzl\",\n deps \u003d [\":my_rule\"],\n)\nEOF\n\ncat \u003emy_rule.bzl \u003c\u003cEOF\nload(\"@rules_go//go:def.bzl\", \"go_test\")\n\ndef go_helper_test(name, **kwargs):\n \"\"\"A helper function to create a Go test target with specific attributes.\"\"\"\n go_test(\n name \u003d name,\n srcs \u003d [\"test_helper.go\"],\n embed \u003d [\":helper_lib\"],\n **kwargs\n )\nEOF\n\nbazelisk build my_rule_docs\n```\n\nDo you want an integration test in rules_go which does this? I didn\u0027t\nadd one because I didn\u0027t want to introduce a new dependency on Stardoc\nor mess with existing .bazelversion files." }, { "commit": "a65c1acd04ce48b869e970113d6409c6146c04ec", "tree": "493b742d7e5b134b9474ab8f5be1d77381697b2b", "parents": [ "20f7e2bb45dfbd6630f7ce36ad62cb9001a7e2f5" ], "author": { "name": "Tom Forbes", "email": "tom@tomforb.es", "time": "Tue Sep 09 21:03:04 2025 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Sep 09 22:03:04 2025 +0200" }, "message": "Update bazel_dep versions in bzlmod.md (#4445)\n\n**What type of PR is this?**\nDocumentation\n\n**What does this PR do? Why is it needed?**\n\nThe older versions specified in the documentation don\u0027t work with\n`go_work`, which leads to confusing errors" }, { "commit": "20f7e2bb45dfbd6630f7ce36ad62cb9001a7e2f5", "tree": "53f7cf3c64844e106ad8a983a629ba2eec2ac65f", "parents": [ "2d297e9c50cb33ffedc22c566c7767f10db1990c" ], "author": { "name": "Andrei Reshetkov", "email": "andrew-199@ya.ru", "time": "Fri Sep 05 19:46:38 2025 +0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Sep 05 19:46:38 2025 +0500" }, "message": "Issue 1486: cgo: fix C++ dynamic initialization of static variables when using alwayslink \u003d True (#4438)\n\n\u003c!-- Thanks for sending a PR! Before submitting:\n\n1. If this is your first PR, please read CONTRIBUTING.md and sign the\nCLA\n first. We cannot review code without a signed CLA.\n2. Please file an issue *first*. All features and most bug fixes should\nhave\nan associated issue with a design discussed and decided upon. Small bug\n fixes and documentation improvements don\u0027t need issues.\n3. New features and bug fixes must have tests. Documentation may need to\nbe updated. If you\u0027re unsure what to update, send the PR, and we\u0027ll\ndiscuss\n in review.\n4. Note that PRs updating dependencies and new Go versions are not\naccepted.\n Please file an issue instead.\n--\u003e\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nFixes static linking against libraries that have `alwayslink \u003d True`\nspecified. Fixes C++\u0027s dynamic initialization of static variables when\nusing cgo\n\n**Which issues(s) does this PR fix?**\n\nFixes #1486\n\n---\n\nRelated to https://github.com/bazel-contrib/rules_go/pull/2584 and\nhttps://github.com/bazel-contrib/rules_go/pull/2294" }, { "commit": "2d297e9c50cb33ffedc22c566c7767f10db1990c", "tree": "0066a38f8d553da748ddb3b522e997c7ad14d378", "parents": [ "2fd5c183b5a047b7824983a69499157d570cd58d" ], "author": { "name": "David Zbarsky", "email": "dzbarsky@gmail.com", "time": "Thu Sep 04 16:58:04 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Sep 04 20:58:04 2025 +0000" }, "message": "Cleanup path-mapping enablement (#4441)\n\n**What type of PR is this?**\ncode cleanup\n\n**What does this PR do? Why is it needed?**\nThis enables path-mapping for the GoInfo action and simplifies the\n`builder_args`. As a side effect, we now set the `-goroot` flag for link\nactions but they do not yet opt into path mapping (and I don\u0027t think\nthey will work yet, since they use .path on the archives)\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "2fd5c183b5a047b7824983a69499157d570cd58d", "tree": "081536bb370e2dfe82f11093ff2df1fffcf8f22b", "parents": [ "8286eae655d83412d11169ea707592cf0c0979b3" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Thu Sep 04 19:53:26 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Sep 04 19:53:26 2025 +0200" }, "message": "Revert unnecessary test change (#4442)\n\nThis was included in 8286eae655d83412d11169ea707592cf0c0979b3, but\nturned out not to be necessary on Bazel 7 and later." }, { "commit": "8286eae655d83412d11169ea707592cf0c0979b3", "tree": "78d756d166509187e9689cb0fa37571b1e6f8d10", "parents": [ "36d0bcbdcbba5875a828e87ff37e5de74d95667e" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Thu Sep 04 17:13:57 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Sep 04 17:13:57 2025 +0200" }, "message": "Resolve Go and C++ toolchains for each Go target (#4439)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nBefore this change, rules_go would resolve the C++ toolchain for a fixed\nhelper target and use it in Go targets via a provider. This results in\nproblems for multi-platform builds since the execution platform of the\nC++ toolchain needs to match that of the Go toolchain, which can only be\nenforced if both toolchain requirements are declared on the same rule.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4127 \nWork towards\nhttps://github.com/bazel-contrib/rules_go/pull/3740#issuecomment-1904816340\n\n**Other notes for review**" }, { "commit": "36d0bcbdcbba5875a828e87ff37e5de74d95667e", "tree": "7d4425df1655a56c839f67a651469a3125bdb105", "parents": [ "e445813650a492ea2d7ecbefc2dc7772f08dd05e" ], "author": { "name": "Oleg Dashevskii", "email": "olegdashevskii@gmail.com", "time": "Tue Sep 02 12:38:29 2025 +0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Sep 02 07:38:29 2025 +0200" }, "message": "Include blackbox tests in compilation_outputs group (#4437)\n\n**What type of PR is this?**\n\n\u003e Bug fix\n\n**What does this PR do? Why is it needed?**\n\nThe PR makes external test archive included in `compilation_outputs`\noutput group. This is necessary because currently, e.g., `bazel build\n--output_groups\u003dcompilation_outputs //foo/bar:bar_test` won\u0027t build test\nfiles that have `package bar_test` in them.\n\n**Other notes for review**\n\n[Slack\ncontext](https://bazelbuild.slack.com/archives/CDBP88Z0D/p1756742089621919)" }, { "commit": "e445813650a492ea2d7ecbefc2dc7772f08dd05e", "tree": "f45c0fa95e952770450071521aa8da91278468a9", "parents": [ "879148ff288fb0164be1fdabc89f647903a6214d" ], "author": { "name": "Jan Schär", "email": "jan@monogon.tech", "time": "Wed Aug 27 18:30:30 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Aug 27 18:30:30 2025 +0200" }, "message": "Fix trim path problems (#4435)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nThere were multiple problems with trim paths:\n\n- The trim path was inconsistent between non-cgo and cgo. non-cgo\ntrimmed the working directory, and cgo trimmed the parent of the working\ndirectory.\n- For non-cgo, paths in external repos are not trimmed when\n--experimental_sibling_repository_layout is enabled.\n- For cgo, the name of the working directory is included in the output,\nbut this name is not consistent between local and remote builds,\nbreaking reproducibility.\n\nThese are fixed here by creating the trim path in the same way for both\nnon-cgo and cgo, and trimming the working directory as well as replacing\nthe parent of the working directory with `..`. This means that the\nresulting paths are relative to the working directory.\n\nAdditionally, this fixes the existing feature to extend an existing\ntrimpath. It used the wrong separator (`:` instead of `;`), and it\napplied `abs()` to the entire trimpath argument instead of the\nindividual paths inside it. (See\nhttps://github.com/bazel-contrib/rules_go/pull/2994#issuecomment-1012730010\nand\nhttps://github.com/bazel-contrib/rules_go/pull/2994#issuecomment-1012796895)\n\n**Which issues(s) does this PR fix?**\n\nFixes: https://github.com/bazel-contrib/rules_go/issues/4434\nFixes: https://github.com/bazel-contrib/rules_go/issues/4161" }, { "commit": "879148ff288fb0164be1fdabc89f647903a6214d", "tree": "d5d222e7423e245dde70375806773402ad251c1d", "parents": [ "6d90ede1ac59fea5417886329a9cae5eebd1a1b1" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Wed Aug 27 08:17:30 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Aug 27 06:17:30 2025 +0000" }, "message": "Revert back from attribute to rule transitions (#4415)\n\n**What type of PR is this?**\n\nRefactoring\n\n**What does this PR do? Why is it needed?**\n\nPartially reverts #3116, which is no longer necessary now that Bazel 7\nand higher support configurable attributes with rule transitions. As a\nresult, a top-level Go rule shares its configuration with that of the\ngo_context and cgo_context targets it depend on. This unblocks switching\nto joint toolchain resolution for Go and C/C++ in a backwards-compatible\nway.\n\n**Which issues(s) does this PR fix?**\n\n**Other notes for review**" }, { "commit": "6d90ede1ac59fea5417886329a9cae5eebd1a1b1", "tree": "8f610df138f8c500f3979cf6c6b617e908d27856", "parents": [ "696f36cf026ef356ad1ca3bf3735b3dfc3466541" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Mon Aug 25 07:32:28 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Aug 25 05:32:28 2025 +0000" }, "message": "Revert \"go_sdk: store SDK filenames and hashes in lockfile facts\" (#4432)\n\nReverts bazel-contrib/rules_go#4393\n\nThe facts feature didn\u0027t get merged in time for Bazel 8.4.0 and without\nit this PR caused an eager fetch of the version list for the default\nSDK." }, { "commit": "696f36cf026ef356ad1ca3bf3735b3dfc3466541", "tree": "f6b26d55c1786f137aedd56823c061e396667655", "parents": [ "64d9225db70d2e9014217fd8e0340ba4407066fb" ], "author": { "name": "Tom van der Woerdt", "email": "info@tvdw.eu", "time": "Fri Aug 22 11:24:26 2025 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Aug 22 17:24:26 2025 +0200" }, "message": "Sync nogo vets with new ones added up to Go 1.22 (#4431)\n\nThis commit was created by looking at `go tool vet help` (on Go 1.22,\nwhich is the one in go.mod), and adding any tool not yet listed in\nTOOLS_NOGO. I did not remove tools that were listed in nogo but not in\nthe help output. I then addressed all test failures from `bazel test\n//...`.\n\n**What type of PR is this?**\n\n\"chore\" - add new linters.\n\n**What does this PR do? Why is it needed?**\n\nThe list of linters in TOOLS_NOGO was very old; now it\u0027s less old.\n\nFixes #4430" }, { "commit": "64d9225db70d2e9014217fd8e0340ba4407066fb", "tree": "61d65c27d59a99214eddf0b1a653f410ebcf5c26", "parents": [ "4d0a821ecd186c9d73b6a0b7735cb90fafa9701b" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Tue Aug 19 19:40:56 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Aug 19 19:40:56 2025 +0200" }, "message": "Find runfiles when a binary is executed from PATH (#4426)\n\n**What type of PR is this?**\n\nFeature\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\n**Other notes for review**\n\n\nhttps://bazelbuild.slack.com/archives/CDBP88Z0D/p1751654245992999?thread_ts\u003d1751654245.992999\u0026cid\u003dCDBP88Z0D" }, { "commit": "4d0a821ecd186c9d73b6a0b7735cb90fafa9701b", "tree": "2a49d78f11ed5bc953321ce3faea48c6b8e21da3", "parents": [ "22ded4dbd1a329d08824ae5a769dfd1b1c73f839" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Thu Aug 14 20:57:46 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Thu Aug 14 20:57:46 2025 +0200" }, "message": "Compile `cmd/pack` from source and update to Go 1.25 (#4425)\n\n**What type of PR is this?**\n\nFix for compatibility with Go 1.25\n\n**What does this PR do? Why is it needed?**\n\nThe `pack` command, which is no longer shipped as a prebuilt binary with\nGo 1.25, is now compiled from source together with the `builder` binary.\n\nConditional logic is avoided by always compiling `pack` from source,\neven on Go versions before 1.25. By enabling `go build` caching in\n`go_tool_binary`, the overhead compared to building just the `builder`\nbinary is negligible.\n\n**Which issues(s) does this PR fix?**\n\nref: https://github.com/golang/go/issues/74080\nfixes https://github.com/bazel-contrib/rules_go/issues/4398\n\n**Other notes for review**\n\n---------\n\nCo-authored-by: rhang \u003crhang@uber.com\u003e" }, { "commit": "22ded4dbd1a329d08824ae5a769dfd1b1c73f839", "tree": "83062143466472913623876e915694a1d60b71e1", "parents": [ "01544039c4eedd2bea2859b85554984579765ce0" ], "author": { "name": "Philipp Stephani", "email": "p.stephani2@gmail.com", "time": "Tue Aug 12 08:13:11 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Aug 12 08:13:11 2025 +0200" }, "message": "Fix “deprecated” comments. (#4423)\n\nA “deprecated” comment must be a separate paragraph, and there must be\nat least one other paragraph in the docstring. Otherwise pkg.go.dev\nwon’t mark the symbol as deprecated.\n\n**What type of PR is this?**\n\nDocumentation\n\n**What does this PR do? Why is it needed?**\n\nCorrectly marks the deprecated symbols as deprecated on pkg.go.dev.\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" }, { "commit": "01544039c4eedd2bea2859b85554984579765ce0", "tree": "1c8c668cb3d7236a64e2b73b7aff196bb12ee691", "parents": [ "1f993522f463c142c5516f94852c3d6597f717c6" ], "author": { "name": "JB", "email": "jean-baptiste.bronisz@adevinta.com", "time": "Mon Aug 11 20:47:08 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Aug 11 20:47:08 2025 +0200" }, "message": "Fix generation of facts file when diagnostics are ignored (#4422)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nAfter #4402, it is no longer possible to use a custom analyzer without\nhaving to declare a new `Fact` type. The build of a Go library will fail\nif the library contains any external dependencies.\n\nThat\u0027s the case for executing gazelle by example (if we don\u0027t use a\nprecompiled binary):\n\n```\n$ bazel run //:gazelle\nERROR: .../external/gazelle++go_deps+org_golang_x_sync/errgroup/BUILD.bazel:3:11: output \u0027external/gazelle++go_deps+org_golang_x_sync/errgroup/errgroup.facts\u0027 was not created\nERROR: .../external/gazelle++go_deps+org_golang_x_sync/errgroup/BUILD.bazel:3:11: Running nogo on @@gazelle++go_deps+org_golang_x_sync//errgroup:errgroup failed: not all outputs were created or valid\nERROR: .../external/gazelle++go_deps+com_github_bazelbuild_buildtools/labels/BUILD.bazel:3:11: output \u0027external/gazelle++go_deps+com_github_bazelbuild_buildtools/labels/labels.facts\u0027 was not created\nERROR: .../external/gazelle++go_deps+com_github_bazelbuild_buildtools/labels/BUILD.bazel:3:11: Running nogo on @@gazelle++go_deps+com_github_bazelbuild_buildtools//labels:labels failed: not all outputs were created or valid\nERROR: .../external/gazelle++go_deps+in_gopkg_yaml_v3/BUILD.bazel:5:11: output \u0027external/gazelle++go_deps+in_gopkg_yaml_v3/yaml_v3.facts\u0027 was not created\nERROR: .../external/gazelle++go_deps+in_gopkg_yaml_v3/BUILD.bazel:5:11: Running nogo on @@gazelle++go_deps+in_gopkg_yaml_v3//:yaml_v3 failed: not all outputs were created or valid\nERROR: .../external/gazelle++go_deps+org_golang_x_sys/execabs/BUILD.bazel:3:11: output \u0027external/gazelle++go_deps+org_golang_x_sys/execabs/execabs.facts\u0027 was not created\nERROR: .../external/gazelle++go_deps+org_golang_x_sys/execabs/BUILD.bazel:3:11: Running nogo on @@gazelle++go_deps+org_golang_x_sys//execabs:execabs failed: not all outputs were created or valid\n...\n```\n\n**Other notes for review**\n\nThis review continue to skip analysers when ignoring diagnostics, but\nreturn a valid `pkg` to create the missing `.facts` file required by the\nvalidation action, and incidentally, fix a potential crash at line\nhttps://github.com/bazel-contrib/rules_go/blob/1f993522f463c142c5516f94852c3d6597f717c6/go/tools/builders/nogo_main.go#L98." }, { "commit": "1f993522f463c142c5516f94852c3d6597f717c6", "tree": "cbec9e1f6549fcaf84a5bff9efb5f9600ed33949", "parents": [ "4957aa38634a54af69d1d02e510b0ec9df73619d" ], "author": { "name": "Mike Lundy", "email": "mike@fluffypenguin.org", "time": "Wed Aug 06 00:54:07 2025 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Aug 06 09:54:07 2025 +0200" }, "message": "wrap_sdk: make root_files a string_keyed_label_dict (#4419)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\nI\u0027m trying to use an extension-generated repo as a wrapped sdk using\n`root_files`. I get a package load error similar to\nhttps://github.com/bazelbuild/bazel/issues/19301.\n\n**Which issues(s) does this PR fix?**\nI saw in the comments (specifically\nhttps://github.com/bazelbuild/bazel/issues/19301#issuecomment-1694588371)\nthat this would probably work if `root_files` used a\n`string_keyed_label_dict` and, when I tried it locally it did.\n\nFixes #4418\n\n**Other notes for review**\nhttps://github.com/bazelbuild/bazel/issues/19301" }, { "commit": "4957aa38634a54af69d1d02e510b0ec9df73619d", "tree": "569a814af19cd2526fdb9af5473365884510187b", "parents": [ "beb2bbc4dc42a7a10dcedb7b1211e09dad5e1620" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Mon Aug 04 19:50:42 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Aug 04 17:50:42 2025 +0000" }, "message": "Drop compatibility with 6.0.0 (#4411)\n\n**What type of PR is this?**\n\nCleanup\n\n**What does this PR do? Why is it needed?**\n\nSimplify C++ toolchain handling by requiring at least Bazel 6.1.0. This\nwill be used in future PRs to implement proper, exec-platform aware\nresolution for the combination of Go and (optional) C++ toolchain.\n\n**Which issues(s) does this PR fix?**\n\n**Other notes for review**" }, { "commit": "beb2bbc4dc42a7a10dcedb7b1211e09dad5e1620", "tree": "860bde9778fc78db66b7d25a4fa10986c06abf7d", "parents": [ "70ad27dda69759385895f7d691bf5cefcb5da8e2" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Mon Aug 04 18:50:57 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Mon Aug 04 16:50:57 2025 +0000" }, "message": "Consider `go_sdk.wrap` for host compatible SDK (#4410)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\nThis was missed in #4300.\n\n**Which issues(s) does this PR fix?**\n\nFixes #4408 \n\n**Other notes for review**" }, { "commit": "70ad27dda69759385895f7d691bf5cefcb5da8e2", "tree": "8bfd88ac66107f011833ed32262eee0a8f376300", "parents": [ "2af3f27ad40764806a9f36efda6067ea47e9c7c0" ], "author": { "name": "Giovanny Gutiérrez", "email": "giovanny.gutierrez@commure.com", "time": "Sat Aug 02 15:03:36 2025 -0500" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sat Aug 02 22:03:36 2025 +0200" }, "message": "fix: instrumentForCoverage for empty outfiles (#4414)\n\n**What type of PR is this?**\n\nBug fix\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #4412\n\n**Other notes for review**" }, { "commit": "2af3f27ad40764806a9f36efda6067ea47e9c7c0", "tree": "72b179e6c4726e184b704e82caad0e7420461c35", "parents": [ "55932be4203d0f14f79231a143cfaec0836d53d4" ], "author": { "name": "r-hang", "email": "rhang@uber.com", "time": "Thu Jul 31 23:08:50 2025 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Fri Aug 01 08:08:50 2025 +0200" }, "message": "Support integration test coverage system (coverageredesign) (#4397)\n\ngo1.25 removes the current runtime code coverage system adopted by\nrules_go (nocoverageredesign)\nhttps://go-review.googlesource.com/c/go/+/644997\nwhich makes rules_go incompatible with the latest upcoming version of\ngo.\n\nThe change completely adopts the new integration test friendly\ncoverageredesign\nsystem (https://go.dev/blog/integration-test-coverage) in rules_go.\n\nBelow I describe how the current rules_go coverage system currently\nworks, what\nchanges in the new coverage redesign, and what needs to change as a\nresult in\nrules_go.\n\nHow nocoverageredesign currently works:\n\n- rules_go invokes `go tool cover` to generate instrumented source files\nthat\nare then passed to the Go compiler (in compilepkg.go). Instrumented\nsource\nfiles update generated package variable counters.\n\n- The rules_go generated test main (generate_test_main.go) calls\ntesting.RegisterCover to set a global variable that tracks references to\ncoverage generated package local variables that coverage instrumented\ncode\nmodify (ref:\nhttps://github.com/golang/go/blob/go1.24.5/src/testing/cover.go#L72)\nThis replicates the behavior in go test\u0027s generated test main\n(cmd/go/internal/load/test.go)\n\n- rules_go specially adds a call to coverdata.RegisterFile call to all\ncoverage\ninstrumented files which connects each of the file coverage counter\nvariables\nwith a global object and enables rules_go to customize the file name\nthat\ncoverage variables are associated with.\n\n- It\u0027s important to note that because rules_go accesses to this global\ncoverage struct,\nit\u0027s able to manipulate the file path name associated with coverage\ncounter variables.\nThis is important because the lcov format that bazel uses expect exec\nroot relative files.\n\n- When a test exits, This global object is flushed in a call to\n`testing.coverReport()` to\ngenerate a coverage report. This reports gets written a file configured\nin\ntest.coverprofile flag.\n\n- Via a special SetPanicOnExit0 hook, the coverage file set in\ntest.coverprofile\nis coverted to a Bazel friendly Lcov format via logic in\nbzltestutil/lcov.go\n\nWhat changes in coverageredesign:\n\n- A new flexible system for configuring coverage behavior. Instead of a\nsingle\nesting.RegisterCover function, there is a new testdeps package that\nexposes hooks\nto configure behavior.\n\n- The global variable\n(https://github.com/golang/go/blob/go1.24.5/src/testing/cover.go#L72)\nthat tracked all coverage data is completely removed. Instead, functions\nin https://pkg.go.dev/internal/coverage/cfile that are called when\nwriting coverage reports on test exit are internally aware of and able\nto access coverage counter variable data.\n\n- Functionality to flush coverage counter variables write to an\nintermediate\ncoverage directory in a binary format. Hooks configured in the testdeps\npackage\nare responsible for translating this binary format into a human readable\ncoverage\noutput file.\n\n- \u0027go tool cover\u0027 takes a new package based configuration \"pkgcfg\"\noption that\nenables this new coverage instrumentation logic in coverage source\nfiles.\n\n- Coverage counters can be flushed on demand via the APIs of\n\"runtime/coverage\"\nThis allows coverage to work outside of test situations where coverage\nused to rely on exit hooks generated into test mains to flush and write\ncoverage data.\n\nWhat needs to change in rules_go as a result:\n\n- Use the new testdeps configuration system in the rules_go generated\ntest main.\nWe can following the example of the go test generated test main.\nref:\nhttps://github.com/golang/go/blob/go1.24.5/src/cmd/go/internal/load/test.go#L986\n\n- Invoke \u0027go tool cover\u0027 with the new -pkgcfg flag. We can follow the\nexample of\nhow the go toolchain invokes coverage redesign instrumentation in\n\nhttps://github.com/golang/go/blob/go1.24.5/src/cmd/go/internal/work/exec.go#L1932\n\n- Not strictly necessary but removes technical debt, call\nbzltestutil.ConvertCoverToLcov\ninside of testdeps.CoverProcessTestDirFunc hook wrapper instead of the\nbzltestutil.LcovTestDeps SetPanicOnExit0 hook.\n\n- Adjust the output of lcov profile to make file path keys in coverage\nfiles\nexecution root relative.\n\nImplementation Note:\n\nUnfortunately, we still need\ngithub.com/bazelbuild/rules_go/go/tools/coverdata\ndependencies in coverage source files because the lcov coverage format\nexpects file paths associated with coverage data to be execution root\nrelative. coverageredesign writes Go coverage file data in the format of\n`importpath/file_name` which is not execution root (e.g. `src/`)\nrelative.\n\nDuring compilation is the only place we have the information to map\n`importpath/file_name` to an execution root relative path so we have\nto continue to use the trick of generating code that corrects the\nfile path coverage mapping at runtime.\n\nThis makes it hard for coverage to work outside of tests because depend\non a special\ngithub.com/bazelbuild/rules_go/go/tools/coverdata dependency that can\u0027t\nbe\nguaranteed because we don\u0027t control a generated test main in these\nsituations.\n\nIf Go coverage filepaths can be configured during invocations of the `go\ntool cover`, we can break this dependency. I\u0027ve filed an upstream go\nticket\nto descrbe this issue https://github.com/golang/go/issues/74749.\n\nref https://github.com/bazel-contrib/rules_go/issues/3513" }, { "commit": "55932be4203d0f14f79231a143cfaec0836d53d4", "tree": "21c2a4a29817c6c39c72b06cfe7bd0b5c3d7cd1a", "parents": [ "9badb60dd0f9c0d3a78785239373e70373c989b4" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Wed Jul 30 15:46:04 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Jul 30 09:46:04 2025 -0400" }, "message": "Allow targets to fully opt out of nogo (#4403)\n\n**What type of PR is this?**\n\nFeature\n\n**What does this PR do? Why is it needed?**\n\nBy tagging a target with `\"no-nogo\"`, `nogo` isn\u0027t run at all, not even\nfor fact generation.\n\n**Which issues(s) does this PR fix?**\n\nWork towards #4327\n\n**Other notes for review**" }, { "commit": "9badb60dd0f9c0d3a78785239373e70373c989b4", "tree": "fa0e5f844a9c6aa5d6f9d00781ff5da2e586c582", "parents": [ "ad65a6bb2b17bc3db950474d9cd925e10ad1c7db" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Tue Jul 29 22:17:43 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Jul 29 20:17:43 2025 +0000" }, "message": "Skip analyzers that don\u0027t emit facts when ignoring diagnostics (#4402)\n\n**What type of PR is this?**\n\nPerformance improvement\n\n**What does this PR do? Why is it needed?**\n\nAvoid unnecessary work by skipping analyzers that don\u0027t emit facts when\nreported diagnostics are known to be ignored.\n\n**Which issues(s) does this PR fix?**\n\nWork towards #4327\n\n**Other notes for review**" }, { "commit": "ad65a6bb2b17bc3db950474d9cd925e10ad1c7db", "tree": "18b6f3b2d4194afddf7dd1f90e13ffc5d008ebb4", "parents": [ "ffc8ff69552ce68579c7720e303da5d2174d87dc" ], "author": { "name": "Fabian Meumertzheim", "email": "fabian@meumertzhe.im", "time": "Tue Jul 29 21:47:32 2025 +0200" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Tue Jul 29 21:47:32 2025 +0200" }, "message": "Improve caching for devs and CI via `--incompatible_strict_action_env` (#4404)\n\n**What type of PR is this?**\n\nCleanup\n\n**What does this PR do? Why is it needed?**\n\n**Which issues(s) does this PR fix?**\n\nFixes #\n\n**Other notes for review**" } ], "next": "ffc8ff69552ce68579c7720e303da5d2174d87dc" }