tree abffaae9dff38ec0263a12e8174d638641e8aab6
parent d584fa324aa801f59317c364d9f8089cdbf7643c
author Jason Bedard <jason+github@jbedard.ca> 1767919221 -0800
committer GitHub <noreply@github.com> 1767919221 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJpYE51CRC1aQ7uu5UhlAAA8CIQAHXiLQVWxC2o4nWxncqf8vuH
 ibBB1UIBTF1jfvtROeuvRsP5Bbr7XXQt3gDfBYNUhjySKGJl8DkosbyheWjmk9Z4
 wkQwbakBNI4V2jDI2fYh4IwQPSveDuTjsp/WvtszkUQ99XB4SK4b5yqHBlulZASA
 1dGvifuBbO1UK7SiXcvwGdRXZMj5J3AsvT8DAhKgChFeRaZMhx1Yc6C0CA/Mm61Q
 AIwId2dyJWrRnq/BpS4Uo9xa5d7aK81Tuq4dv2l8OqHJkpTDUdMr93DE8ixVtnT6
 aDMXBwymTPScsieilm3H0dT4aOevG96HW2kGGNVV27cD5OLsS3jp7hXpLs350t8G
 CdTdOK3f2q27qGq17LHN0a/ezQrwiGFRrS1pjXLnqJoTqd+YxMtxfrlev2G35dh4
 eJ2Y9OTO37U6rNLGdD/FfCZhgQq61X5DUDdJUfupF4jefrgjJvOu/RWg4+OAqC64
 06hSXmZPXNk066shIzmZuB4xg0sErGDwzYPdNs+/A59A4sPdYPsrV+OvLhfgblB4
 n4uO9lIgsBvVQCnf/ezMvx9UvAGQqRyasm1SroeuJCKq6/8fyauTHNDkuxvurpIr
 qWmvhN2UmQ4Ase1cRyWk6gh73zzRpW2kumQbVoQdA5SrjSXMFTw03/HgeoYKJoqF
 kx3Kpoyjj+v1tPfFKaqv
 =yHdN
 -----END PGP SIGNATURE-----
 

fix: validate node_version[_from_nvmrc] consistently (#3888)

Close #3887

## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)


## PR Type

What kind of change does this PR introduce?

- [x] Bugfix
- [ ] Feature (please, look at the "Scope of the project" section in the
README.md file)
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:


## What is the current behavior?

When using `node_version_from_nvmrc` validation is not performed and the
download macro exits early without error and without
downloading+extracting node.

Issue Number: #3887


## What is the new behavior?

The `node_version` and `node_version_from_nvmrc` validation is aligned
and fail the same.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

---------

Co-authored-by: Alan Agius <alan.agius4@gmail.com>