)]}'
{
  "commit": "5a580307342bf59ff911a86e0bc4e01e6689b04d",
  "tree": "c71c2e44ce68224379a17c0409beea98d088e340",
  "parents": [
    "2923766cec593e11a0394d413ef1704e46330e67"
  ],
  "author": {
    "name": "Matt Handley",
    "email": "applmak@gmail.com",
    "time": "Fri Aug 21 09:36:53 2020 -0500"
  },
  "committer": {
    "name": "Alex Eagle",
    "email": "eagle@post.harvard.edu",
    "time": "Wed Sep 23 13:28:23 2020 -0700"
  },
  "message": "fix(karma): allow custom browsers to specify args (fixes #595)\n\nToday, the args as specified in the various manifests of the rules_webtesting\nbrowsers never make it into the generated karma.conf.js. This results in these\narguments never being used when launching Chrome, preventing customization of\nbrowsers such as window size, enabling remote debugging, or other flag-based\noptions. This PR fixes this by reading those arguments from the manifest, and\nadding them to the browsers list in the generated karma.conf.js.\n\nAlso, this PR includes a change to generated_file_test to allow a golden file\nto represent a substring of the generated output.\n\nAlso Also: This PR includes a golden file test that verified that the generated\nkarma.conf.js does read in the specified value.\n\nFurthermore, the effect of this can be verified manually via:\n```\nVERBOSE_LOGS\u003d1 bazel run packages/karma/test/karma:testing_custom_chrome\n```\nNote the appearance of the additional flags in the new debug output.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "08931b7c92b6847aef734685149f0666614f0ba8",
      "old_mode": 33188,
      "old_path": ".bazelci/presubmit.yml",
      "new_id": "8cfade513f82926cbf01ad55688f64722e753fc2",
      "new_mode": 33188,
      "new_path": ".bazelci/presubmit.yml"
    },
    {
      "type": "modify",
      "old_id": "8385ab5e1d7906578e21a3c37d1aac78092a4832",
      "old_mode": 33188,
      "old_path": "internal/generated_file_test/bin.js",
      "new_id": "0a132589dc781f7f21b3dc826ab85f277aaa90df",
      "new_mode": 33188,
      "new_path": "internal/generated_file_test/bin.js"
    },
    {
      "type": "modify",
      "old_id": "6264a8c372677acd5ed9c6fe384c279f32684780",
      "old_mode": 33188,
      "old_path": "internal/generated_file_test/generated_file_test.bzl",
      "new_id": "ba3f8fe237adaa3a43400e4c5d2aadbebc2dc47b",
      "new_mode": 33188,
      "new_path": "internal/generated_file_test/generated_file_test.bzl"
    },
    {
      "type": "modify",
      "old_id": "0e94be0cfdca4e967605e91c80ec5136ec32c2be",
      "old_mode": 33188,
      "old_path": "packages/karma/karma.conf.js",
      "new_id": "ccc78da5db0245a8ab73733b2584c24fe41025f4",
      "new_mode": 33188,
      "new_path": "packages/karma/karma.conf.js"
    },
    {
      "type": "modify",
      "old_id": "bb6220977ecb398aac9d6c4e8def43a37eed6fd7",
      "old_mode": 33188,
      "old_path": "packages/karma/karma_web_test.bzl",
      "new_id": "58c2f1a0c42d60fd14fc52e838769079b98e5b0e",
      "new_mode": 33188,
      "new_path": "packages/karma/karma_web_test.bzl"
    },
    {
      "type": "modify",
      "old_id": "e261a3b08112595faf50d3e2b5f33d0eff7ffeb9",
      "old_mode": 33188,
      "old_path": "packages/karma/test/karma/BUILD.bazel",
      "new_id": "aee67d3354a5eb0faa0fd50e3fd7cbff25c5d75a",
      "new_mode": 33188,
      "new_path": "packages/karma/test/karma/BUILD.bazel"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "c7798d0ddae44b099056e53681d740a6825ac34d",
      "new_mode": 33188,
      "new_path": "packages/karma/test/karma/custom_chrome.json"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "c3bb4a92bda7cd956eb0d47cce185052bf4400d9",
      "new_mode": 33188,
      "new_path": "packages/karma/test/karma/karma.conf.js.golden"
    }
  ]
}