tree bdadb3fa2180fc6c31de9259e77594618802a53e
parent 2c8e8ac3d0d23294cd666c6eeaea7770a721768f
author JonathanPerry651 <jonathan.perry@gs.com> 1783682043 +0100
committer GitHub <noreply@github.com> 1783682043 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJqUNP7CRC1aQ7uu5UhlAAAS+cQABhLmDdYyq/DGUP7oF9bP2hP
 ug4LBJ0zEuRmCAvhBH4jqUiopNg7XbAu4CPz2jRM/j4YycBYcGnH05oOO10VZfcY
 3Z1fQWi6ahJBVO1raYE3JesggyV8wCuMkYXiS1qmlLmepYOERLUyOnh9mteBvtap
 utcC32odcgtUUcTUb5xXwEl4kCQvfyJLxxJT4iWhJ6LhOQqHOvAqFDDlER8V/U2l
 l57ROW0lldOEeq6h1vjQVRMXdGVAJ84pUslhwlFEux99QyHI0cKZF03vEQBuMQF2
 nYeCheTMX6LCOgft05uRgRb9LQ5rdmpLCr8p7RvFKGwGdFkX2dykWW3h6LF9MHLl
 UM4HiRl9bhVIRL+dp5k9UGfETEQjAaOBycsQnpfZ2NLYEihfjW5EBaMsmoGQYlvt
 MyID4FQRg6rdM3faq+KK5W6P77C0fJBmOaAE73CvKvisCVKZE4I2e2VOg5USHFdu
 WsArP85OIJrTnbYjHRNNR/iN1paIfPTBj2M1GE6wU0Oa0GrH/DB2fy5wInqOSwmA
 fb7yeNGK7qNoIPeSGLzo90bDQpBd5b/LA3SW445y6ak603nZ52XMB7ZAxecwwntW
 xv8EXMMltHO67Qw10GrbHlABbf2Sb69n3fO9mZQuJNgTxJ5F/qT+cHwuyb9BFsjH
 cOn6jVclDHlLz6/6X3Sl
 =Vrc8
 -----END PGP SIGNATURE-----
 

feat: Support pluggable dependency download and metadata caching SPIs (#1589)

Provides pluggable SPIs for rules_jvm_external's dependency resolution, allowing custom download/caching and authentication implementations (such as integrating with Bazel's remote fetcher/downloader APIs) to be registered via classpath plugins.

Key Changes:
1. Public API Targets & SPIs:
   - Created public interfaces for MetadataService, DependencyMetadata, and DownloadService.
   - Added a generic SpiLoader utility to load classpath SPI service implementations (ensuring at most one implementation is loaded per SPI).
   - Exposed custom classpath library loading via the new resolver_extra_dependencies attribute.
   - Decomposed the API targets into fine-grained libraries: :api_core, :download_service, :metadata_service, and :spi_loader.
   - Relocated the build definition closer to the sources in //resolver/src/main/java/com/github/bazelbuild/rules_jvm_external/resolver/BUILD.
   - Flattened public SPI classes into a single package (com.github.bazelbuild.rules_jvm_external.resolver) to prevent split-package issues and avoid spanning multiple packages.

2. Aether & Downloader SPI Integration:
   - Replaced Aether's default HTTP transport with a custom HttpDownloaderTransporterFactory, routing all POM, BOM, and metadata lookups through the pluggable DownloadService SPI.
   - Extracted HttpDownloaderTransporter into its own top-level package-private class.
   - Renamed DownloadService.download to get to match HTTP verb naming conventions and align with head.
   - Implemented null-safe defensive copying of collections in DependencyMetadata constructor using Set.copyOf/Map.copyOf.

3. Inline URL Credentials Handling:
   - Aether downloads are now routed through the pluggable DownloadService SPI backed by HttpDownloader without inline credentials support (making both resolution and downloading fail consistently). Users must configure credentials via .netrc instead.
   - Deleted the shouldDownloadOverHttpWithAuthenticationPassedInOnRepoUrl test from ResolverTestBase.java since that flow does not work and is explicitly unsupported.

4. Cleanup & Optimization:
   - Removed final modifier from SpiLoader class and refactored joining logic to use Guava Joiner.
   - Removed redundant metadata caches and unused resolver binaries.