tree 635bdf3417ecd3e30e81ecf4efe1bfaf04b16a26
parent d6a21d8f334fddf4e34e78eb3d6707a7b726d823
author Tony Aiuto <tony.aiuto@datadoghq.com> 1776829093 -0400
committer GitHub <noreply@github.com> 1776829093 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJp6EKlCRC1aQ7uu5UhlAAA/XcQADX1BrZeCNchD6JTylpslvkB
 woT/Yo+IfFSqyDu2/CkFOysYJu/5Mps0KCd1Hffy6DT7jD8wIOVS/2v2Nl7Q2wwO
 DtNRzr/j5R6v2i9UrG88Cso21x/S+BUBZuo5gBsZ+nhoJwm+T596uFO52aXERgmE
 gsQ3JDBjovJ8NjCoBgkHMoJYxK4XZuSvCKHDQ4ijX8FO9RgqmCQtThAFhMBHb80Z
 nyg9vCK3mjMQQo5f5ZQtf2T7/jppZ3oBntultkpOR3+Ww/rGlKn/64veFrAfO+PR
 xo/PMpFIM0CxQJkVOHaDoanCHs0e+vWkbTzYIgawmTDNd4MnHJ0GKFffhPAL1IYl
 C2hfW7ML1wDpiD6aAUGPx9oWUBvTAALbM5Rq6IXmLlcM2jZONLhqULBIouqD7xF3
 b6P5JZp5WOLn7O5to+Gk+N/BNxl4wmtr7vYlc53CuOK+C8tXneFmwY2gNoN14Kvq
 Wuhc4Eh1PIZm3KHlqtep4lsy/dNhQvpNslVFvLcoXdwrcqTHrinSyW4QEBTRVmoY
 yuDZbGLivEB8e6Qr5AJX3cqx81nkRZZeHFy8sCG0zGRPopyxrScG0EF71PeMNHIg
 ly2Psu0rvPwB9Dj2L1IbgQBnmKNngj6LWILuMOl4RFGnu54y+Gimh46e0UsoEBuq
 RbTvrE+nbWObOPoBmsAb
 =zP4T
 -----END PGP SIGNATURE-----
 

Add package_variables support to pkg_files and pkg_filegroup prefix (#1052)

Closes #781.

pkg_files and pkg_filegroup now accept a package_variables attribute, enabling
make-variable substitution in their prefix attribute. For example:

my_platform_vars(name = "platform_vars", os = "linux", arch = "x86_64")

pkg_filegroup(
    name = "platform_libs",
    srcs = [":my_libs"],
    prefix = "usr/lib/$(os)_$(arch)",
    package_variables = ":platform_vars",
)

Previously the only workaround was select() on prefix, while package_file_name already supported variable substitution via package_variables. This closes the inconsistency: the same mechanism now works for destination paths in the mapping rules.

The implementation follows the same pattern as pkg_deb and pkg_tar, reusing substitute_package_variables() from //pkg/private:util.bzl.

- Admittedly this was too small to use an agent, but it saved me time writing the tests.
- I created a hints file for the next time.