tree 843c9df8e406440986496cab1ec8c1ea7d5163e9
parent c5854cdd32673f62c848964ff3117cac5e6aa563
author Xiaoyi <ashi009@users.noreply.github.com> 1778792865 +0800
committer GitHub <noreply@github.com> 1778792865 -0600
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJqBjmhCRC1aQ7uu5UhlAAAftYQAEfKUy6M8trhqVY4dsw1B9ke
 a0qG3JNOicyORX8+Q+LV41XUUZmMR5lTXtcMhGHQBHdX/AzSXZ8COZQoM4ZTiG6n
 z12dVUzjpGZ4QqJ9xXQrhPUzivE0wKhw9Qars1wl5y5KFvz93+To759eLkbwvqlS
 BZ/Vs+TajayXfAs1SMY5/P+7kAazgGI2eY+VpAhfLp/oS2YR4H35A83ZOg8WshyD
 9LAbKEnh6cqCgWjHgIEYGLUDUUNDPFTiJGYBuPmxd7ZAAHTjQwM827SwDP2Uf8Mt
 4uzQe6t0w2l90JMGeRWausCED9NYH2FSS3X34m1HQOglj+0E259g/HAzYX3T2bJ0
 x3iV9sXAtIuFsQToHx2xzrQ7N5xKvvY4l985tXIPYTQY8xmUWbbBcGh1n8IrfJHm
 FPVIRr+g61weKT++qaxUDauMiQNbw6jmign+QuhzyXr7gCUIjecqLgVsbsKHB1/W
 585gDbsJu7nptnhcQR2hDlGbQk7PJO+lKTqK2rKd2AA0XRA7aUcEn/idBCE9iZhw
 fyQbnJS1ORU/1bluoiwWAdSWG4oUig+bR0REyCsS9OKe8NDd/1ClVNR9+Sfljhsl
 aGI5B7ANCPMXITvTUFmttfjD9VIuiz1j2KaVHVnXhYsjOVY4TEITVuRveAOEFFrS
 dcurD+GB6LhTMoLDukt7
 =zNwe
 -----END PGP SIGNATURE-----
 

fix(tar): drop truthy-string default on store_true argparse flags (#1065)

The `--preserve_mode` and `--preserve_mtime` flags in
`pkg/private/tar/build_tar.py` were declared with `default='False'` (a
string, which is truthy) combined with `action='store_true'`. When the
flags are not passed on the command line, argparse uses the default
verbatim instead of the boolean `False` that `store_true` would produce,
so `options.preserve_mode` and `options.preserve_mtime` end up as the
string `'False'` — truthy under any natural truthy check.

rules_pkg's own use happens to be safe because the check is
`if self.preserve_mode is True`, but the typo is a foot-gun for anyone
copying the pattern.

Drop the bogus default — `action='store_true'` already defaults to
boolean `False`.

Fixes #1064