tree 0e34571d394682586dac7801b1cf67185a7380b7
parent 1388a89dc04374ed33c761e17b7747b85211c063
author Richard Levasseur <rlevasseur@google.com> 1728616375 -0700
committer GitHub <noreply@github.com> 1728616375 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJnCJfHCRC1aQ7uu5UhlAAAGa0QADTJI58uQyb8DFbf40FkJxD1
 EtOAg3MtODfPOIffTrDJHPKORZoxYyvI9PqNwev3y8teGvIKyivYGZMu1kPDO65W
 PwcJXmsSjDyugIFZCN2AiCcbceTNZeuSWSP1WYmtIHEKOWsUHki+Xewqqd0z+uuQ
 02s5YrrmlqwW0tqn/w+abl+a7QASoTNBePRCPbHp7BxKh0GCdrCqw6q4q7ORU6y+
 su2awXtfH9YVjczRkQC5+5VSm5+T9lok+aXtw+rpup0AUY1NZxuX0xa+fY5+szoU
 oz2/AtF0yBuGnGDLYEjig8E9VnkmJbMRcfFjRBrP6yMI1V8/31VY9DZ0FYZzHCdJ
 fP+RcYPNPGDAvGKvQJje5atotbsaAl0Fgay0A2QagY0f30Zg0JQ7ovbK6bheT24R
 htazxHk9NG0gIUTi+rIIXINBJuWL8qOsRyBZp6w9gWngAGmEjtFtTF2catAJmAVn
 jJ96Rw/A/dtduA9a20YpuLk49jnq8i8rkvxibbH+voRf2vwDENBSktksX6KbnLBL
 HwYQyguYo1PWFjqB9ZwGGoldL6/deHbZgc1NCaLLUw5QFOmq8R62BRkLFeiT426Z
 YpBlu9FliZ2tGosWPQHb5+rUkeRibS9AwYiBGvuZM2Z0hZeQ1Hr9mxnRAp+hwCxz
 eNHeh8VcN46QJlANQuTq
 =PCde
 -----END PGP SIGNATURE-----
 

fix(bzlmod): let workspace-invoked python_register_toolchains to register toolchains (#2289)

While migrating to bzlmod, users may have a hybrid build where WORKSPACE
contains
python_register_toolchain() calls. Because these calls originate from
WORKSPACE files,
the `native.register_toolchain` APIs are still available. At the same
time, we still
detect that bzlmod is enabled, and thus disable calling those functions.
The net
effect is, users aren't able to register toolchains in such a hybrid
setup. At the
same time, because the code path is shared, we can't have the bzlmod
toolchain code
try to call them, as it'll fail.

To accomodate both cases, have the bzlmod toolchain code pass a special
arg so that
`python_register_toolchains` knows to skip parts that don't apply to the
bzlmod toolchain
invocation.

This was all unwound by some users and pointed out in a Slack thread. A
few people are
manually carrying an equivalent patch for a working hybrid mode.

Fixes https://github.com/bazelbuild/rules_python/issues/1675