tree 585973c68555a0937083767b06beff3f8e54be77
parent 428c1bbb2c81feacf5e61f44201484c7e3378434
author Richard Levasseur <rlevasseur@google.com> 1738689240 -0800
committer GitHub <noreply@github.com> 1738689240 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJnokroCRC1aQ7uu5UhlAAAcMMQAIyn8sZ2BZ0FouradjuvTY4f
 QWFrf3tSfbnUHCk2q4m6tEGh4IdeqNAQo0LT6fjTkOaB8NZE49uBv7ZBRBbe8vu5
 zf8GrhpO+7GVClka3fohiNuGqgOBOZvdtGpKdbRnUf9Dm5Imnr7JGcduLP2nba7v
 omA7zULcAGRIt1seUP5BzNlL+kNY6gKZRn6bRCHRHnMBp3i5ucgfm+a8LQv2NzRJ
 IYBvWlXs9IrkjRNyukDqrNuXCrmn3sseGifFXZEHRe106cqBEfwDfC/2l2ZsQBhC
 AgPM7l2QFMQ86wCHsD55amaFfgyVoCV4vtiTZV4/1+nW/QJqXkA8NNF2uFpCWTL9
 +DpcjyjGmZ8iwUMcOlpl0c2vRDQa+4++FA7Nqfkpb/UR42rg8Wd2HF6wcMGtnDpV
 9o8lYqkaxAn4hG1SHFft3ZJV3i7KzC/iK70eR5gx15qYzFq7Ghs9H5Wo4ktn9aIR
 ujm9HLweDldVG/idFw0twJhHeEuHC+S6PI2oFh+Tb3bbqzpzbVpK4XaBqkiZuqpz
 D8/X7DYiFPJaALKdEBzQh2j73I42V1wX/FP4qr7LqCVSJb/K0wuXG0GVfvOjMCfM
 qGhHaUsZRpcuriyhlz/aeQ4gmNAvXGkuRongvCkpCPwSZzxJz6x+QN1KLE4izMsN
 tqbBd9rtqHFDLhqIOsdh
 =x7pY
 -----END PGP SIGNATURE-----
 

refactor: expose base rule construction via builders to allow customization for testing (#2600)

The py_reconfig rules work by wrapping: The outer reconfig rule applies
a transition, depends
on an inner py base rule, then jumps through various hoops to ensure it
looks and acts
like the target it's wrapping.

This is error prone, incomplete, and annoying code to maintain. Phil
recently discovered it wasn't properly propagating the output group, so
he had to add that. I wasted time trying to fix a bug I _thought_ was in
it, but actually was working correctly. The logic within it is a bit
hacky as it tries to emulate some of the platform-specific stuff for
windows. Every time
py_reconfig gains something to transition on, there's numerous places to
define, propagate,
and extract the pieces necessary to do it.

To fix this, make the py_reconfig rules not wrap an inner base py rule.
Instead, they use the same underlying rule args that the base rules do.
This lets them act directly as the rule they're designed to test.

Customization is done by capturing all the rule args in builder objects.
The py_reconfig code constructs the same builder the base rules do, then
modifies it as necessary (adding attributes, wrapping the base
transition function). As a bonus, this sets some ground work to allow
more easily defining derivative rules without having to copy/paste
arbitrary parts of how the base rules are defined.

Work towards https://github.com/bazelbuild/rules_python/issues/1647