)]}'
{
  "commit": "b99bb612bbffe2259b6ecd2d41995df7a6f78fde",
  "tree": "9c67feac4d94139f94bc594ed52a615387a28b0e",
  "parents": [
    "b679a794c01c97a82deb2857c374474e32d4c263"
  ],
  "author": {
    "name": "Elvis M. Wianda",
    "email": "7077790+ewianda@users.noreply.github.com",
    "time": "Sat Aug 24 05:07:36 2024 -0400"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Sat Aug 24 09:07:36 2024 +0000"
  },
  "message": "fix(whl_library): remove `--no-index` and add `--no-build-isolation` when build sdist (#2126)\n\nBuilding sdist results in `Could not find a version that satisfies the\nrequirement setuptool` this regressed when a fix in parameter handling\ngot introduced in #2091.\n\nBefore this change the building from sdist when using\n`experimental_index_url`\nwould break because `--no-index` is passed to `pip`. This means that\n`pip`\nwould fail to locate build time dependencies needed for the packages and\nwould\njust not work. In `whl_library` we setup `PYTHONPATH` to have some build\ndependencies available (like `setuptools`) and we could use them during\nbuilding from `sdist` and to do so we need to add `--no-build-isolation`\nflag.\nHowever, for some cases we need to also add other build-time\ndependencies (e.g.\n`flit_core`) so that the building of the wheel in the `repository_rule`\ncontext\nis successfuly. Removing `--no-index` allows `pip` to silently fetch the\nneeded\nbuild dependencies from PyPI if they are missing and continue with the\nbuild.\n\nThis is not a perfect solution, but it does unblock users to use the\n`sdist`\ndistributions with the experimental feature enabled by using\n`experimental_index_url` (see #260 for tracking of the completion).\n\nFixes #2118\nFixes #2152\n\n---------\n\nCo-authored-by: aignas \u003c240938+aignas@users.noreply.github.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "029de8ae110a895dc5a4654901e31b3fda01476f",
      "old_mode": 33188,
      "old_path": "CHANGELOG.md",
      "new_id": "9e59564b9476b80ae39c7fbd44f1921e75b0a450",
      "new_mode": 33188,
      "new_path": "CHANGELOG.md"
    },
    {
      "type": "modify",
      "old_id": "e542f43b0a4c1a10545e07fc2b45f22d19961f76",
      "old_mode": 33188,
      "old_path": "examples/bzlmod/MODULE.bazel.lock",
      "new_id": "4deef01be401224854ae4c36eeeda151c95aa757",
      "new_mode": 33188,
      "new_path": "examples/bzlmod/MODULE.bazel.lock"
    },
    {
      "type": "modify",
      "old_id": "2300eb3598c8578129b73dece3408006e71ebf14",
      "old_mode": 33188,
      "old_path": "python/private/pypi/whl_library.bzl",
      "new_id": "5b14151be693e666d3b6a7dac21ab700956c483a",
      "new_mode": 33188,
      "new_path": "python/private/pypi/whl_library.bzl"
    },
    {
      "type": "delete",
      "old_id": "aba9264953150c0951a266e198d779f1d61a5cc5",
      "old_mode": 33188,
      "old_path": "tests/pypi/evaluate_markers/BUILD.bazel",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "f846bfb12496b14908bb1d672224bcd08e946f5a",
      "new_mode": 33188,
      "new_path": "tests/pypi/integration/BUILD.bazel"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b121446bb0cbd634f1e2374b119a64db77526bc3",
      "new_mode": 33188,
      "new_path": "tests/pypi/integration/transitions.bzl"
    }
  ]
}