tree 9c67feac4d94139f94bc594ed52a615387a28b0e
parent b679a794c01c97a82deb2857c374474e32d4c263
author Elvis M. Wianda <7077790+ewianda@users.noreply.github.com> 1724490456 -0400
committer GitHub <noreply@github.com> 1724490456 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmyaLnCRC1aQ7uu5UhlAAA2iMQAKrinRF16b2rvcCKRURM5lQz
 fWi/HPrqnGKLYV8yIpNtAo1/EkugcRA3km7CFKP9v9HFodCW8ZBgcPXw91Is1mXZ
 qAr0NMlAxtLKu3kUxQ1bSHBL53kKJ0XT9gCS5oYRtIhUi48De1mIF/hQ2MBHmtaO
 NovIGwNH+w8ryQCL8mWNu0RSBo3xzw/J2DYRXLW6pR2N60PbRFMx/Lp+aVb3SIbb
 x3Qc+YHPPIxtVToAS7OI+HSiUisfSGmQyusqJho1QKzD9NtOEA2TxexRveDTWkf5
 whhmNTvEhBNcUJEunNRVSXkkzLivGDem1Qsnh1Rw1ou2tfyGgO4cFHr2glRxfeg3
 ZZDdsEdsZ3VRB1v2/UTzPU6baD+2VCUfeR5VEgoPi2qzwc+e1uVyXcmU1keDx4jF
 HZ12RyfpIkq303sbjTEk7G8MuaN49/i9UaGUuR49zJwovXxYd5tuz3xEjxUw/Pm7
 N97fzW3kJNhzgFZKkCoUZUKmvqOUB5p3Bb2gBtFwnpOOBzjytFL8NVF3R6GKZ38X
 ZKa6NaMWLsSrJftBIrKpdzLGG+xmcvcGtlBCyab6gTJ8mSkuA+r1XKjP12HpEP8P
 hN5lYUCms1trTnXqPB+Dieynwxr449x+VZnbcxfRBURktUzOHlgCqLf9adC1Po9z
 zL3Z0Y86aWfkpPT7C+fn
 =GqjC
 -----END PGP SIGNATURE-----
 

fix(whl_library): remove `--no-index` and add `--no-build-isolation` when build sdist (#2126)

Building sdist results in `Could not find a version that satisfies the
requirement setuptool` this regressed when a fix in parameter handling
got introduced in #2091.

Before this change the building from sdist when using
`experimental_index_url`
would break because `--no-index` is passed to `pip`. This means that
`pip`
would fail to locate build time dependencies needed for the packages and
would
just not work. In `whl_library` we setup `PYTHONPATH` to have some build
dependencies available (like `setuptools`) and we could use them during
building from `sdist` and to do so we need to add `--no-build-isolation`
flag.
However, for some cases we need to also add other build-time
dependencies (e.g.
`flit_core`) so that the building of the wheel in the `repository_rule`
context
is successfuly. Removing `--no-index` allows `pip` to silently fetch the
needed
build dependencies from PyPI if they are missing and continue with the
build.

This is not a perfect solution, but it does unblock users to use the
`sdist`
distributions with the experimental feature enabled by using
`experimental_index_url` (see #260 for tracking of the completion).

Fixes #2118
Fixes #2152

---------

Co-authored-by: aignas <240938+aignas@users.noreply.github.com>