tree 4400f1af2962d26c675f2a7dbf113d662c7fa145
parent 10b28efc376d5810a08afa0d3ba873d89f7436a8
author Richard Levasseur <richardlev@gmail.com> 1765960283 -0800
committer GitHub <noreply@github.com> 1765960283 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJpQmprCRC1aQ7uu5UhlAAAwZQQAIRjN1zYZHjKKZraFR2aBzUw
 +cv7NV8puI5B3STxDFgHwa1V0gVucXZ+9kAA8s78smrIWzpBT52uYQtBV3BsUX3v
 gC9Mq20rpvE3hrlwSIHzUDMXQ+hyQgz4VTqZLNovWOnkv73CyC3lhq7ZaTzac/ka
 z0tI2Egbcxnkx/XkrSkhfCrVAJRlt46zhz+4l57avc1C/Ce8VpeSD29l9g9qn/Ii
 Lj+TAF9No/fSqKTx/pj5Sum5SRBzm1+JoRdmYKRCSaRa01q7VTPR/LQPPNXJDugf
 Jh75KoPjudcJ7KLIfpNfnQtTlFIsUxN/NthBveQnzMTvuJncGYSzVVqaJluTWGj0
 2H3SuMpC1NHOzRT1wOAedFRyg6Z1ddBBFm+KSuGjU5Z8oY1cEKRdYbpaH1V4uXiR
 jMDHBugylH754MsYmCntaqI1gYHbhyfbU6JvFyY038LjdSI+41sXu9TL09wKfUef
 E4mr45IiBMET+7ZkGc0+E3wpX4Bi7KNXHC9/icR+oXD8sjNQa1EWbKPfDvirN9Kc
 +LH4hPT6KS8A9LsfdgG1TzfRQKKzZDMxaXpD+LjvXLlLkYb80BAmpaMFgA11zCaL
 xJyKjHEeXN7K+uKJ8qOd4weVyHm9mrA1rwa4zi3JIyLCZFgGqtKIhnKyq0rU7gyq
 YWK8hSAZXKmLIad9bACz
 =z7EF
 -----END PGP SIGNATURE-----
 

refactor: optimize venv creation for nvidia and pkgutil style namespace packages (#3460)

When pkgutil style namespace packages are used, multiple distributions
provide
the same venv path (e.g. `foo/__init__.py`). The venv symlink logic then
tries to
symlink the `foo/` directory as it looks like the highest linkable
directory. When
conflict merging logic runs later, it then has to flatten a depset with
all the files
in the conflicting distributions.

To fix, have whl_library() try to guess when a file is a pkgutil
namespace package.
These are then pass onto py_library's venv building logic so it can
treat the
directories as not directly linkable. A conflict still occurs, but it
only
contains the single `__init__.py` file.

Along the way, special case the "nvidia" package name and always treat
it as a namespace
package. This is because nvidia packages aren't strictly correct: each
has a blank
`__init__.py` file (which marks it as a regular package, not namespace
package). Special
casing like this is undesirable, but it greatly reduces the number of
conflicts if
e.g. torch is installed, and I couldn't find any other metadata to
indicate it's a
namespace package.

Along the way, add some hints to AGENTS.md so they understand repository
rules better.

Fixes https://github.com/bazel-contrib/rules_python/issues/3401

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>