tree 62ed967d28623cf97714c80cb948aab555a8ce7c
parent 3b48bf81263526f28a41f07176859397033c2160
author Nicholas Junge <nicholas.junge@web.de> 1758482876 +0200
committer GitHub <noreply@github.com> 1758482876 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJo0FHMCRC1aQ7uu5UhlAAA9LQQAAzx+r97fI1YeWv9ouzRBj6P
 +pBeZPRVi9JA8xF+klDjawOsCDpARt0oRzQSzfM9NXMe0+u+5S+gsDxEC2I0F/5z
 ZQmqTDyOd78VgRIN8mhLThJUP5VDFkqdE89fRdp7ZBElQ48t2vqqs37pYbqBZJ5t
 XeI3hwy9TvVWoesNdEwURylvK+9Syfqapc0i6Y0o7IXnVdYjbdz84LSIRqJPo9Ie
 UaD/A3Y5ainf5UlQgrmCMy/y6CpZ1jO7f/i71/rrMmmm3MjBebN662pOtXahxZT3
 Dzbp7jNs+fEs/gMtlxPGstJClm5S2wiUayFKt2HK3KSuIEGs0aGRjhXQ89sEbqnq
 qNovkNZH3chnXn3I7NB2pqWMBOpiaVB6IHFUmTMO5wqD+OoMTC5KtTuCITfoAvGo
 xIBaoFRheEimMiAdlnpa30IaiDjbDExVG1djJvXwLhlrVLiHRHg58lL5ytLEp92r
 CDxiCwpEjpeDIER6miDilNQL84mVB5oUMmVEIpG9JAxRYZAOXols1xcWNas1H2VQ
 wuD00q/SeTHLiGbHGdljyC5UDYjTm8n8lt7eEkGWgtA2c+jqNQPDcbyYkzyDdPvG
 i0D+9ib0qBQvKf/a9XxBHcy9gOuBZaOXh2YX5MAMlgNCVWfxtJUvrj4Vm8jXUWtY
 2qzRp2ZXXtvz0Cpb42f3
 =bboT
 -----END PGP SIGNATURE-----
 

feat(toolchains): ABI3 Python headers target (#3274)

Until now, we silently link extensions with both stable and unstable ABI
libs,
with the latter taking precedence in symbol resolution, because it
appears first
in the linker command AND, crucially, contains all CPython symbols
present in
the stable ABI library, thus overriding them. This has the effect that
stable
ABI extensions on Windows are usable only with the Python distribution
that they
were built on.

To fix, a separate ABI3 header target is introduced, and should be used
for C++
extensions on Windows if stable ABI builds are requested.

Idea as formulated by `@dgrunwald-qt` in
https://github.com/nicholasjng/nanobind-bazel/issues/72#issuecomment-3249959583.

This is motivated by
https://github.com/nicholasjng/nanobind-bazel/issues/72.

This change shifts stable ABI selection on Windows to the extension
developer, where
it has arguably always been (they had to set the `Py_LIMITED_API`
macro).

An upside of this approach is that with a separate target, the question
"stable ABI
or not" can be decided on an extension-by-extension basis, giving
maximum flexibility
to developers. This should not influence the wheel platform target,
because a wheel
is marked ABI3 if and only if all of its extensions are marked as ABI3.

---------

Co-authored-by: Richard Levasseur <rlevasseur@google.com>
Co-authored-by: Richard Levasseur <richardlev@gmail.com>