tree 676fdd01a2f7dfb5d86f0505fa14cc443b5e50ef
parent 721ca37b6f8a96cb96262a9d52851d824efdb9c4
author alex-the-third <139810351+alex-the-third@users.noreply.github.com> 1783031511 +0200
committer github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> 1783065986 +0000

fix: use locale-neutral Windows ACL for build data (#3887)

On localized Windows installations, `build_data_writer.ps1` could fail
when
creating the output file ACL because it used the English localized
`Everyone`
principal name.

This changes the ACL rule to use the language-neutral `WorldSid`
identity
instead, preserving the existing Everyone read permission without
depending on
the display language of Windows.

Before: German and other localized Windows installs could fail with
`IdentityMappedException` / `IdentityNotMappedException`.

After: build data generation succeeds on localized Windows installs.

Fixes #3886

Tests:
`bazelisk test //tests/build_data:build_data_test --config=fast-tests`

---------

Co-authored-by: Richard Levasseur <richardlev@gmail.com>
(cherry picked from commit 8629003966d56fff8c919d7c9dc191bae9715c9e)

Work towards #3867