tree b6a86aa973e144499b808d88c22c496bb32f90b2
parent e3f6258b1e1660652ae044f01c6dac074f9fb206
author Ed Schouten <ed@nuxi.nl> 1717590027 +0200
committer GitHub <noreply@github.com> 1717590027 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmYFgbCRC1aQ7uu5UhlAAApjEQAFwoCDR2+IZxWtLEXoPaiW+D
 vm1XVoVgXJAMBjvNoC0Caf6cY+OJV1n8uNh4e7dV/oeijSkxvAI9QPATwNhRDf8A
 RlexFDoFn/hLGi10iHhrsmGN9eCpnY5e3YO9Oe6zcgcGRo2lggFngiEwdCuNfWm/
 GPoC9ATPw+GtbRM5r+k1o3Z1Jmo9lirbokWfv8rSBiFZnzakS/WMyXo+7rzhf+ie
 G/5pppHR7lEJj7+ax+4BruCipQUnYSv7xToehPpdFDmJZFhilRX/4xaHpIR4FeXs
 EHkctqHGbj055AhIi8A/4ZrUlkhcWRsiqEO2sbECwrRKh6ovoS2RYdOntmEAJTgt
 Zvx+0IM1yzKgYl5vwIKzflLwrQFm5+KQJYOC62uMO07isRlP3IcUPR3sqAtN1ljl
 85HrB7cpvAMsyGhFHOkYm3KMfzFnnuGuulrQVJz6wtUS2bMeLA1JVQKxQYvYtJ2a
 3lu5IpdQBILntO3GfNG0/VK1mUY/0+Zl8GBwmjNQXwxdCl4qy1WIakPh5+UQ78N1
 uTL1qFL9BcAXpl0BsgfX5NlTQESeWnU0y1fk8eTNtzQvSurtfLjGhmHWFw2/QPPN
 M9BpEjDup3UJWz4ONU023NYmfgLzjZEJVnAQUmGXHSiKLeutyZNgk8J0ci1+eHgY
 wDitzotpqsBbsfwQY/Dq
 =vlqo
 -----END PGP SIGNATURE-----
 

Ensure dynamic library dependencies end up in the runfiles directory (#2671)

Right now the runfiles directory only contains "data" that is attached
to a rust_binary() or one of its dependencies. This is inconsistent with
cc_binary() and go_binary(), which also include an `_solib_*/` directory
containing shared library dependencies.

When doing a plain 'bazel run' against the resulting executable, this is
not a noticeable issue. The reason being that the runtime dynamic linker
will use `${execroot}/_solib_*`. However, it does become a problem when
`pkg_tar(include_runfiles = True)` is used to construct an archive of
the binary so that it can be placed in a container image.

This change extends the runfiles gathering logic to merge all
LibraryToLink.dynamic_library files in there as well.