tree d0d8bbe938adf135e50aee4d021c09ea8ca4b0b6
parent 3cbb3fc2b7c3c0ab055eae546741e303bb6079ff
author armandomontanez <amontanez@google.com> 1765295990 -0800
committer GitHub <noreply@github.com> 1765295990 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJpOEeGCRC1aQ7uu5UhlAAAdHUQACzNXmMaVgL+qix8acxQLpEw
 7EU8n6g3GAwxZ8i/AdLVHA5VqkmmPq51r5Ysn69S7kkC34Tgr7wkz21bsNMytyVU
 qkXOPJ+Yy5Q9hr8pwHMNLctQZcA1Q84PCJ5O2XSxjq+33nV9P6C3i099iS3NuMcU
 lBUKomV4iF2lMvPewfaBvUJdc0b8WQpKWVO2xOtRJBpwxJ17FmHQJerQCj2yfKqt
 ELAq2FP6U/R4BDebn3a/OEssKZl9Kq8jCHfH5StPlEOBcp72TCR11T4hM9gqQoKX
 3676xKvM1D0/qsz1cLpOMyOyOnjMOQbgLsCOP5UjmucjO+XIIXi8QvmQHgweazrK
 V8nsZBQQ7cVN4ahdPBC4RPTV0aerZebkeFrIOuvYM3PA/LwgOdwXTvKMeyZVMmBE
 +tvBEnh7Jhe57KBPROvm3lPWfE0JmJaUGeTA8W76DQCuqlV3B2ockle2JmzkloEk
 0jkbaowu7M+5PQlzD6z1d+5Wm05hbRW2n/fwjKp73YyQpLByytUGFNIrWWvKenX8
 8t7/GShYmWwBqEvZNAwrzHHbverxfrwnTYoX9MlJxaN+86LJ3X81WNUjl3kS0MRw
 Gk4o7Fhyz2/vvZsEGafzqGTJJE+fUR8Lt44kAf6DoiJCJPyGKrbGShfFCD/5v2d4
 X1DDvANfo+y4uvXnBl9A
 =hv4h
 -----END PGP SIGNATURE-----
 

Do not forward ARFLAGS (#3763)

This is a partial revert of #3704. It does NOT revert logic that
properly finds the hermetic archiver (binary and associated tests).

cc-rs needs full ownership of flag handling for the archiver. This is in
part due to `ar` having very specific positional flag behaviors, and
partially due to some special logic in how cc-rs constructs static
libraries.

The change to enable `ARFLAGS` was causing many toolchains that pass
flags to the static archiver to error out due to conflicting
expectations for flag handling. Example bad `ar` invocation, where `cq`
is treated as the destination archive instead of the `ar` tool mode:
```
  ar rcsD cq dest.a src1.o src2.o
```
This drops forwarding of `ARFLAGS` to fix the common case.